Bug 225728 - Adding vignette should not increase brightness in the center
Summary: Adding vignette should not increase brightness in the center
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-Vignetting (show other bugs)
Version: unspecified
Platform: Arch Linux Unspecified
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-06 15:31 UTC by Johannes Wienke
Modified: 2016-06-29 19:34 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.2.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Wienke 2010-02-06 15:31:09 UTC
Version:           trunk (using KDE 4.3.4)
Installed from:    Archlinux Packages

Adding a vignette to an image using the new functionality of the vignetting tool increases the brightness of the image in the center of the vignette. This should not happen or only if requested by the user.
Comment 1 Fri13 2010-02-08 10:40:25 UTC
I noticed same problem.

I believe that the tool needs to be redesign.

The effect always is applied to the center of the photo and not to corners of the photo.

Example, when we are to remove the vignetting, the center of photo is darkened so that the photo itself will gain the same level of the lightness. After the fixing, the whole photo needs again fixing by lighting.

Now when we are applying the vigneting. The corners stays same level but are applied a black layer and the center is again edited to be a brighter.

It is like the tool is wrong way. It should always fix the corners and not the center what is correctly lightened in the first place.

So when we remove the vignetting, it should brighten the corners and leave center untouched. And when adding a vignetting to photo, it should darken the corners and not touch the center.
Comment 2 caulier.gilles 2010-02-10 08:35:28 UTC
SVN commit 1088097 by cgilles:

use new BCG api
Fix wrong value with brightness settings to apply it on preview image
CCBUGS: 225728


 M  +32 -36    antivignettingtool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1088097
Comment 3 caulier.gilles 2010-02-10 08:36:16 UTC
Please check current implementation from svn to see if problem with brighness is fixed.

Gilles Caulier
Comment 4 Julien Narboux 2010-02-21 22:02:17 UTC
SVN commit 1093995 by jnarboux:

Reimplement vignetting/antivignetting logic. 
Remove normalizing of the picture. This caused changes in the brightness of the picture which were hard to predict.
Vignetting now decreases exposure in the periphery. Antivignetting increases exposure in the periphery.
The center of the picture is always kept untouched. The new parameter inner circle radius allow user to chose the size of the circle where the image is kept untouched.
Remove Brightness/Contrast/Gamma tools, which I think were used in the post only as a trick to restore brightness by hand in the center of the picture.

CCBUGS: 225728



 M  +0 -2      TODO  
 M  +36 -50    antivignetting.cpp  
 M  +7 -5      antivignetting.h  
 M  +71 -129   antivignettingtool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1093995
Comment 5 Julien Narboux 2010-02-22 07:41:13 UTC
Johannes, 

Can you check if the problem is solved for you ?

Thanks,

Julien
Comment 6 Johannes Wienke 2010-02-22 18:03:51 UTC
Yes, works as expected now, but I would like to have higher values for outer radius and feather. The slider doesn't allow this right now. Is there any reason for this?
Comment 7 Julien Narboux 2010-02-22 21:48:57 UTC
SVN commit 1094477 by jnarboux:

Increase range of parameters.

CCBUGS: 225728



 M  +2 -8      antivignetting.cpp  
 M  +5 -4      antivignettingtool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1094477
Comment 8 Johannes Wienke 2010-03-21 17:29:29 UTC
*** Bug 231562 has been marked as a duplicate of this bug. ***