Bug 222181 - Auto paste of closing braket is broken
Summary: Auto paste of closing braket is broken
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-11 08:14 UTC by Vovochka
Modified: 2010-02-14 10:58 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vovochka 2010-01-11 08:14:16 UTC
Version:           3.3.90 (using 4.3.90 (KDE 4.3.90 (KDE 4.4 RC1)) "release 209", KDE:KDE4:Factory:Desktop / openSUSE_11.2)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.31.8-0.1-desktop

It's totally not working for a single quote. And it doesn't delete closing bracket/quote when deleting opening bracket standing just before closing: () -> )
Comment 1 Milian Wolff 2010-01-13 12:53:49 UTC
*** Bug 222506 has been marked as a duplicate of this bug. ***
Comment 2 Milian Wolff 2010-01-13 14:03:23 UTC
could this be related to the disabled features in the auto braket setting? Dominik, do you know?
Comment 3 Dominik Haumann 2010-01-14 00:17:31 UTC
I removed
- the "blocking" part of inserting corresponding closing brackets and
- removing both opening and closing brackets if there is a match.

If you have for example ((|) where | is the cursor and you press <backspace>, the result is '('. So you have to insert the ')' again. In other words, this is also not always the expected behavior.

I'm fine with adding the deletion of the matching part again for KDE 4.4.
But I don't want to add the "blocking" feature again, which from a user's perspective randomly rejects inserting a closing bracket or quote.
Comment 4 Dominik Haumann 2010-01-14 00:18:53 UTC
SVN commit 1074367 by dhaumann:

Autobracket feature for single quote '
CCBUG: 222181

 M  +1 -0      katedocument.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1074367
Comment 5 Dominik Haumann 2010-01-14 00:20:45 UTC
SVN commit 1074369 by dhaumann:

backport SVN commit 1074367 by dhaumann:

Autobracket feature for single quote '
CCBUG: 222181


 M  +1 -0      katedocument.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1074369
Comment 6 Dominik Haumann 2010-01-16 15:05:55 UTC
SVN commit 1075660 by dhaumann:

revert: delete closing bracket/quote when deleting the corresponding left part
BUG: 222181


 M  +20 -2     katedocument.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1075660
Comment 7 Vovochka 2010-02-10 02:45:09 UTC
This bug is marked as fixed? but!
*** Bug 222506 has been marked as a duplicate of this bug. *** - this one is not!
Comment 8 Dominik Haumann 2010-02-14 10:54:10 UTC
SVN commit 1089860 by dhaumann:

fix regression: with auto brackets + selection
BUG: 222181

 M  +18 -6     katedocument.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1089860
Comment 9 Dominik Haumann 2010-02-14 10:58:02 UTC
ups, in comment #8 i meang bug #222506.