Bug 218522 - Links in KJots are not clickable/executable
Summary: Links in KJots are not clickable/executable
Status: RESOLVED FIXED
Alias: None
Product: kjots
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Stephen Kelly
URL:
Keywords:
: 218521 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-12-13 14:53 UTC by Janet
Modified: 2020-04-24 10:52 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Janet 2009-12-13 14:53:53 UTC
Version:           4.3.4 (using 4.3.4 (KDE 4.3.4), Debian packages)
Compiler:          cc
OS:                Linux (i686) release 2.6.32-0.slh.8-sidux-686

When I insert a link into a kjots sheet, either by dragging it from the browser into the kjots window or by using the Format menu, it is shown underlined like a real link. But it doesn't work that way, clicking on it does nothing. I'd expect that my webbrowser starts when I click a link. I'm not sure if this is a bug or just not implemented.
Comment 1 Janet 2009-12-13 23:23:12 UTC
I just figured out I have to hold Ctrl while clicking to open links. It would be more intuitive when a simple click would trigger the action or if there would be a right click context menu which offers to follow the link - and if the cursor would change to a hand by hovering over the link. A hint somewhere that one has to use Ctrl would also be nice. A one-handed action would also be better for people who cannot use the mouse and the keyboard at the same time.
Comment 2 btuutp45 2010-01-06 23:42:54 UTC
I would like to confirm this same behaviour. I create a link on a page, and it underlines but doesn't allow you to click to activate. However, if you switch back to Book view and mouse over the link it shows a "hand" icon and allows you to click it.

I agree that in Page view it would be intuitive that you can click-it to activate the link and also right-click it to be able to edit the link would be normal behaviour as well.
Comment 3 Nikos Alexandris 2010-04-06 04:16:07 UTC
Same here, when in Page View nothing happens when hovering over a link (yet, Ctrl+Click works as epxected and opens a web-browser).

Would be nice to fix this, i.e. let the mouse pointer change to a "hand" when flying over a link.
Comment 4 Nikos Alexandris 2010-04-06 04:19:39 UTC
Sorry... forgot to mention:

KDE 4.4.2 under Kubuntu 9.10/64-bit
Comment 5 Stephen Kelly 2010-05-10 20:31:24 UTC
*** Bug 218521 has been marked as a duplicate of this bug. ***
Comment 6 apache 2012-07-02 11:41:27 UTC
Please add active links feature KJots. By active links I mean - when I paste a web page address it becomes active the same way as it works in Tomboy, so that when I click on this address the default web browser opens. Of course they should be highlighted in blue as it is in Tomboy, so that they could be more visible. 
http://forum.kde.org/viewtopic.php?f=113&t=102838
Comment 7 Andrew Crouthamel 2018-11-09 00:58:22 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 8 Andrew Crouthamel 2018-11-18 03:21:42 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 9 Igor Poboiko 2020-04-24 10:52:15 UTC
Git commit bd0ea6d00f5c73bfe9c58c929db863a67b6aedb5 by Igor Poboiko.
Committed on 24/04/2020 at 10:52.
Pushed by poboiko into branch 'master'.

[KJotsEdit] Fix links handling in editing mode

Summary:
When user Ctrl+Clicks on the link in the editing mode, emit the linkClicked signal
(which is forwarded to corresponding slot inside `KJotsWidget`).

We use `mousePressEvent` instead of `mouseReleaseEvent` to be able not to move the cursor
when user ctrl+clicks on the link (so we override default `mousePressEvent`, which moves it)

Add visual feedback when hovering the mouse over a link with ctrl pressed (change the cursor to pointing hand)
Add visual feedback when simply hovering the mouse over a link (a tooltip)
Related: bug 215543, bug 244846

Test Plan:
 1. Add Link, Ctrl+Click on it: mouse cursor changes, link opens
 2. Right-click on link: there is "Link" entry, which can be used to edit link
 3. Hover mouse over link: a useful tooltip appears telling user how to open it

Reviewers: dvratil

Reviewed By: dvratil

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D29094

M  +70   -15   src/kjotsedit.cpp
M  +12   -2    src/kjotsedit.h
M  +1    -0    src/kjotswidget.cpp

https://commits.kde.org/kjots/bd0ea6d00f5c73bfe9c58c929db863a67b6aedb5