Bug 215543 - KJots: After ctrl-clicking a link, mouse cursor stays in text shape
Summary: KJots: After ctrl-clicking a link, mouse cursor stays in text shape
Status: RESOLVED FIXED
Alias: None
Product: kjots
Classification: Unmaintained
Component: general (show other bugs)
Version: 4.3.3
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Stephen Kelly
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-21 12:18 UTC by Jack o'Shanter
Modified: 2020-04-24 10:52 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jack o'Shanter 2009-11-21 12:18:47 UTC
Version:            (using KDE 4.3.3)
OS:                Linux
Installed from:    openSUSE RPMs

* Installed from openSUSE's Factory Repo
http://download.opensuse.org/repositories/KDE:/KDE4:/Factory:/Desktop/openSUSE_11.2/

After ctrl-clicking a link, the mouse cursor stays in text shape no matter where you move it.

(1) Make a link
(2) Open it with Ctrl+LClick
(3) Back to the KJots window, move the mouse over the toolbars, menus or sidebar -- cursor doesn't change into an arrow
Comment 1 Andrew Crouthamel 2018-11-02 22:56:15 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 2 Andrew Crouthamel 2018-11-16 05:32:19 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version?

Thank you for helping us make KDE software even better for everyone!
Comment 3 Igor Poboiko 2020-04-24 10:52:15 UTC
Git commit bd0ea6d00f5c73bfe9c58c929db863a67b6aedb5 by Igor Poboiko.
Committed on 24/04/2020 at 10:52.
Pushed by poboiko into branch 'master'.

[KJotsEdit] Fix links handling in editing mode

Summary:
When user Ctrl+Clicks on the link in the editing mode, emit the linkClicked signal
(which is forwarded to corresponding slot inside `KJotsWidget`).

We use `mousePressEvent` instead of `mouseReleaseEvent` to be able not to move the cursor
when user ctrl+clicks on the link (so we override default `mousePressEvent`, which moves it)

Add visual feedback when hovering the mouse over a link with ctrl pressed (change the cursor to pointing hand)
Add visual feedback when simply hovering the mouse over a link (a tooltip)
Related: bug 218522, bug 244846

Test Plan:
 1. Add Link, Ctrl+Click on it: mouse cursor changes, link opens
 2. Right-click on link: there is "Link" entry, which can be used to edit link
 3. Hover mouse over link: a useful tooltip appears telling user how to open it

Reviewers: dvratil

Reviewed By: dvratil

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D29094

M  +70   -15   src/kjotsedit.cpp
M  +12   -2    src/kjotsedit.h
M  +1    -0    src/kjotswidget.cpp

https://commits.kde.org/kjots/bd0ea6d00f5c73bfe9c58c929db863a67b6aedb5