Bug 203966 - Selecting files with SHIFT selects unwanted files
Summary: Selecting files with SHIFT selects unwanted files
Status: RESOLVED DUPLICATE of bug 162030
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Peter Penz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-15 17:39 UTC by FiNeX
Modified: 2009-08-16 11:07 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Video example (162.89 KB, video/ogg)
2009-08-15 17:39 UTC, FiNeX
Details

Note You need to log in before you can comment on or make changes to this bug.
Description FiNeX 2009-08-15 17:39:25 UTC
Created attachment 36174 [details]
Video example

I've found another one bug on the selection of files in the icon view.

For reproduce it simply create some files with short names (i.e: "short_[1..n].txt", displayed in 1 row) and one with a long name (i.e: "long long long long long file name.txt", displayed in 2 rows). The file with a long name have to be placed before the short files.

Selecting files with SHIFT and keyboard arrows (starting from one short file), will select the file with a long name too.

The video example is very useful to understand. The selection (on the video) is done using keyboard only. I select the first file and after I keep SHIFT key pressed and I use the RIGHT key to expand the selection. When the selection goes to the bottom row, the long file is selected too.
Comment 1 FiNeX 2009-08-15 17:41:18 UTC
I've seen bug #201459, but this is different.
Comment 2 Frank Reininghaus 2009-08-15 21:04:14 UTC
This is bug 162030, isn't it? That one's fixed in Qt 4.6, but it hasn't been backported to the Qt 4.5 branch.
Comment 3 FiNeX 2009-08-15 21:47:58 UTC
On bug #162030 the bug were on SHIFT+DOWN, now I've had SHIFT+RIGHT. The result is the same: more file selected than expected. Being the cursor movement implemented recently [1], I've reported it as new.

Anyway probably it could be the same :-)




[1]: I mean that now you can move the selection with LEFT/RIGHT between rows when the current selected file is the first/last of the row.
Comment 4 Frank Reininghaus 2009-08-16 10:25:31 UTC
(In reply to comment #3)
> On bug #162030 the bug were on SHIFT+DOWN, now I've had SHIFT+RIGHT. The result
> is the same: more file selected than expected. Being the cursor movement
> implemented recently [1], I've reported it as new.
> 
> [...]
> 
> [1]: I mean that now you can move the selection with LEFT/RIGHT between rows
> when the current selected file is the first/last of the row.

That doesn't make a difference - the selection is handled by the same code in QListView::setSelection. I've just verified that the Shift-Right issue you've mentioned here is also fixed when using the fixed QListView from Qt 4.6.

*** This bug has been marked as a duplicate of bug 162030 ***
Comment 5 FiNeX 2009-08-16 11:07:28 UTC
Thanks for checking the code Frank :-)