Bug 162030 - Selecting files from keyboard incorrect behaviour.
Summary: Selecting files from keyboard incorrect behaviour.
Status: RESOLVED UPSTREAM
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Peter Penz
URL:
Keywords:
: 186395 193447 203966 205137 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-05-13 11:14 UTC by FiNeX
Modified: 2009-08-26 15:46 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot (309.08 KB, image/jpeg)
2008-05-13 11:15 UTC, FiNeX
Details
Qt-only test case (958 bytes, text/plain)
2009-05-31 19:49 UTC, Frank Reininghaus
Details
Patch for Qt 4.5.1 (1.49 KB, patch)
2009-06-06 01:00 UTC, Frank Reininghaus
Details
Another Qt-only test case for analogous issues in QListView::TopToBottom mode ("Columns" alignment in Dolphin's Icons View) (1.53 KB, text/plain)
2009-06-06 18:43 UTC, Frank Reininghaus
Details

Note You need to log in before you can comment on or make changes to this bug.
Description FiNeX 2008-05-13 11:14:20 UTC
Version:           KDE4 - Revision 806921 (using Devel)
Installed from:    Compiled sources
OS:                Linux

I've found a strange combination of files which cause a weird selection. If I select a particular file and I press SHIFT+DOWN for selecting all files from the selected one to the file below, there are two other files which are selected.

I'll attach an image as example.

This happen on dolphin and in konqueror with the dolphin part.
Comment 1 FiNeX 2008-05-13 11:15:45 UTC
Created attachment 24745 [details]
Screenshot
Comment 2 Peter Penz 2008-05-13 19:43:54 UTC
I can confirm this behavior. I've added Rafael to CC; when turning on the categorization, everything works very well (-> Rafaels KCategorizedView does it right). When turning off the categorization (-> Qt's QListView is used directly), this strange behavior occurs. @Rafael: does http://trolltech.com/developer/task-tracker/index_html?id=199822&method=entry fix this issue too? I'm not sure whether they are related...
Comment 3 Rafael Fernández López 2008-05-15 18:33:48 UTC
No, I'm afraid this bug is not related to http://trolltech.com/developer/task-tracker/index_html?id=199822&method=entry. This task tracker entry was talking about Mouse + Keyboard selection (when it talks about a rectangle on the report, it wants to say a mouse rectangle).

This is a different problem, and should be reported separately to TT.
Comment 4 Rafael Fernández López 2008-05-15 18:36:53 UTC
BTW, I can't reproduce with Qt 4.4.0 here.
Comment 5 Peter Penz 2008-05-15 18:55:32 UTC
> BTW, I can't reproduce with Qt 4.4.0 here. 

Hmm, strange: I tested with Qt 4.4.0 and could reproduce it (only if the categorization is turned off). I'll try to provide a Qt-only example, but this issue has not a high priority currently for KDE 4.1 -> please give me some time... :-)
Comment 6 FiNeX 2008-05-15 19:01:37 UTC
I can reproduce the bug on dolphin using Qt4.4.
@Rafael: what did you do for trying to reproduce the bug?
Comment 7 Rafael Fernández López 2008-06-09 22:14:24 UTC
I can't still reproduce. Please can you retry it ?
Comment 8 FiNeX 2008-06-10 00:13:07 UTC
I can still reproduce using today's trunk.
Even with different files... the selection is messed up.
Comment 9 Chris Kälin 2008-08-10 16:32:35 UTC
Maybe it helps: I cannot select items on more than one line, if there are many files in dolhpin. That means you cannot select (with SHIFT or CTRL) more than that one line on which your cursor is... is this the same bug or should I open a new one?
Comment 10 FiNeX 2008-12-27 11:43:23 UTC
@Chris: please open a new bug, and write a complete explanation which allow us to reproduce it. Thanks!
Comment 11 Frank Reininghaus 2009-05-31 19:49:21 UTC
Created attachment 34152 [details]
Qt-only test case

To see buggy behaviour in my test case, either

1. Go to an element labeled with "Text" in the first row, press Shift+Down.
2. Go to the bottom right element, press Shift+Up (this is bug 186395).
3. Go to the bottom right element, Shift-Click the element above it (this is bug 194751).

In all cases, all elements with wrapped labels are selected in the top row.
All these issues might have the same root cause. I think I'll try to find the root cause in Qt and either submit a patch (if I can come up with one in the next few days) or at least my test case to Qt Software.
Comment 12 Frank Reininghaus 2009-05-31 19:51:37 UTC
Sorry, but I copied&pasted an incorrect bug number in my last comment. The right one is

(In reply to comment #11)
> 3. Go to the bottom right element, Shift-Click the element above it (this is
> bug 193447).
Comment 13 Frank Reininghaus 2009-06-06 01:00:42 UTC
Created attachment 34311 [details]
Patch for Qt 4.5.1

The attached patch (which I've just submitted with my bug report to Qt Software's task tracker) fixes all three issues (and the analogous problems you get when settings the "Arrangement" of the Icons View to "Columns"). I'll mark the other two reports as duplicates.
Comment 14 Frank Reininghaus 2009-06-06 01:02:44 UTC
*** Bug 186395 has been marked as a duplicate of this bug. ***
Comment 15 Frank Reininghaus 2009-06-06 01:02:56 UTC
*** Bug 193447 has been marked as a duplicate of this bug. ***
Comment 16 FiNeX 2009-06-06 10:01:13 UTC
Many thanks Frank! I hope that trolls will apply your patch soon :-) !
Comment 17 Frank Reininghaus 2009-06-06 18:43:56 UTC
Created attachment 34329 [details]
Another Qt-only test case for analogous issues in QListView::TopToBottom mode ("Columns" alignment in Dolphin's Icons View)

I'll upload another test case here so that I can provide a link to the Qt people in my merge request at qt.gitorius.org.
Comment 18 Frank Reininghaus 2009-07-19 03:58:09 UTC
The patch (which I had updated with a new unit test in the meantime) has been accepted for Qt 4.6.0:

http://qt.gitorious.org/qt/qt/commit/5539b4ab311501821eb0e971432d769a25000032

I don't know if it's going to be backported to the Qt 4.5 branch. But anyway, I think we can close this report now :-)
Comment 19 Frank Reininghaus 2009-08-16 10:25:31 UTC
*** Bug 203966 has been marked as a duplicate of this bug. ***
Comment 20 Frank Reininghaus 2009-08-26 15:46:34 UTC
*** Bug 205137 has been marked as a duplicate of this bug. ***