Bug 194598 - Separate color settings for command messages (join, part, nick, etc.) [PATCH]
Summary: Separate color settings for command messages (join, part, nick, etc.) [PATCH]
Status: CONFIRMED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on: 192514
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-30 00:13 UTC by Scott Lerman
Modified: 2013-04-15 01:08 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
add some settings which allow the user to change the colors of join/part/quit messasges (5.47 KB, patch)
2009-06-27 17:12 UTC, Martin Blumenstingl
Details
updated version of the patch (11.32 KB, patch)
2009-07-01 14:18 UTC, Martin Blumenstingl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Lerman 2009-05-30 00:13:41 UTC
Version:           1.2a2 (using KDE 4.2.3)
OS:                Linux
Installed from:    Ubuntu Packages

There's currently a single color setting for command messages. It would be nice if there were separate settings for different events, like join, part, quit, nick, and mode messages.
Comment 1 Martin Blumenstingl 2009-06-27 17:12:52 UTC
Created attachment 34866 [details]
add some settings which allow the user to change the colors of join/part/quit messasges

Hi,

I've made a small patch since I like this feature :)
hope any of the devs could review my patch since I'm very new to
c++/qt (and thus I'm new to konversation's code)

Regards,
Martin
Comment 2 Eike Hein 2009-06-28 18:37:51 UTC
The patch looks ok, but I think we're going to wait until the config dialog revamp lands before we merge this, which changes the Colors preferences page to use a listview approach better suited to more color options.
Comment 3 Martin Blumenstingl 2009-07-01 14:18:23 UTC
Created attachment 34966 [details]
updated version of the patch

Hi,

I've updated my patch a bit
* fixes missing spacers
* more settings added

if the upstream changes are ready feel free to ping me, then I'll try to update my patch

Regards,
Martin