Bug 191236 - Don't fetch lyrics if we already have them
Summary: Don't fetch lyrics if we already have them
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 2.0.90
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 202317 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-05-01 12:49 UTC by Unknown
Modified: 2009-09-15 17:53 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Unknown 2009-05-01 12:49:31 UTC 
Version:           2.0.90 (using 4.2.2 (KDE 4.2.2), Kubuntu packages)
Compiler:          cc
OS:                Linux (i686) release 2.6.28-11-generic

If the lyrics applet already fetched the lyrics of the current song and saved it in the database, it should not query the server for it again. In case you added this behaviour to check for updated lyrics, it would be good to at least have a way to disable it - in times where more and more web access is logged, I don't really want to have an exact log of what I listen to when at some ISP and/or the webserver everything is queried from.
Comment 1 Luca 2009-05-02 17:48:13 UTC 
I support this wish!
Moreover, with 2.1 svn, if i disable every lyrics plugin, the lyrics applet shows this message:
"Lyrics are being fetched."
This happens also if i've already saved the lyrics in the track details, so previously downloaded lyrics are never shown.
Comment 2 Myriam Schweingruber 2009-09-15 00:27:58 UTC 

*** This bug has been marked as a duplicate of bug 186021 ***
Comment 3 Alex Merry 2009-09-15 01:15:50 UTC 
Huh, it seems merge commits aren't emailed out, and so don't close bugs.

Fixed by http://gitorious.org/amarok/amarok/commit/b0a06ac98546cbe0b52e22137333ab76b7433918

Although this bug is marked as a duplicate of Bug 186021, I am not
sure this fixes the problem reported in Bug 186021.
Comment 4 Kuba Serafinowski 2009-09-15 16:08:55 UTC 
*** Bug 202317 has been marked as a duplicate of this bug. ***
Comment 5 Unknown 2009-09-15 17:53:25 UTC 
I can confirm the fix :)