Bug 186021 - Amarok launches Amarok.Lyrics.fetchLyrics signal but it is not necessary
Summary: Amarok launches Amarok.Lyrics.fetchLyrics signal but it is not necessary
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Tools/Script Manager (show other bugs)
Version: 2.0.1
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-03 10:24 UTC by Ignacio Serantes
Modified: 2009-12-09 11:29 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Ignacio Serantes 2009-03-03 10:24:00 UTC 
Version:           2.0.1 (using 4.2.00 (KDE 4.2.0) "release 102", KDE:KDE4:Factory:Desktop / openSUSE_11.1)
Compiler:          gcc
OS:                Linux (i686) release 2.6.27.19-3.2-pae

On first play after launch amarok, Amarok.Lyrics.fechLyrics signal is called always even if the song lyrics already stored.

Steps to reproduce the problem:

1) Launch Amarok, select a song without lyrics and play. If you use a lyrics scripts with storage features, the lyrics are fetched and stored.
2) Stop the player and play again and Amarok use the stored lyrics and don't fetch again from Internet.

You can remove or add music, stop and play as you wish and Amarok.Lyrics.fechLyrics is not called if lyrics are stored in the db.

3) Exit Amarok and launch again.
4) Select a song with stored lyrics and push play. Amarok.Lyrics.fechLyrics is called although the lyrics of the song are stored.
Comment 1 Myriam Schweingruber 2009-05-15 11:04:10 UTC 
Any news on that? Bug is still unconfirmed and 2.0.1 is already quite old...
Comment 2 Myriam Schweingruber 2009-05-31 09:51:23 UTC 
Does this still happen with Amarok 2.1?
Comment 3 Ignacio Serantes 2009-05-31 16:51:44 UTC 
Yes but now, in 2.0.96, is worst because Amarok always is calling for lyrics. I'm have no problem because I write a lyrics script with a cache but is stupid call for lyrics if lyrics are in database.

The lyrics systems must be simple:
if thereIsLyrics {
  displayLyrics();
} else {
  getLyrics();
}

and this must be called one time on song change. No more and no less with the exception of a button to manually call get lyrics again, a refresh button.

I really don't understand why a simple stuff is so complicated in Amarok 2.
Comment 4 Lydia Pintscher 2009-05-31 17:00:12 UTC 
Why hasn't anyone subscribed Peter yet?
Comment 5 Leo Franchi 2009-05-31 17:03:56 UTC 
probably b/c most of the lyrics stuff (even scripting) is mine. i'll take a look when i have a chance.
Comment 6 Peter ZHOU 2009-05-31 18:54:56 UTC 
I'll take a look at this. :)

I am concern about breaking the API before we having a mature versioning system.
This is maybe not the case of breaking the API though.
Comment 7 Myriam Schweingruber 2009-08-02 14:50:24 UTC 
Any news on this?
Comment 8 Martin Blumenstingl 2009-09-15 00:13:57 UTC 
might be a duplicate of #191236
Comment 9 Myriam Schweingruber 2009-09-15 00:27:58 UTC 
*** Bug 191236 has been marked as a duplicate of this bug. ***
Comment 10 Alex Merry 2009-09-15 01:17:01 UTC 
http://gitorious.org/amarok/amarok/commit/b0a06ac98546cbe0b52e22137333ab76b7433918 fixes bug 191236.  I'm not sure it fixes this bug, though.
Comment 11 Myriam Schweingruber 2009-10-21 09:51:51 UTC 
Ignacio, does this still happen with current Amarok 2.2?
Comment 12 Ignacio Serantes 2009-10-21 16:02:30 UTC 
No, I test with current git version and seems to be solved because my lyric is not called if lyrics was stored in db.