Bug 189482 - Add a rename option in the open/save file dialog
Summary: Add a rename option in the open/save file dialog
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: Open/save dialogs (show other bugs)
Version: 5.45.0
Platform: Gentoo Packages Linux
: HI wishlist
Target Milestone: ---
Assignee: David Faure
URL:
Keywords: usability
: 188507 351001 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-04-12 20:58 UTC by Marian Kyral
Modified: 2020-01-10 11:17 UTC (History)
11 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.67
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marian Kyral 2009-04-12 20:58:15 UTC
Version:            (using KDE 4.2.2)
OS:                Linux
Installed from:    Gentoo Packages

Hi,
from time to time I need to rename the file before it is open. E.g.: An version bump of the ebuild is mostly done by renaming the .ebuild file, but it is good to check the ebuild content as well.
The best option is to do it just in the open file dialog. Now it is possible trough "Properties" dialog, but would be good to have the rename option directly in the context menu.

The same situation is in the save dialog. When I'm processing more files, could happen that I save file under the wrong name and I would like to correct it when I'm saving the next file. Again, it is possible trough "Properties", but direct rename option is better. 

Or when I'm creating a new directory and I do a mistake in the name. Direct rename is not possible from the context menu.
Comment 1 Christoph Feck 2009-06-24 04:28:00 UTC
What do you mean with "direct rename"? When you show Properties, the name line edit is already selected, so you just need to type the new name and press Enter. This isn't more work than an additional Rename entry in the context menu.

If you are talking about in-view rename: Please not! I hate this in Windows, where you cannot reliably click on a name without always getting this rename box.
Comment 2 Marian Kyral 2009-06-24 06:19:18 UTC
Hi,
I mean a "Rename" option in context menu. I know I can do it in the Options dialog, but I think not all users know about it. Also would be possible to have key shortcut for rename (F2 in dolphin)
Comment 3 Fri13 2010-09-04 09:48:03 UTC
I would need inline renaming as well. But not the direct renaming. That really was (still is) annoing in Windows and that is annoing in Mac OS X as well.

The properties window does have the ability to rename the file but really, we do not rename files from filemanager from there either. We use F2 or context menu "rename". 

The renaming was removed at some point by usability reasons from Open/save dialog and I must say it was big mistake.

Yes, the Open/Save dialog is not a filemanager but renaming a file is a very important feature. And especially if you have a change to create a new directory, you can in mistake to type wrong name and then you need to go to correct it by opening a filemanager, find the location and then rename it. That is how a normal people does it as they do not use the properties window at all. 

That is as well the reason why Microsoft and Apple allows the renaming by clicking two times the name as it is easier than context menu.
I have the properties tied to Alt+Enter shortcut. But it does not work in Open/Save dialog so well as the name is not selected so I could just correct the name and press enter. Actually it does not work anywhere by that way in 4.5.1. As I call, making name not selected was as well a one usability case as it caused people to clear the name by mistake. But there is not even a Alt shortcut to get to name so I could make Alt+Enter, Alt+N <new name>, Enter

The rename should come back to the Open/Save dialog.
Comment 4 xTed 2011-08-14 21:58:55 UTC
*** This bug has been confirmed by popular vote. ***
Comment 5 Christoph Feck 2015-08-19 09:57:15 UTC
*** Bug 351001 has been marked as a duplicate of this bug. ***
Comment 6 Nate Graham 2018-04-10 22:09:14 UTC
*** Bug 188507 has been marked as a duplicate of this bug. ***
Comment 7 Nate Graham 2018-06-15 04:20:21 UTC
*** Bug 214498 has been marked as a duplicate of this bug. ***
Comment 8 John 2018-12-13 19:53:25 UTC
This is very important to me as well!
It's a feature i miss almost everyday at work.

Every ime i need to rename a file from the open dialog i have to go to the file proprieties. 

Very boring!!!
Comment 9 Nate Graham 2018-12-13 19:56:24 UTC
I am currently working on this. It's a little more involved than I was hoping because KIO doesn't actually have its own renaming UI. I need to either write one or upstream Dolphin's, which is what I'm trying to do right now.
Comment 10 Nate Graham 2018-12-15 02:57:42 UTC
Here's the patch: https://phabricator.kde.org/D17596
Comment 11 Méven Car 2020-01-06 19:40:54 UTC
Git commit 3f5341d3d7e23e3d1f160cd6f4d8188411d75f80 by Méven Car.
Committed on 06/01/2020 at 19:40.
Pushed by meven into branch 'master'.

Upstream Dolphin's file rename dialog

Summary:
KIO didn't actually have its own rename dialog, which is necessary to implement the requested rename-from-the-file-dialog feature (189482). This patch upstreams Dolphin's dialog so all KIO::FileWidgets users can use it.

The file's contents are copied from Dolphin and updated, but the name is changed from `RenameDialog` to `RenameFileDialog` because `RenameDialog` already exists in KIO (and is actually an //overwrite// dialog, but we can't rename it until KF6).

Test Plan:
Apply D17596 or D17597 and initiate a rename operation for one or more files. See that it works as expected.

Tests still pass.

Reviewers: #frameworks, #dolphin, broulik, ngraham, dfaure, elvisangelaccio

Reviewed By: #dolphin, ngraham, dfaure, elvisangelaccio

Subscribers: elvisangelaccio, lydia, dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17595

M  +2    -0    src/widgets/CMakeLists.txt
A  +256  -0    src/widgets/renamefiledialog.cpp     [License: LGPL (v2+)]
A  +79   -0    src/widgets/renamefiledialog.h     [License: LGPL (v2+)]

https://commits.kde.org/kio/3f5341d3d7e23e3d1f160cd6f4d8188411d75f80
Comment 12 Nate Graham 2020-01-06 21:24:51 UTC
Git commit 5ee3e7bb4797a837db1d9de3e661726e623c4cd6 by Nate Graham.
Committed on 06/01/2020 at 21:24.
Pushed by ngraham into branch 'master'.

[KDirOperator] Allow renaming files from the context menu

Summary:
FIXED-IN: 5.67

Depends on D17595

Test Plan:
{F6477636}

- Using the menu item works to rename one or more items
- The menu item is disables when there's no selection
- This menu item is inappropriately enabled for items that cannot be deleted, just like the trash/delete menu item (pre-existing bug, will fix in another patch)

Reviewers: #frameworks, #dolphin, meven

Reviewed By: meven

Subscribers: meven, cfeck, emateli, elvisangelaccio, markuss, dhaumann, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17596

M  +26   -0    src/filewidgets/kdiroperator.cpp
M  +7    -0    src/filewidgets/kdiroperator.h

https://commits.kde.org/kio/5ee3e7bb4797a837db1d9de3e661726e623c4cd6
Comment 13 John 2020-01-10 10:10:56 UTC
Will we get this in Plasma 5.18? :)
Comment 14 Christoph Feck 2020-01-10 11:12:09 UTC
Plasma and Frameworks are released separately. If you use Plasma 5.18 with Frameworks 5.67, then you will have this feature.
Comment 15 John 2020-01-10 11:17:36 UTC
OK, thanks.

I was with the impression that each version of Plasma depended on a specific Frameworks version... Thanks for clearing that out :)