Bug 189302 - Unmounting busy device in dolphin: missing information who is blocking
Summary: Unmounting busy device in dolphin: missing information who is blocking
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Ubuntu Unspecified
: HI wishlist
Target Milestone: ---
Assignee: David Hallas
URL:
Keywords: usability
: 197860 265290 405489 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-04-10 19:21 UTC by samuel.hapak
Modified: 2022-09-04 10:20 UTC (History)
13 users (show)

See Also:
Latest Commit:
Version Fixed In: 19.12.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description samuel.hapak 2009-04-10 19:21:30 UTC
Version:            (using KDE 4.2.2)
Installed from:    Ubuntu Packages

It would be nice if the dolphin will say what application is blocking device from being unmounted instead of just saying it is busy. (This feature worked well in kde3)
Comment 1 Diego 2009-07-05 21:52:23 UTC
A nice additional feature for this wish would be adding the possibility to close (term / kill or whatever) the application or the process blocking the umount operation (for example with a button next to the process name).
Comment 2 Buchan Milne 2010-02-16 15:58:39 UTC
In some cases, the blocking process could be a KDE application. In my case, it is quite often amarok. It would be even nicer if, instead of offering to kill/term the process, in some cases, the user could be offered the option of "Stop playback in amarok".
Comment 3 Frank Reininghaus 2011-02-03 18:32:02 UTC
*** Bug 265290 has been marked as a duplicate of this bug. ***
Comment 4 Jekyll Wu 2012-08-23 22:42:35 UTC
*** Bug 197860 has been marked as a duplicate of this bug. ***
Comment 5 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:18:43 UTC
Resetting assignee to default as per bug #305719
Comment 6 Frank Reininghaus 2014-12-28 22:30:25 UTC
Note that this is not only a Dolphin issue. You can also unmount devices via the system tray, so it might be desirable to add this functionality to the Solid library, such that it would be available everywhere where one can unmount devices.
Comment 8 Diego 2016-01-12 08:36:42 UTC
Kai Uwe, do the changes you mention in your blog extend also to Dolphin? Or are the just tied to Device Notifier? Thanks.
Comment 9 Kai Uwe Broulik 2016-01-12 12:36:45 UTC
This feature wasn't added by me, actually, and is only in the Device Notifier, it is not part of Solid, the message in Dolphin that comes from Solid (KDE's hardware abstraction layer) and wasn't changed. I'll see if it's possible to move the code from Device Notifier to Solid, so all applications benefit from this, and while at it also improve the wording; telling users to run lsof isn't particularly user-friendly.
Comment 10 Nate Graham 2019-03-16 11:53:53 UTC
*** Bug 405489 has been marked as a duplicate of this bug. ***
Comment 11 David Hallas 2019-03-23 08:24:45 UTC
I have a patch in review that implements this:

https://phabricator.kde.org/D19989

Please test, review and provide feedback :D
Comment 12 ncdehnel 2019-05-16 09:59:32 UTC
(In reply to David Hallas from comment #11)
> I have a patch in review that implements this:
> 
> https://phabricator.kde.org/D19989
> 
> Please test, review and provide feedback :D

How do you get the device notifier to show what's using the volume?
Comment 13 David Hallas 2019-05-17 07:26:27 UTC
(In reply to ncdehnel from comment #12)
> (In reply to David Hallas from comment #11)
> > I have a patch in review that implements this:
> > 
> > https://phabricator.kde.org/D19989
> > 
> > Please test, review and provide feedback :D
> 
> How do you get the device notifier to show what's using the volume?

We are simply using lsof :D

Currrently the patch is being split up and put into the appropriate places in the KDE stack, therefore this process is taken a little more time.
Comment 14 ncdehnel 2019-05-17 08:31:47 UTC
(In reply to David Hallas from comment #13)
> (In reply to ncdehnel from comment #12)
> > (In reply to David Hallas from comment #11)
> > > I have a patch in review that implements this:
> > > 
> > > https://phabricator.kde.org/D19989
> > > 
> > > Please test, review and provide feedback :D
> > 
> > How do you get the device notifier to show what's using the volume?
> 
> We are simply using lsof :D
> 
> Currrently the patch is being split up and put into the appropriate places
> in the KDE stack, therefore this process is taken a little more time.

Are you saying device notifier runs lsof internally, or that it tells the user to run lsof? My device notifier just spits out a "not authorized" error when I try to eject something in use.
Comment 15 ncdehnel 2019-05-17 08:37:22 UTC
Ok, I see, it doesn't work with NFS shares, only USB devices. Suppose it would be possible to fix that?
Comment 16 David Hallas 2019-05-20 17:14:05 UTC
(In reply to ncdehnel from comment #15)
> Ok, I see, it doesn't work with NFS shares, only USB devices. Suppose it
> would be possible to fix that?

It might ;D

How do you tell which files are keeping a mount blocked for a NFS mount? Wouldn't lsof provide the information we are looking for?
Comment 17 ncdehnel 2019-05-20 23:21:14 UTC
(In reply to David Hallas from comment #16)
> (In reply to ncdehnel from comment #15)
> > Ok, I see, it doesn't work with NFS shares, only USB devices. Suppose it
> > would be possible to fix that?
> 
> It might ;D
> 
> How do you tell which files are keeping a mount blocked for a NFS mount?
> Wouldn't lsof provide the information we are looking for?

I have to run a lsof command to do it at the moment.
Comment 18 David Hallas 2019-10-27 05:52:32 UTC
Git commit c3b914a7faed3a7c0195ae77b40204cbc8d31fe5 by David Hallas.
Committed on 27/10/2019 at 05:52.
Pushed by hallas into branch 'master'.

Unmounting busy device doesn't tell who is blocking

Summary: Unmounting a busy device from the places panel doesn't tell which applications have open files blocking the unmount.

Test Plan:
Mount a USB stick using Dolphin
Open a file from the USB stick
Unmount the USB stick using Dolphin
Observe the new error message.

Reviewers: #dolphin, elvisangelaccio, ngraham, broulik, meven

Reviewed By: #dolphin, elvisangelaccio, meven

Subscribers: meven, davidedmundson, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D19989

M  +1    -1    CMakeLists.txt
M  +1    -0    src/CMakeLists.txt
M  +25   -1    src/panels/places/placesitemmodel.cpp

https://commits.kde.org/dolphin/c3b914a7faed3a7c0195ae77b40204cbc8d31fe5