Bug 187406 - RTL: Panel reversing directionality after logout / login
Summary: RTL: Panel reversing directionality after logout / login
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: containment-panel (show other bugs)
Version: unspecified
Platform: Ubuntu Unspecified
: NOR major
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: rtl
: 189440 196952 206283 214219 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-03-17 15:05 UTC by Dotan Cohen
Modified: 2010-01-24 17:24 UTC (History)
17 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Panel configuration before logout (32.74 KB, image/png)
2009-03-17 15:05 UTC, Dotan Cohen
Details
Panel configuration after logout and login (31.01 KB, image/png)
2009-03-17 15:06 UTC, Dotan Cohen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dotan Cohen 2009-03-17 15:05:01 UTC
Version:            (using KDE 4.2.1)
Installed from:    Ubuntu Packages

When I configure the panel in KDE, then logout and log back in, the panel applets are in reverse order. This may be related to the fact that my KDE installation is in Hebrew, which is a right-to-left language.
Comment 1 Dotan Cohen 2009-03-17 15:05:31 UTC
Created attachment 32193 [details]
Panel configuration before logout
Comment 2 Dotan Cohen 2009-03-17 15:06:06 UTC
Created attachment 32194 [details]
Panel configuration after logout and login
Comment 3 Dotan Cohen 2009-04-27 10:37:57 UTC
*** Bug 189440 has been marked as a duplicate of this bug. ***
Comment 4 Dotan Cohen 2009-04-27 10:39:13 UTC
This issue affects Arabic users as well as Hebrew users, as a comment on the dupe suggests.

Note that starting plasma with --reverse makes it RTL for English language users to test in.
Comment 5 Zayed Al-Saidi 2009-06-12 12:40:30 UTC
I test this in kde4.2.90 (Arabic interface) and I found it there. It seems that the panel does not remember if it is RTL or LTR. It keep change its layout direction every time the plasma restart.
Comment 6 Zayed Al-Saidi 2009-06-13 04:33:04 UTC
One more comment, the task widget does not effected by this bug as you can see from the screenshots it preserve its layout dirction.
Comment 7 Aaron J. Seigo 2009-06-20 05:07:15 UTC
*** Bug 196952 has been marked as a duplicate of this bug. ***
Comment 8 Aaron J. Seigo 2009-07-08 02:37:42 UTC
SVN commit 992935 by aseigo:

in RTL, the geometries are reversed; compare them with that taken into consideration
BUG:187406


 M  +4 -0      containment.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=992935
Comment 9 Aaron J. Seigo 2009-07-08 02:38:39 UTC
SVN commit 992936 by aseigo:

in RTL, the geometries are reversed; compare them with that taken into consideration
CCBUG:187406


 M  +4 -0      containment.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=992936
Comment 10 Zayed Al-Saidi 2009-07-08 08:07:12 UTC
Hi Aaron,

I tried to test you patch by updating my installation. Unfortunately, I found the problem is still their.
Comment 11 Aaron J. Seigo 2009-07-09 02:04:32 UTC
SVN commit 993594 by aseigo:

swap the comparisons in --reverse
CCBUG:187406


 M  +7 -1      panel.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=993594
Comment 12 Aaron J. Seigo 2009-07-09 02:16:03 UTC
Zayed Al-Saidi: can you updated kdebase/workspace/plasma/containments/panel/ to that last commit (Comment #11) and see if that fixes it for you?

if so ... one oddity of this is that when you switch from LTR to RTL (say, between desktop sessions) the order of the items in the panel won't change. e.g. the menu won't switch from the left side to the right side.

but the order of the panel is at least stable, even after multiple stops and starts with -reverse (or mixing -reverse and not)

i may be able to find a way to get it to reverse and stay that way ... but i'm not sure. that may require recording what the last direction was.
Comment 13 Aaron J. Seigo 2009-07-09 02:36:42 UTC
(note that the initial layout is still properly RTL, so this at least works better for the common case; it's just a bit odd for accounts that bounce between LTR and RTL sessions)
Comment 14 Zayed Al-Saidi 2009-07-09 08:40:05 UTC
Aaron: I update the kdebase/workspace/plasma/containments/panel/ to commit 993594.

But the problem is still there. 

How did I test this?  I have a specific account for testing KDE4.3 and it is always in RTL mode (to test Arabic translation and RTL bugs). I start fresh by deleting .kde4 folder and then logout and login again and change the langauge to Arabic form kcm_laguage. After that I logout and login again (panel in RTL ). Then I logout and login again (now the panel to LTR mode). The panel keeps change its layout direction every login if I choose RTL language.
Comment 15 Diego Iastrubni 2009-09-04 23:43:45 UTC
at changeset 993594 you did:
  (QApplication::layoutDirection() == Qt::RightToLeft) 

is there a reason for this? Containment inherits Applet which inherits QGraphicsWidget, you should use this->layoutDirection() instead of looking at QApplication.

Maybe this also triggers https://bugs.kde.org/show_bug.cgi?id=206283 ?
Comment 16 Rex Dieter 2009-11-12 16:20:20 UTC
*** Bug 214219 has been marked as a duplicate of this bug. ***
Comment 17 raziel 2009-11-12 19:13:23 UTC
please kde fix it !
Comment 18 Mosaab Alzoubi 2009-11-13 12:57:52 UTC
بسم الله الرحمن الرحيم

I use ojuba linux os , Due to this problem I use Arabic Gnome .
Comment 19 Beat Wolf 2009-12-11 20:26:50 UTC
*** Bug 206283 has been marked as a duplicate of this bug. ***
Comment 20 Beat Wolf 2009-12-17 10:24:23 UTC
Is there no RTL user out there that knows a minimum about coding? it is probably not that hard to fix that bug, but without a real RTL enviroment, it's not that easy to do.
Comment 21 Muhammad 2009-12-17 10:50:37 UTC
(In reply to comment #20)
> Is there no RTL user out there that knows a minimum about coding? it is
> probably not that hard to fix that bug, but without a real RTL enviroment, it's
> not that easy to do.

Can you give a clue, please?

I can work on a LTR environment but I need some help where to start..
Comment 22 Dotan Cohen 2009-12-18 15:28:25 UTC
LTR users can get a whole RTL environment yet preserve their preferred language by starting KDE applications with the --reverse flag, like so:
$ kate --reverse
Comment 23 Beat Wolf 2009-12-18 15:39:04 UTC
interesting.
For me the panel is in the right direction when starting plasma with this option.
Comment 24 Zayed Al-Saidi 2009-12-19 06:05:54 UTC
(In reply to comment #23)
> interesting.
> For me the panel is in the right direction when starting plasma with this
> option.

try to restart plasma-desktop more than once.
Comment 25 oc666 2010-01-24 16:40:22 UTC
Hey,
I just test this bug with KDE 4.4 RC1 with plasma 4.3.90 and the bug is gone (on kubuntu 10.04 alpha 2).
Comment 26 Beat Wolf 2010-01-24 16:41:51 UTC
sounds great. if somebody else can confirm this i will close this bug. thank you
Comment 27 Dotan Cohen 2010-01-24 17:24:18 UTC
Confirmed. Thanks!