Bug 186642 - digikam: crashes in image restoration tool
Summary: digikam: crashes in image restoration tool
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-Restoration (show other bugs)
Version: 0.10.0
Platform: unspecified Linux
: NOR crash
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-09 11:13 UTC by Mark Purcell
Modified: 2016-06-30 11:39 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 1.1.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Purcell 2009-03-09 11:13:36 UTC
Version:           0.9.5-beta3 (using 3.5.10, Debian Package 4:3.5.10.dfsg.1-1+b1 (5.0))
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.28-1-686

Forwarded: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=514913
Cc: 514913@bugs.debian.org

From: Wolfram Quester <wolfi@sigxcpu.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: digikam: crashes in image restoration tool
Date: Wed, 11 Feb 2009 21:41:59 +0100

[Message part 1 (text/plain, inline)]
Package: digikam
Version: 2:0.9.5~beta3-1
Severity: normal


Hi altogether!

I can crash digikam in the image restoration tool reproducibly if I abort the
restoration process during preview. To reproduce this, do the following:
- in digikam, select an image,
- click the edit symbol in the toolbar
- open the restoration tool via Enhance -> Restoration
- while the restoration tool loads the first preview, click on the
  stop sign directly right to the progress bar while it shows restoration: ..%
- the process stops, all seems normal
- click the Try button and wait a few seconds until the KDE crash handler opens.
  After I installed digikam-dbg, the crash handler is still unable to create a
  backtrace and says:
  > This backtrace appears to be of no use.  This is probably because your
  > packages are built in a way which prevents creation of proper backtraces, or
  > the stack frame was seriously corrupted in the crash.

  One time the attached backtrace could be obtained.

I use digikam with XFCE as desktop environment.
For me this looks as if in this case a pointer is not properly freed and
reassigned after the Try button is pressed. Perhaps a temporary memory area
which shall contain the preview is freed and then nonetheless reused.

With best wishes,

Wolfi

-- System Information:
Debian Release: 5.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages digikam depends on:
ii  kdebase-kio-plugins    4:3.5.9.dfsg.1-6  core I/O slaves for KDE
ii  kdelibs4c2a            4:3.5.10.dfsg.1-1 core libraries and binaries for al
ii  libc6                  2.7-18            GNU C Library: Shared libraries
ii  libgcc1                1:4.3.3-3         GCC support library
ii  libgphoto2-2           2.4.1-3           gphoto2 digital camera library
ii  libgphoto2-port0       2.4.1-3           gphoto2 digital camera port librar
ii  libjasper1             1.900.1-5.1       The JasPer JPEG-2000 runtime libra
ii  libjpeg62              6b-14             The Independent JPEG Group's JPEG 
ii  libkdcraw4             0.1.7-2           Raw picture decoding C++ library (
ii  libkexiv2-3            0.1.7-1+b1        Qt like interface for the libexiv2
ii  libkipi0               0.1.6-2           library for apps that want to use 
ii  liblcms1               1.17.dfsg-1       Color management library
ii  libpng12-0             1.2.27-2          PNG library - runtime
ii  libqt3-mt              3:3.3.8b-5        Qt GUI Library (Threaded runtime v
ii  libsqlite3-0           3.5.9-6           SQLite 3 shared library
ii  libstdc++6             4.3.3-3           The GNU Standard C++ Library v3
ii  libtiff4               3.8.2-11          Tag Image File Format (TIFF) libra
ii  libx11-6               2:1.1.5-2         X11 client-side library

Versions of packages digikam recommends:
ii  kdeprint                4:3.5.9.dfsg.1-6 print system for KDE
ii  kipi-plugins            0.1.7-2          image manipulation/handling plugin
ii  konqueror               4:3.5.9.dfsg.1-6 KDE's advanced file manager, web b

Versions of packages digikam suggests:
ii  digikam-doc                   0.9.5-1    handbook for digikam and showfoto 

-- no debconf information

[Thread debugging using libthread_db enabled]
[New Thread 0x7f3c2a722730 (LWP 27264)]
[New Thread 0x46826950 (LWP 27339)]
[New Thread 0x46025950 (LWP 27338)]
[New Thread 0x4301f950 (LWP 27335)]
[New Thread 0x45824950 (LWP 27334)]
[New Thread 0x45023950 (LWP 27333)]
[New Thread 0x44822950 (LWP 27331)]
[New Thread 0x44021950 (LWP 27330)]
[New Thread 0x43820950 (LWP 27282)]
[New Thread 0x417ba950 (LWP 27281)]
[New Thread 0x40fb9950 (LWP 27279)]
[New Thread 0x4201d950 (LWP 27278)]
[New Thread 0x4281e950 (LWP 27277)]
0x00007f3c27f73ce2 in select () from /lib/libc.so.6
#0  0x00007f3c27f73ce2 in select () from /lib/libc.so.6
#1  0x00007f3c203659e6 in ?? () from /usr/lib/libxcb.so.1
#2  0x00007f3c20367575 in xcb_wait_for_reply () from /usr/lib/libxcb.so.1
#3  0x00007f3c24dea0ce in _XReply () from /usr/lib/libX11.so.6
#4  0x00007f3c24dddce3 in XSync () from /usr/lib/libX11.so.6
#5  0x00007f3c287e2987 in QPixmap::convertFromImage (this=0x7fff32863520, 
    img=<value optimized out>, conversion_flags=0)
    at kernel/qpixmap_x11.cpp:1913
#6  0x00007f3c2888c639 in QPixmap::convertFromImage (this=0x7fff32863520, 
    image=@0x7fff32860170, mode=4294967295) at kernel/qpixmap.cpp:919
#7  0x00007f3c2a20ec05 in Digikam::DImg::convertToPixmap (this=0x7f3c10536038)
    at /build/buildd/digikam-0.9.5~beta3/./digikam/libs/dimg/dimg.cpp:1166
#8  0x00007f3c2a301943 in Digikam::ImageIface::paint (this=0x7f3c10aa5c50, 
    device=0x7f3c10aa4d00, x=0, y=0, w=360, h=240, underExposure=false, 
    overExposure=false)
    at /build/buildd/digikam-0.9.5~beta3/./digikam/utilities/imageeditor/editor/imageiface.cpp:415
#9  0x00007f3c2a1d0c40 in Digikam::ImagePanIconWidget::updatePixmap (
    this=0x7f3c10aca1b0)
    at /build/buildd/digikam-0.9.5~beta3/./digikam/libs/widgets/imageplugins/imagepaniconwidget.cpp:107
#10 0x00007f3c2a1deb08 in Digikam::PanIconWidget::timerEvent (
    this=0x7f3c10aca1b0, e=0x7fff32860170)
    at /build/buildd/digikam-0.9.5~beta3/./digikam/libs/widgets/common/paniconwidget.cpp:317
#11 0x00007f3c2887aa21 in QObject::event (this=0x7f3c10aca1b0, 
    e=0x7fff32863cd0) at kernel/qobject.cpp:744
#12 0x00007f3c288abdf3 in QWidget::event (this=0x4, e=0x7fff32860170)
    at kernel/qwidget.cpp:4681
#13 0x00007f3c28825953 in QApplication::internalNotify (
    this=<value optimized out>, receiver=0x7f3c10aca1b0, e=0x7fff32863cd0)
    at kernel/qapplication.cpp:2638
#14 0x00007f3c2882662e in QApplication::notify (this=0x7fff32863f50, 
    receiver=0x7f3c10aca1b0, e=0x7fff32863cd0) at kernel/qapplication.cpp:2526
#15 0x00007f3c29146c22 in KApplication::notify (this=0x7fff32863f50, 
    receiver=0x7f3c10aca1b0, event=0x7fff32863cd0)
    at /tmp/buildd/kdelibs-3.5.10.dfsg.1/./kdecore/kapplication.cpp:550
#16 0x00007f3c2881c22b in QEventLoop::activateTimers (
    this=<value optimized out>) at kernel/qapplication.h:523
#17 0x00007f3c287dbc4d in QEventLoop::processEvents (this=0xa29000, flags=0)
    at kernel/qeventloop_x11.cpp:392
#18 0x00007f3c2883a001 in QEventLoop::enterLoop (this=0x4)
    at kernel/qeventloop.cpp:201
#19 0x00007f3c28839eb2 in QEventLoop::exec (this=0x4)
    at kernel/qeventloop.cpp:148
#20 0x0000000000402fee in main (argc=1, argv=0x7fff328643b8)
    at /build/buildd/digikam-0.9.5~beta3/./digikam/digikam/main.cpp:137
Comment 1 caulier.gilles 2009-03-09 11:21:57 UTC
I confirm. There is a problem in CImg library to kell computation thread of Greystoration algorithm.

CImg author contacted. I'm waiting feedback.

Gilles Caulier
Comment 2 caulier.gilles 2009-03-13 12:47:12 UTC
SVN commit 938858 by cgilles:

as recommended by CImg author, use only one separated thread in CImg. Thread management need to be fixed in CImg.
CCBUGS: 186642


 M  +7 -3      greycstorationiface.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=938858
Comment 3 caulier.gilles 2009-03-13 12:50:06 UTC
SVN commit 938860 by cgilles:

backport commit #938858 from KDE3 branch
CCBUGS: 186642


 M  +3 -2      greycstorationiface.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=938860
Comment 4 caulier.gilles 2009-03-16 12:09:08 UTC
ok.

after to have performed a lots of regression tests, i cannot confirm anymore the problem.

I suspect that compilation can be wrong on your computer.

Please do like me : cleanup all, and recompile/install digikam

Gilles
Comment 5 Andi Clemens 2009-03-31 16:43:32 UTC
I can't confirm it either anymore, seems to be fixed.
Comment 6 caulier.gilles 2009-03-31 16:54:03 UTC
yes, it doesn't crash here too...

Gilles
Comment 7 Andi Clemens 2009-07-02 19:14:08 UTC
Mark,

any news here? Does the plugin still crash for you?
Comment 8 Andi Clemens 2009-10-01 17:04:33 UTC
ping ping ping... :-)
Last chance, otherwise I / we will close this report this weekend.

Andi
Comment 9 caulier.gilles 2009-12-25 20:28:57 UTC
digiKam 1.0.0 is out since few days...

http://www.digikam.org/drupal/node/491

Please try with this version coming with more than 400 bug-fixes.

Thanks in advance

Gilles Caulier
Comment 10 Mark Purcell 2009-12-25 23:58:42 UTC
Thanks.

This report can be closed as fixed..

Subject: [Pkg-kde-extras] Bug#514913: Fwd: [Bug 186642] digikam: crashes in 
image restoration tool
Date: Friday 10 April 2009
From: Wolfram Quester <wolfi@sigxcpu.org>
To: Mark Purcell <msp@debian.org>

On Wed, Apr 01, 2009 at 07:40:42AM +1100, Mark Purcell wrote:
> Wolfram,
> 
> Can you confirm this bug is fixed with the upload of digikam 0.9.5?

Well, I can still crash digikam. Well, not exactly crash, but the windows
of digikam and the editor freeze. I have to kill it and restart :-(
But the bug does not seem to be as easily reproducible as the one I reported
initially.
I think this bug can be closed since main development now goes to 0.10.x
anyways.
Comment 11 Mark Purcell 2009-12-25 23:59:05 UTC
Thanks.

This report can be closed as fixed..

Subject: [Pkg-kde-extras] Bug#514913: Fwd: [Bug 186642] digikam: crashes in 
image restoration tool
Date: Friday 10 April 2009
From: Wolfram Quester <wolfi@sigxcpu.org>
To: Mark Purcell <msp@debian.org>

On Wed, Apr 01, 2009 at 07:40:42AM +1100, Mark Purcell wrote:
> Wolfram,
> 
> Can you confirm this bug is fixed with the upload of digikam 0.9.5?

Well, I can still crash digikam. Well, not exactly crash, but the windows
of digikam and the editor freeze. I have to kill it and restart :-(
But the bug does not seem to be as easily reproducible as the one I reported
initially.
I think this bug can be closed since main development now goes to 0.10.x
anyways.