Bug 183315 - Patch: use in picture frame a balance point (?) to view images in the preferred way
Summary: Patch: use in picture frame a balance point (?) to view images in the preferr...
Status: RESOLVED UNMAINTAINED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: widget-frame (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 190595 211469 308723 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-02-05 16:12 UTC by marcello
Modified: 2018-06-08 19:57 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
GUI for selecting the pin point and the frame position setting added (26.21 KB, patch)
2012-01-29 17:06 UTC, Rafal Florek
Details
pin-point setting candidate #2 (15.10 KB, patch)
2012-01-31 17:21 UTC, Rafal Florek
Details
Hover GUI (10.72 KB, patch)
2012-04-23 17:35 UTC, Rafal Florek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description marcello 2009-02-05 16:12:05 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

hi,
i don't know if you have understood what i mean but i can't explain my wish better. i would like to set the visualization of the images myabe setting the corner that should remain fixed and all the others can change depending on the image size and orientation. what do you think about this wish?

thank you

Bye
Marcello
Comment 1 Anne-Marie Mahfouf 2009-02-07 10:00:56 UTC
I understand what you mean and I'll see if it's easy to implement.
Comment 2 Sebastian Voitzsch 2009-11-01 11:05:14 UTC
I second that. In addition, it would be great if the center of the image could be specified as fixed point. I like to position the frame in the bottom right corner of my desk, and this is a little difficult when the fixed point of picture is the top-left corner as it is now.

Thanks
Sebastian
Comment 3 Pierre Buard 2010-05-12 23:47:00 UTC
Bugs 190595 and 211469 look related to this one.
Comment 4 marcello 2010-05-16 18:17:55 UTC
i think both can be marked as duplicates of this bug...
Comment 5 Anne-Marie Mahfouf 2011-10-22 15:01:53 UTC
*** Bug 190595 has been marked as a duplicate of this bug. ***
Comment 6 Anne-Marie Mahfouf 2011-10-22 15:04:22 UTC
*** Bug 211469 has been marked as a duplicate of this bug. ***
Comment 7 Rafal Florek 2012-01-29 17:06:06 UTC
Created attachment 68304 [details]
GUI for selecting the pin point and the frame position setting added
Comment 8 Anne-Marie Mahfouf 2012-01-29 19:29:56 UTC
Hi Rafal,

First, thank you so much for the patch!

I tested it and it's mostly good. However there is the out-of the visible area problem which bothers me and which does not really work. Is there a use case where the user wants half the picture shown for example?  Furthermore adding another Picture Frame makes the first one reappear. And I seem to be unable to set a new pin-point without having the warning dialog. The KMessageBox behavior also is to be improved if it stays.

I would suppress this possibility of out-of the desktop area and make it such that the picture always stays on the visible desktop. Any comment from the users subscribed to this report?

Maybe this is something that could be discussed on the mailing list (plasma-devel@kde.org) if you have a strong opinion about it.
Comment 9 Rafal Florek 2012-01-30 09:35:59 UTC
Hi Anne-Marie,

1. the out-of the visible area problem
I added the warning because it's easy to inadvertently make the widget "disappear" and there's no simple way to move it back. But - in case of slide-show - it is impossible to make sure than none of the pictures sticks out of the desktop. 
I agree that the message box solution is not perfect but some way of keeping the user from placing the frame completely off the screen is IMO important

2. Is there a use case where the user wants half the picture shown for example?
Good question. One use case I can think of is when the user wants the picture to be completely aligned with the screen edge (without the frame) so it has to move the frame partially off the screen

3. Furthermore adding another Picture Frame makes the first one reappear. And I seem to be unable to set a new pin-point without having the warning dialog.
I double check it

Rafal
Comment 10 Rafal Florek 2012-01-31 17:21:23 UTC
Created attachment 68375 [details]
pin-point setting candidate #2

In this version the user selects only the picture pin-point. The desktop pin-point is read automatically from plasmoids' current position/dimension. Thanks to that the "out-of the visible area" and "KMessageBox" problems do not exist.
Comment 11 marcello 2012-02-22 15:05:12 UTC
has this patch been implemented?
Comment 12 Anne-Marie Mahfouf 2012-02-25 17:23:53 UTC
Marcello, no, the patch has not been implemented, it does not work.

If someone wants to have a go to fix it, feel free.
Comment 13 Rafal Florek 2012-02-26 08:39:05 UTC
Hi all,

I believe my second patch fixes all issues raised on the first one. 
The patch's been simplified so the code for the out-of-visible area and KMessageBox is removed. As for the Picture Frame reappearance I noticed such a behavior while testing but it happens also with the original Picture Frame version.
Anyway I'll be glad to fix the patch but I need to know what.

Rafal
Comment 14 Anne-Marie Mahfouf 2012-02-26 14:11:47 UTC
When I choose a pin point and Apply it, nothing happens.

Is your patch against current master? Maybe it was not applied properly... If anyone else could try it, that would help.
Comment 15 Rafal Florek 2012-02-26 15:18:00 UTC
I see, there is some misunderstanding here.
My patch reveals itself only when the content of the Picture Frame changes. For example when a portrait picture is replaced by a landscape one the top left corner keeps its position but the other three usually do not. With this patch the user chooses which point of the picture remains constant.
Marcello, do you understand my description and is this what you ask for?

PS
the patch is against old kde 4.7 version
Comment 16 Anne-Marie Mahfouf 2012-02-26 16:11:45 UTC
I got mixed with the previous patch and position on desktop as well, sorry.

The configuration setting is not self explanatory: the setting does not apply to single pictures (as they don't change) so it should be disabled or something in that case. 

Ideally the setting should just be a pin that would appear on hover on the picture in slideshow mode but that's probably too difficult to implement.

It works, it's a matter of explaining it properly through the GUI.
Comment 17 marcello 2012-03-02 18:00:03 UTC
no rafael, i wansn't thinking this implementation. i was thinking something similar to a central button between the 2 arrows that should enable a pointer in the center of the image, and dragging it, it allows to fix the center of each image. is it possibile? thanks
Comment 18 Rafal Florek 2012-03-25 17:12:45 UTC
Hi all,
Based on your suggestions to set it directly on the picture and not inside the settings dialog here is a proposition which is rather simple to implement. I have only a prototype code so now I submit just a video grab of my desktop. What do you think?
http://rafflo.w.interia.pl/picture_frame_balance_point_setting_gui_demo.ogg
Comment 19 Rafal Florek 2012-04-23 17:35:29 UTC
Created attachment 70608 [details]
Hover GUI

- Usage:
right click->Select balance point
Then 9 radio buttons hover over the picture in predefined points
To make them disappear one needs to move the mouse off the frame
It is the same as next/prev buttons in slide-show mode except the "Select balance point"
- It is called balance and not pin point because the frame is not pinned - it may be moved around as usual.
- The feature is accessible in all modes because the picture may change in all modes (in image mode by: configure dialog, drag&drop, auto refresh)
Comment 20 Jekyll Wu 2014-01-29 01:56:18 UTC
*** Bug 308723 has been marked as a duplicate of this bug. ***
Comment 21 Nate Graham 2018-06-08 19:57:11 UTC
Hello!

This feature request was filed for KDE Plasma 4, which reached end-of-support status in August 2015. KDE Plasma 5's desktop shell has been almost completely rewritten for better performance and usability, so it is likely that this feature request is already implemented in Plasma 5, or is no longer applicable.

Accordingly, we hope you understand why we must close this feature request. If the requested feature is still desired but not implemented in KDE Plasma 5.12 or later, please feel free to open a new ticket in the "plasmashell" product after reading https://community.kde.org/Get_Involved/Bug_Reporting

If you would like to get involved in KDE's bug triaging effort so that future mass bug closes like this are less likely, please read https://community.kde.org/Get_Involved#Bug_Triaging

Thanks for your understanding!

Nate Graham