Bug 175104 - make usb.ids path not hardcoded in kcmusb
Summary: make usb.ids path not hardcoded in kcmusb
Status: RESOLVED INTENTIONAL
Alias: None
Product: kinfocenter
Classification: Applications
Component: USB Devices (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: David Hubner
URL:
Keywords:
: 246361 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-11-14 04:59 UTC by Daniel Mierswa
Modified: 2020-08-06 17:12 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
kinfocenter - usb.ids patch (2.40 KB, patch)
2008-11-14 05:00 UTC, Daniel Mierswa
Details
kinfocenter - usb.ids patch (improved) (2.42 KB, patch)
2008-11-14 05:24 UTC, Daniel Mierswa
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Mierswa 2008-11-14 04:59:43 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

The path /usr/share/hwdata/usb.ids is hardcoded as usb.ids device database in usbdb.cpp. If it doesn't exist, datadir/kcmusb/usb.ids is used. With the attached patch, the initial usb.ids path is passed via cmake or /usr/share/hwdata if it wasn't passed to cmake.
Comment 1 Daniel Mierswa 2008-11-14 05:00:50 UTC
Created attachment 28563 [details]
kinfocenter - usb.ids patch
Comment 2 Daniel Mierswa 2008-11-14 05:24:47 UTC
Created attachment 28564 [details]
kinfocenter - usb.ids patch (improved)

The previous patch only installed the usb.ids file into the system if KDE_USBIDS_DIR wasn't passed to cmake. This version adds an extra DISABLE_USBIDS_INSTALL which must be passed to CMake in order to not install it.
Comment 3 Ingmar Vanhassel 2009-01-07 18:33:23 UTC
Helge, is there anything wrong with this patch?
I'll gladly improve it, but it would be nice to have this in KDE 4.2.
One less patch for me to maintain in Exherbo!

-Ingmar
Comment 4 Ingmar Vanhassel 2010-02-15 22:38:54 UTC
David: I'll look at this this week, I have a slightly better patch that i'll post for review, and commit afterwards. I had to delay this since packaging 4.4.0 took up all my time.
Comment 5 David Hubner 2010-02-17 00:06:07 UTC
Ingmar: Thanks, no rush.. I am trying to get KInfoCenter moved to kdebase-workspace at the moment and KDE SC 4.5 is miles away :)
Comment 6 David Hubner 2010-05-07 04:04:29 UTC
Any news on an updated patch for KDE 4.5?
Comment 7 David Hubner 2010-08-09 22:50:02 UTC
*** Bug 246361 has been marked as a duplicate of this bug. ***
Comment 8 Toralf Förster 2012-04-02 20:48:47 UTC
bug #246361 isn't solved till now, or ?
Comment 9 Toralf Förster 2012-06-20 20:30:23 UTC
Well, I'm unsure whether bug #246361 is really a dup if this  my my issue is now solved.
Comment 10 David Hubner 2012-06-21 23:35:00 UTC
Having a hard coded link to usb.ids when it can technically be in different places is still valid. I do need to get around to fixing this one.
Comment 11 Harald Sitter 2020-01-17 13:52:58 UTC
Why is this useful though?
Comment 12 Harald Sitter 2020-08-06 17:12:10 UTC
Closing in absence of a concrete use case.