Bug 166841 - Collection browsers folds after edit track details
Summary: Collection browsers folds after edit track details
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Collection Browser (show other bugs)
Version: 2.3-GIT
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 167264 170549 175734 177597 205692 206289 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-07-17 14:50 UTC by Maarten Wisse
Modified: 2009-12-09 11:34 UTC (History)
12 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maarten Wisse 2008-07-17 14:51:23 UTC
Version:           2.0-SVN (using KDE 4.0.98)
Installed from:    Compiled From Sources
Compiler:          gcc 4.1.2 
OS:                Linux

After an edit track details action from the collection browser, it folds to the top of the collection tree 'Local Collection'. When unfolding, one's place in the collection, from where the edit track details action was started, is lost.
Comment 1 Mikko C. 2008-07-17 16:46:36 UTC
I can confirm the focus on the position is lost (reset to default), after editing some track details.
Comment 2 Alejandro Wainzinger 2008-07-21 03:09:24 UTC
See bug 164116.  Because currently when doing certain edits of track details Amarok doesn't show the changes, e.g. editing artists, the collection is being forced to refresh, which involves collapsing the collection every time you make a change in track details.

Yes, I realize this is annoying, it's a temporary workaround, and eventually the idea is for it to remember where you were before the update of the collection, but it hasn't been implemented yet.
Comment 3 Maarten Wisse 2008-07-21 10:08:54 UTC
So leave this as a bug I think. Solve the problems with editing the collection first (e.g. #166908), as these are far more serious than this one.
Comment 4 Seb Ruiz 2008-07-23 00:41:34 UTC
*** Bug 167264 has been marked as a duplicate of this bug. ***
Comment 5 Kristjan Ugrin 2008-08-10 21:33:51 UTC
This also shows up when copying tracks onto mtp device.
Any action on collection browser shouldn't do that. It's an usability issue.
Comment 6 Mark Kretschmann 2008-09-06 18:57:05 UTC
*** Bug 170549 has been marked as a duplicate of this bug. ***
Comment 7 Mark Kretschmann 2008-10-27 02:38:40 UTC
We've just decided that the constant folding of the treeview (which happens in many cases) is a major usability issue, and must be fixed ASAP.

Hence I am changing the priority to VHI.
Comment 8 Mark Kretschmann 2008-11-14 09:50:39 UTC
Looking at this report again, I don't think it deserves VHI priority. It's not that critical after all.
Comment 9 Seb Ruiz 2008-11-21 10:39:27 UTC
*** Bug 175734 has been marked as a duplicate of this bug. ***
Comment 10 Johannes Schwall 2008-11-26 16:17:49 UTC
I can confirm this issue for 1.98 (KDE 4.1.3 (KDE 4.1.3) "release 63.3", KDE:KDE4:Factory:Desktop / openSUSE_11.0), and I think it *is* a major usability issue.

I just started Amarok 2 for the first time and am not ready to import my settings from 1.4 yet. So I would have to set "show under various artists" for a lot of albums. This bug would then be really annoying and make the job quite tedious.

(Apart from that: Amarok 2 looks really promising and I'll definitely become a fan as soon as some issues like this one have been cleared.)

BTW: I don't see why the tree should be collapsed in the first place.
Comment 11 S. Burmeister 2008-11-26 16:32:08 UTC
I do not think importing the 1.4 collection deletes it, but to be safe you can make a copy of ~/.kde/share/apps/amarok and import from there. Or what makes you "not ready" yet?
Comment 12 Johannes Schwall 2008-11-26 18:15:57 UTC
Yes, it's the fear of losing ratings, playlists etc. as I have put quite a lot of time in making everything fitting my needs. And I was under the impression that you are/someone is still working on the import stuff.

Apart from that: Amarok 2 has not been officially released yet, so it's not really deemed ready for "production use". So from my perspective: testing is necessary, but without the risk of losing my data.
Comment 13 S. Burmeister 2008-11-26 18:22:23 UTC
On opensuse kde3 and kde4 apps are kept separately, i.e. .kde and .kde4. And making a copy isn't that hard either.
Comment 14 Dan Meltzer 2008-12-02 17:57:28 UTC
This is going to be a bit too complicated to fix for 2.0.0, retargetting.
Comment 15 Mark Kretschmann 2008-12-12 16:12:39 UTC
*** Bug 177597 has been marked as a duplicate of this bug. ***
Comment 16 Josh Benson 2008-12-23 20:16:52 UTC
I can confirm this occurs on OpenSuSE 11.1, KDE 4.1.3 "Release 4.9", with Amarok 2.0-SVN.  I believe this should be a high priority issue.
Comment 17 Maximilian Kossick 2008-12-26 12:01:00 UTC
SVN commit 901623 by mkossick:

filter instead of reseting the the collection tree view whenever one of the collections emit the updated signal.
Make sure that the various artists node is always at the top or bottom of the list
Automatically expand the Various artists nodes after filtering too

BUG: 166841


 M  +6 -0      CollectionSortFilterProxyModel.cpp  
 M  +3 -2      CollectionTreeItemModel.cpp  
 M  +52 -5     CollectionTreeItemModelBase.cpp  
 M  +3 -0      CollectionTreeItemModelBase.h  
 M  +16 -2     CollectionTreeView.cpp  
 M  +1 -0      CollectionTreeView.h  
 M  +2 -1      SingleCollectionTreeItemModel.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=901623
Comment 18 Rafael Tesser 2009-01-06 20:11:58 UTC
Thanks for your work! However, I think this bug should be reopened because the problem is not completely resolved. The tree doesn't fold anymore, but the place where you were in the collection view before editing the track details is not restored. It still scrolls up after track details are edited and the artist subtree is collapsed (I am sorting the collection by Artist/Year - Album).

If you read the bug report you'll see this loose of context was the problem the reporter complained about. The refreshing of the collection was just part of the causes.



Comment 19 Mark Kretschmann 2009-01-06 20:17:58 UTC
@Rafael: Yes, I can confirm this. It's better than it was before, but still not optimal. Reopening.

PS: I'm not sure if it's technically possible to do this correctly. Others will have to decide about that.
Comment 20 Myriam Schweingruber 2009-07-16 13:02:32 UTC
Any news on this bug? No changes since January...
Comment 21 Myriam Schweingruber 2009-07-16 14:16:55 UTC
Still present in 2.2-SVN, r997463
Comment 22 Myriam Schweingruber 2009-08-09 15:40:09 UTC
This still happens in latest 2.2-git and is really annoying!
Comment 23 Mikko C. 2009-08-30 14:56:31 UTC
*** Bug 205692 has been marked as a duplicate of this bug. ***
Comment 24 Mikko C. 2009-09-05 09:48:32 UTC
*** Bug 206289 has been marked as a duplicate of this bug. ***
Comment 25 Maximilian Kossick 2009-09-05 10:25:42 UTC
Fixed for 2.2-beta2