Bug 163693 - SystemSettings: Cancel the "Unsaved Changes" dialog, shows one module, but a different one is selected in the left icon module list
Summary: SystemSettings: Cancel the "Unsaved Changes" dialog, shows one module, but a ...
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: 0.2
Platform: Compiled Sources Linux
: NOR normal (vote)
Target Milestone: ---
Assignee: System Settings Bugs
: 164122 193509 228270 (view as bug list)
Depends on:
Reported: 2008-06-10 11:25 UTC by Robert Smit
Modified: 2010-08-26 20:11 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.5.1


Note You need to log in before you can comment on or make changes to this bug.
Description Robert Smit 2008-06-10 11:25:57 UTC
Version:            (using Devel)
Installed from:    Compiled sources
OS:                Linux

After making changes to settings in a settings page. If the user moves on without applying the changes the "unsaved changes" dialog box appears asking if you want to save or discard the changes. 

If the user selects cancel here s/he is put back to the settings page they just left, with their settings still waiting to be applied BUT now the apply button is disabled.
Comment 1 Robert Smit 2008-06-10 11:26:46 UTC
using 4.1 beta 1 from ubuntu repositories
Comment 2 Robert Smit 2008-06-10 11:35:32 UTC
Correction it appears that the changes are actually committed when you cancel the "unsaved changes" dialog. It also appears that the icons denoting the page I'm on is now not indicating the correct page.

1) select appearance->fonts
2) change fonts
3) select icons page (still under appearance)
4) in "unsaved changes" dialog select cancel
5) changes have still been applied
6) although we are back in the fonts page the page selection on the left still indicates we are on icons page
Comment 3 FiNeX 2008-11-14 00:16:02 UTC
I can confirm what Robert wrote on comment #2. I're reproduced using current trunk.
Comment 4 Dario Andres 2009-01-16 17:46:22 UTC
I'm following the bug in comment 3, and it seems to be a bug in KDEUi
Comment 5 Dario Andres 2009-04-10 20:15:15 UTC
*** Bug 164122 has been marked as a duplicate of this bug. ***
Comment 6 Christoph Feck 2009-12-02 12:56:53 UTC
*** Bug 193509 has been marked as a duplicate of this bug. ***
Comment 7 Christoph Feck 2010-01-05 19:04:45 UTC
SVN commit 1070452 by cfeck:

Fix wrong selected icon after canceling changes

The problem was the signal blocking.

CCMAIL: sourtooth@gmail.com
BUG: 163693

 M  +1 -1      ModuleView.cpp  

WebSVN link: http://websvn.kde.org/?view=rev&revision=1070452
Comment 8 Christoph Feck 2010-01-05 20:34:44 UTC
SVN commit 1070487 by cfeck:

Revert last commit

This unfortunately crashed when going back to overview.
Ben, could you look into this? I really like would
bug 163693 fixed.

CCBUG: 163693
CCMAIL: sourtooth@gmail.com

 M  +1 -1      ModuleView.cpp  

WebSVN link: http://websvn.kde.org/?view=rev&revision=1070487
Comment 9 Ben Cooksley 2010-01-05 21:48:40 UTC
This is a bug in the KDELibs class I think, which doesn't change the selected item in the side view when performing the change of current page programatically.

I have to block signals in the function which checks for changes since otherwise the setCurrentPage() call will result in it being called recursively.
Comment 10 Christoph Feck 2010-02-26 00:02:04 UTC
*** Bug 228270 has been marked as a duplicate of this bug. ***
Comment 11 Samoilenko Yuri 2010-02-26 08:11:35 UTC
(In reply to comment #9)
> This is a bug in the KDELibs class I think...

Yes, I reached this bug when make own dialog through KPageDialog. I try to handle "apply/reject/cancell" fallback using 
KPageDialog::currentPageChanged(KPageWidgetItem *current, KPageWidgetItem
*before) signal, and when in connected slot I call currentPageChanged::setCurrentPage(before), then
such effect appeared.
Comment 12 Daniel Nicoletti 2010-08-26 19:33:08 UTC
Bug fixed in r1168413 by correcting KPageView's connection to selectionChanged() instead of currentChanged()

Comment 13 Christoph Feck 2010-08-26 20:11:03 UTC
Backported to 4.5 branch for 4.5.1 (to keep fresh and impatient contributors going ;)