Bug 160863 - kaudiocreator refuses to rip if it does not recognize the CDDB genre tag
Summary: kaudiocreator refuses to rip if it does not recognize the CDDB genre tag
Status: RESOLVED WORKSFORME
Alias: None
Product: kaudiocreator
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Gerd Fleischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-15 14:53 UTC by Tim Pierce
Modified: 2023-01-12 05:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Pierce 2008-04-15 14:53:54 UTC
Version:           1.13 (using 3.5.8, Kubuntu (gutsy) 4:3.5.8-0ubuntu3.3)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.22-14-generic

When kaudiocreator performs a CDDB lookup on a new CD, sometimes the CDDB genre is unknown to LAME. When that happens, kaudiocreator silently accepts the CDDB genre and passes it to LAME, which only reports an error at encoding time.

I am reporting this as a bug only because it seems like a mistake for kaudiocreator to accept the genre in the first place if LAME is only going to reject it farther down the line.

Suggestion for better behavior: at launch time, if LAME is the requested encoder, kaudiocreator should use the output of "lame --genre-list" to set default genre names.  If CDDB returns a genre tag not included there, it should warn the user and ask them for an alternative before the user initiates a rip/encode cycle.  The application could even try fuzzy matching to propose a good alternative genre (but that is definitely a feature request, not a bug report).
Comment 1 Tim Pierce 2008-04-15 14:55:21 UTC
Addendum: this is related to bug 52257 and bug 53046, which also deal with LAME refusing to encode on an unknown genre, but I did not file it there because it is not related to an internationalization issue and so it seemed inappropriate.
Comment 2 RobMo 2010-01-11 07:31:03 UTC
Contrary to  Bug 52257 , this bug can surface in all language versions.
The root cause of this bug is:
Freedb, CDDB and Lame genres are slightly different.
Lame fails when it gets a genre that is not on its list.

This is also documented in 
https://bugs.launchpad.net/ubuntu/+source/kdemultimedia/+bug/77209

Reproduced this (or a very similar bug)

1. CDDB / freedb.org - look-up must succeed
2. Note: CDDB entry DGENRE=Book
3. Note that "Book" is not a valid LAME genre ( see: http://lame.cvs.sourceforge.net/*checkout*/lame/lame/doc/html/id3.html )
4. select a track to rip
5. click "rip"
6. fail

Reproduced with this book:
DISCID=82106109
DTITLE=Jim Collins / How the Mighty Fall [Disc 1]
DYEAR=2009
DGENRE=Book
TTITLE0=HarperAudio presents...
TTITLE1=Preface
TTITLE2=The Silent Creep
TTITLE3=On the Cusp...
TTITLE4=Five Stages of Discipline
TTITLE5=Success Comparison Set
TTITLE6=First let me give you...
TTITLE7=It's not all gloom...
TTITLE8=Stage One
EXTD=
EXTT0=
EXTT1=
EXTT2=
EXTT3=
EXTT4=
EXTT5=
EXTT6=
EXTT7=
EXTT8=
PLAYORDER=
Comment 3 RobMo 2010-01-11 07:37:41 UTC
Circumventions (use one or both)
Circumvention 1:
kaudiocreator / settings / encoder / mp3 / configure / command line:
remove "--tg %{genre}" from the command line

Circumvention 2:
kaudiocreator / settings / encoder / mp3 / configure / command line:
change
"lame --preset standard"
to
"lame --ignore-tag-errors --preset standard"

If --ignore-tag-errors is used, it must appear before the --tg option.
For example 
Valid: --ignore-tag-errors --tg %{genre}
NOT Valid: --tg %{genre} --ignore-tag-errors
Comment 4 Andrew Crouthamel 2018-11-02 23:06:38 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Andrew Crouthamel 2018-11-16 05:36:28 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version?

Thank you for helping us make KDE software even better for everyone!
Comment 6 Justin Zobel 2022-12-13 02:53:24 UTC
Thank you for reporting this issue in KDE software. As it was reported on an older version, can we please ask you to see if you cazn reproduce the issue with a more recent software version?  
  
If you can confirm this issue still exists in a recent version, please change the version field and the status to "REPORTED" when replying. Thank you!
Comment 7 Bug Janitor Service 2022-12-28 05:23:24 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 8 Bug Janitor Service 2023-01-12 05:16:23 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!