Version: (using KDE KDE 3.5.8) Installed from: Ubuntu Packages If you edit a comment but then undo the changes, digiKam still brings up a dialog box asking you if you want to apply your changes. It could be smarter and check to see if there are any changes. If the "edited" comment is the same as it was before, don't bother with the dialog box. The same thing could be done with tags. Very trivial change, but would save some time. Reproduction: (1)Select a picture and focus on the comment field. (2)Type a character and then backspace. (3)Select a different picture. OR (1)Select a picture and check a tag in the Comment/Tag pane. (2)Uncheck the same tag. (3)Select a different picture.
Andi, Marcel, I think this file is solved now. I cannot reproduce it. Right ? Gilles Caulier
No, I can confirm this for 0.9.5 and 0.10 Andi
When you assign a tag for example and remove it again, the confirm dialog still appears. Andi
I just took a look at this code. Wouldn't it be better to let MetadataHub implement a a global "hasChanged" method instead of using the modified flag, that always has to be managed additionally to what MetadataHub already does? But I don't understand all the details of what's going on there...
Yes it's a bit complex and yes you are probably right but it's not very easy to implement as you suggest (need to keep a copy of initial state)
Alex, it still valid using digiKam 2.x serie ? Gilles Caulier
yes still valid (last seen in 2.5.0)
still valid for 2.6.0 (ppa)
still valid for 2.8.0 (ppa). A few side not: - can also apply to rating or any other non-free text field - normaly the initial state is either in the database, either file or both depending on user settings (which could change in time ...) - if there is no visual evidence of the state (full screen mode, side-panel visible, ... - could change with Bug 221142 - Show as overlay some editable exif information on the images with preview canvas), there should be a message (by progress manager ?) to say: "not modified, field 'xxx' unchanged"
This file still valid using digiKam 3.5.0 ? Gilles Caulier
Presumably. It's still there on 3.4.0, which is the latest I have installed.
Git commit d90dcdf2b3cff736176c723246a3522d1e2b1613 by Gilles Caulier. Committed on 13/09/2014 at 06:32. Pushed by cgilles into branch 'master'. If edited and previous strings are empty, do nothing. FIXED-IN: 4.4.0 M +7 -0 libkexiv2/altlangstredit.cpp http://commits.kde.org/libkexiv2/d90dcdf2b3cff736176c723246a3522d1e2b1613
Git commit 1af638424c3bc55e5ceac5f4ac6f48ee47f407a7 by Pino Toscano, on behalf of Gilles Caulier. Committed on 13/09/2014 at 06:32. Pushed by pino into branch 'KDE/4.14'. If edited and previous strings are empty, do nothing. FIXED-IN: 4.12.2 (cherry picked from commit d90dcdf2b3cff736176c723246a3522d1e2b1613) M +7 -0 libkexiv2/altlangstredit.cpp http://commits.kde.org/libkexiv2/1af638424c3bc55e5ceac5f4ac6f48ee47f407a7
With commit form comment #13, patch is backported to KDE 4.12.2 Gilles Caulier