Bug 119963 - Bug & wishlist: Time Calculator > Julian Day
Summary: Bug & wishlist: Time Calculator > Julian Day
Status: RESOLVED NOT A BUG
Alias: None
Product: kstars
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kstars
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-12 10:51 UTC by Shriramana Sharma
Modified: 2008-04-11 01:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Suggested layout for KStars Julian Date Calculator (5.50 KB, image/png)
2006-01-12 10:52 UTC, Shriramana Sharma
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Shriramana Sharma 2006-01-12 10:51:42 UTC
Version:           1.2.0 (using KDE 3.5.0 Level "a" , SUSE 10.0 UNSUPPORTED)
Compiler:          Target: i586-suse-linux
OS:                Linux (i686) release 2.6.13-15-smp

First the wishlist:
-------------------

Since all three fields of JD, MJD and UT are potential input fields for Julian Day related calculations, it would be more intuitive to push the Convert and Clear buttons to the bottom of the Window instead of somewhere in the middle.

Ideally, the Convert and Clear buttons are to be situated between the input and output groups, but here such a division is not possible. Hence it should be situated at the bottom, since that is where usually the execution buttons of a dialog box are situated.

Also, when "Now" is entered, all three fields JD, MJD and UT should automatically be calculated. Usually a person uses the "Now" option in such calculators to get immediate results. So don't make the user hit "Convert" separately. So I also suggest pushing the "Now" button outside the UT frame, and along with the Convert / Clear buttons.

See the attachment for the suggested layout.

Now the bugs:
-------------
Increase the width of the date field:
As is visible from the attachment, the entire date is not readable. A related bug is Bug 71434 where also I will add a note.

Manual entry to the year field is not possible:
Try entering 1991 to the year field. It is not possible. Only the last digit is appended to "200" and displayed, as "2001" "2009" "2009" "2001". I have to use the arrow keys to spin through to the desired year. Bug 56352 says dates till +/- 50000 are taken, but this does not appear to be reflected.

UT field takes local time:
The UT field is filled with the local time upon pressing "Now", but I have filed that as bug 119960 since it applies to the entire KStars Calculator.
Comment 1 Shriramana Sharma 2006-01-12 10:52:32 UTC
Created attachment 14224 [details]
Suggested layout for KStars Julian Date Calculator
Comment 2 Thiago Macieira 2006-01-12 13:42:13 UTC
For future reference: please submit one wishlist or bug only per report.
Comment 3 kstars 2006-01-21 02:22:55 UTC
SVN commit 500721 by harris:

Fixing bug 119960; partial fix of 119963

11960: All time fields in the astrocalculator now show the 
current UT, not local time

119963: modified the layout of the JD module, moved 
Convert/Clear to the bottom
Increased minimum width of date fields

TODO: 
move Now button (still considering it)
update all 3 fields when Now is pressed
Fix manual input in Date line edit

Thanks for the report.  Will port to trunk as well.

BUG: 119960
CCBUG: 119963



 M  +7 -7      kstarsdata.cpp  
 M  +5 -1      tools/modcalcapcoord.cpp  
 M  +4 -1      tools/modcalcazel.cpp  
 M  +7 -5      tools/modcalcdaylengthdlg.ui  
 M  +6 -1      tools/modcalcjd.cpp  
 M  +133 -120  tools/modcalcjddlg.ui  
 M  +2 -1      tools/modcalcplanets.cpp  
 M  +7 -5      tools/modcalcplanetsdlg.ui  
 M  +4 -1      tools/modcalcvlsr.cpp  
Comment 4 kstars 2006-01-21 17:02:24 UTC
SVN commit 500928 by harris:

Partial fix of bug #119963
It is now possible to manually enter a year in a date edit box

CCBUG: 119963


 M  +15 -0     extdatetimeedit.cpp  


--- branches/KDE/3.5/kdeedu/libkdeedu/extdate/extdatetimeedit.cpp #500927:500928
@@ -1365,6 +1365,17 @@
     d->typing = TRUE;
     QString txt;
     if ( sec == d->yearSection ) {
+      if ( d->overwrite ) {
+	d->y = num;
+	d->overwrite = FALSE;
+	accepted = TRUE;
+      } else {
+	txt = QString::number( 10*d->y + num );
+	if ( txt.length() > 5 ) txt = txt.mid(1);
+	d->y = txt.toInt();
+	accepted = TRUE;
+      }
+/*
 	txt = QString::number( d->y );
 	if ( d->overwrite || txt.length() == 4 ) {
 	    accepted = TRUE;
@@ -1392,6 +1403,7 @@
 		overwrite = TRUE;
 	    }
 	}
+*/
     } else if ( sec == d->monthSection ) {
 	txt = QString::number( d->m );
 	if ( d->overwrite || txt.length() == 2 ) {
@@ -1492,6 +1504,7 @@
   
   int currentYear = ExtDate::currentDate().year();
   int year = d->y;
+/* No longer valid for extended dates
   if ( year < 100 ) {
     int currentCentury = currentYear / 100;
     year += currentCentury * 100;
@@ -1508,6 +1521,7 @@
     year += currentMillennium * 10;
     changed = TRUE;
   }
+*/
   if ( changed && outOfRange( year, d->m, d->d ) ) {
   	if ( minValue().isValid() && date() < minValue() ) {
 	    d->d =  minValue().day();
@@ -1539,6 +1553,7 @@
 {
   if( e->type() == QEvent::FocusOut ) {
     d->typing = FALSE;
+    d->overwrite = TRUE;
     // the following can't be done in fix() because fix() called
     // from all over the place and it will break the old behaviour
     if ( !ExtDate::isValid( d->y, d->m, d->d ) ) {
Comment 5 kstars 2006-01-21 17:03:23 UTC
SVN commit 500929 by harris:

Final fix for bug #119963
Moved the Now button
The Now button now fills in all three fields (JD, MJD and date)

BUG: 119963


 M  +1 -0      modcalcjd.cpp  
 M  +135 -177  modcalcjddlg.ui  
Comment 6 Shriramana Sharma 2006-02-21 07:29:31 UTC
Have downloaded and installed KDE 3.51 -- I observe the fixes. Very nice -- but I expected Compute to be at the left and Now to the right -- that is how I have suggested in the attachment to this bug.

Otherwise the new user searches for the Compute button. (I myself did after installed KDE 3.51.) Since we all read left-to-right, we expect first things at the left, and compute at the left.

So please move the Compute button to the left. Thank you.
Comment 7 kstars 2006-02-22 16:28:03 UTC
should have closed the bug earlier
Comment 8 kstars 2006-02-23 19:46:22 UTC
Sorry for closing prematurely; this is what happens when you (a) add several requests in one bug report, and (b) reopen the bug with a new request.  

In the future, please open a bug for each requested change.  I realize that the change requested which reopens this bug is a direct result of my changes which closed the bug, but it's really much easier for us to keep track of the issues when each bug report is a single, self-contained issue.

Thanks for your continued feedback!
Comment 9 kstars 2008-04-11 01:16:46 UTC
Closing the bug, as the Calculator moduls have been redesigned...they no longer have Compute/Clear buttons.