Bug 119677 - kmail line wraps inserted file
Summary: kmail line wraps inserted file
Status: CONFIRMED
Alias: None
Product: kmail2
Classification: Applications
Component: composer (show other bugs)
Version: unspecified
Platform: Mandriva RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 176833 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-01-07 11:45 UTC by Andrey Borzenkov
Modified: 2012-08-20 23:31 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Borzenkov 2006-01-07 11:45:07 UTC
Version:            (using KDE KDE 3.5.0)
Installed from:    Mandriva RPMs
OS:                Linux

kmail should nod line wrap contents of file inserted using File->Insert file menu. As opposed to manual text entry, this should be assumed preformatted. Current behavior breaks e.g. adding inline patches that are broken by it.

Compare this with e.g. Evolution that retains line structure of inserted file.
Comment 1 Mike Frysinger 2008-03-01 21:17:06 UTC
sometimes when you insert a file, you *want* it line wrapped ... so the behavior cant be completely one or the other

for inserting patches inline, i just turn off line wrapping for the whole e-mail (after manually wrapping the lines with the assistance of auto-line wrapping)
Comment 2 Arkadiusz Miskiewicz 2008-12-11 01:08:19 UTC
The problem is that even if you do:

- disable wordwrap in options menu
- include file

then the result will still be wordwrapped (just a bit differently than when wordwrap is enabled in options)
Comment 3 Mike Frysinger 2008-12-11 01:16:05 UTC
ive never seen that behavior.  disabling word wrap and then inserting a file has always worked as expected: the file is not word wrapped.  ive used kde-3.5 and now kde-4.1 without any issues ...
Comment 4 Andrey Borzenkov 2009-01-07 08:57:58 UTC
it would still be nice to have check box "preformatted" on insert file dialogue and corresponding global option. It is still a bit too much mouse movements to disable word wrap before adding a patch (when you need to add it often) and it is easily forgotten to enable it again.
Comment 5 Jonathan Thomas 2009-12-22 03:52:09 UTC
*** Bug 176833 has been marked as a duplicate of this bug. ***
Comment 6 Sérgio Durigan Júnior 2010-04-18 23:56:04 UTC
Hi,

I would like to know what's the current status of this bug.  I completely agree with Andrey here, and I think that Kmail should provide an option and let the user decide whether (s)he wants to wrap the inserted file or not.  Also, I'm not happy with the solution provided by Mike, although I constantly use it.  Is it so hard to include an option which deals with wrapping specifically on inserted files?
Comment 7 Sérgio Durigan Júnior 2010-04-23 00:40:23 UTC
For the record, the *only* way to insert files without line-wrapping them is to permanently disable the word wrap option.  If you disable it, insert a file, and then enable it again, the file gets line-wrapped.

Since nobody has commented on this bug for a long time, I will take a look at the code and see if I can fix it.  I'd appreciate if you could give me some directions, however.  Thanks.
Comment 8 Myriam Schweingruber 2012-08-18 08:54:24 UTC
Thank you for your feature request. Kmail1 is currently unmaintained so we are closing all wishes. Please feel free to reopen a feature request for Kmail2 if it has not already been implemented.
Thank you for your understanding.
Comment 9 Luigi Toscano 2012-08-19 00:37:25 UTC
Instead of creating a new feature request, please confirm here if the wishlist is still valid for kmail2.
Comment 10 Mike Frysinger 2012-08-19 00:57:10 UTC
(In reply to comment #7)

that's not the behavior i see -- toggling line wrap will not corrupt the inserted content

(In reply to comment #9)

this part of the composer hasn't changed afaict, so the request is still valid