Bug 103025 - [Patch] Middle-click on a tab to close it would be very useful
Summary: [Patch] Middle-click on a tab to close it would be very useful
Status: ASSIGNED
Alias: None
Product: akregator
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Stefan Borggraefe
URL:
Keywords:
: 143023 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-04-01 20:47 UTC by Robert Persson
Modified: 2021-03-09 04:11 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Makes Akregator to behave more like Konqueror with respect to tabs (6.57 KB, patch)
2010-02-25 02:17 UTC, Stefan Borggraefe
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Persson 2005-04-01 20:47:12 UTC
Version:            (using KDE KDE 3.4.0)
Installed from:    Gentoo Packages
OS:                Linux

Middle-clicking on a tab to close it is a feature I use all the time in Opera 7.5x and it is something I very much miss when I am viewing pages in Akregator. I think it would be a very useful feature.
Comment 1 Martin Zbořil 2005-07-15 23:04:44 UTC
and what about double click (since sw patents were canceled)?
Comment 2 Stefan Borggraefe 2005-08-24 01:59:10 UTC
Konqueror now has the option

MouseMiddleClickClosesTab=true

for this. 
Comment 3 Maksim Orlovich 2005-08-24 16:25:51 UTC

*** This bug has been marked as a duplicate of 101473 ***
Comment 4 Stefan Borggraefe 2005-08-24 18:50:38 UTC
I don't think this is a dupe. The mentioned option only affects konqueror, not akregator. I think this bug should be reopened (I don't have the bugzilla permission to do so).
Comment 5 Maksim Orlovich 2005-08-24 18:51:43 UTC
doh, sorry.
Comment 6 Teemu Rytilahti 2006-03-29 03:26:10 UTC
Maybe we should just check if this is set in konquerorrc and make tabwidget behave like konqueror?
Comment 7 Henrik Pauli 2006-04-11 21:44:02 UTC
I'm glad to see this bug; it's not related to Konqueror and it's even relatively fresh!

I'm unfortunately not a coder, so I can only chime in with words: please make it global.  Optional, if you wish (I see many people in the *nix world like the middle-click paste), but please make it possible to close any tabs (that one opens himself and aren't part of the GUI, like, say kcontrol's tabs) with a middle-click.

I doubt anyone wants to click on a kopete or a konsole tab to paste anything -- they'd more likely switch tabs and throw in the clipboard data while they can see where they put it.
Comment 8 Aaron Peterson 2006-07-10 09:08:51 UTC
I'm using kde 3.5.3 and it's really nice not having middle clicks open wierd URLS... (I found the option in configure Konqueror)  but it still opens wierd URLS when I middle click on a tab.

It would be great to see this option represented in the configure konqueror options

Thanks...
and for the time being where do I put:
MouseMiddleClickClosesTab=true
?
Comment 9 Aaron Peterson 2006-07-10 09:09:25 UTC
*** This bug has been confirmed by popular vote. ***
Comment 10 Bram Schoenmakers 2007-03-15 21:54:27 UTC
*** Bug 143023 has been marked as a duplicate of this bug. ***
Comment 11 Ondřej Michálek 2007-04-02 14:44:27 UTC
totally agree with #7 from Henrik Pauli  
Comment 12 Piotr Pełzowski 2007-10-06 22:51:16 UTC
btw. typing in terminal "kwriteconfig --file konquerorrc --group "FMSettings" --key MouseMiddleClickClosesTab --type bool true" will give you middle-click on a tab to close in Konqueror. Maybe the same way could by used for Akregator. :)

also I totally agree with #7
Comment 13 oneeyedelf1 2008-11-16 21:19:48 UTC
I would also find this option very useful. I also second other people's wishes that middle click to close tabs should become global. But currently the largest pain that I can't use this option on is akregator.
Comment 14 Stefan Borggraefe 2010-02-25 02:17:51 UTC
Created attachment 41084 [details]
Makes Akregator to behave more like Konqueror with respect to tabs

This patch adds a new option for "Middle-click on a tab to close it" and imports the current tabbed browsing settings from Konqueror as defaults for Akregator.

This is one of my first KDE patches, so please be gentle. ;-)
Comment 15 Stefan Borggraefe 2010-02-25 02:38:18 UTC
I don't think the middle-click behaviour should be a global option. In apps where you often paste text with the middle-mouse-button like in Konsole or in Kate you probably want a different behaviour than in viewers like Konqueror or Akregator. 

But I think it makes sense for Akregator to look up if and how the user has configured Konqueror and to reuse these settings since both programs are used very similar when web pages are viewed.

Akregator already reuses Konqueror's font settings as well.
Comment 16 Henrik Pauli 2010-02-25 02:49:32 UTC
(In reply to comment #15)
> I don't think the middle-click behaviour should be a global option. In apps
> where you often paste text with the middle-mouse-button like in Konsole or in
> Kate you probably want a different behaviour than in viewers like Konqueror or
> Akregator. 

That’s a good point, though I’ve never pasted anything on a tab (especially not an inactive one) — I like to see where I paste, so all my middle-clicks go onto the text field (or KonsolePart, as it may be), rather than some parent widget.  But maybe I’m quirky :)
Comment 17 Dotan Cohen 2010-02-25 14:14:44 UTC
> I don't think the middle-click behaviour should be a global option. In apps
> where you often paste text with the middle-mouse-button like in Konsole or in
> Kate you probably want a different behaviour than in viewers like Konqueror or
> Akregator. 

Test is pasted in the window, not on the tab.

Of course tabs should behave the same in all applications. If I happen to have some dangerous command in the clipboard and I middle-click a Konsole tab with the intention of closing it, I will be very upset if it pastes.
Comment 18 Stefan Borggraefe 2010-02-25 22:21:08 UTC
(In reply to comment #17)
> Test is pasted in the window, not on the tab.

Yes, I know this. I am more worried about accidentally closing a document or a Konsole session when such programs would feature middle-click to close a tab. Imagine you want to paste something into a document and click on the tab by mistake.

Anyways, my patch fixes this bug and tries to be a little clever to determine to default configuration.

If this should become a global option, this bug should probably be resolved as INVALID and a new bug about a global option should be filed.

I think it would be nice if Akregator could be used the same way as other tabbed browsers for now.
Comment 19 Justin Zobel 2021-03-09 04:11:14 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.