Version: CVS (March 30, 2005) (using KDE KDE 3.4.0) Installed from: Slackware Packages OS: Linux Outgoing messages in ICQ have line breaks replaced with <br />. Incoming line breaks are not displayed. Tested with ICQ & MSN. Possibly related to old bug 59878.
do you have a debug log?
Not currently compiled with --enable-debug :( Is it really necessary? Or did you want a tcpdump? I just found out about bug 102383 and bug 102333. It seems sending msgs over icq do not need to be html'ized, while incoming (still) does. Meaning 102333 still isn't fixed. (Just tested now with a friend).
ok, so there are really two problems here, is that correct? The first problem being that we send icq messages html'ized and the second one being that we don't properly convert icq messages to html for display in the chat window?
Created attachment 10492 [details] ICQ message receive - html extra step Correct -- 2 problems. Or rather, the last patch I saw commited to cvs patched the wrong one. For myself, I've reverted the last patch in /protocols/oscar/oscarcontact.cpp, and added this attachment. Note that I've only changed type 1 messages. Works as a nice temp patch for me.
*** Bug 101103 has been marked as a duplicate of this bug. ***
the patch is technically correct, but it's in the wrong place, and i don't want liboscar depending on kopete stuff more than it already does. escaping should be done in the kopete frontends to liboscar (*Account and *Contact)
*** Bug 103564 has been marked as a duplicate of this bug. ***
*** Bug 103765 has been marked as a duplicate of this bug. ***
*** Bug 103865 has been marked as a duplicate of this bug. ***
Just a suggestion: Can we revert slotSendMsg in /protocols/oscar/oscarcontact.cpp back to when it was working properly? Already people are incorrectly patching the breakage. That way we can close this bug and reopen bug 102383 until a proper fix is out.
Looks good as far as I can tell. Thx!
Not fixed in 3_4 branch. AFAICS revision 408739 needs to be backported :-) I asked in #kopete and I hope it is okay that I reopened this bug. And should bug 102383 be reopened (the commit was reverted, wasn't it?)
Yeah, not sure what's up with the branches, but I just got KDE 3.4.1 ... not fixed. Am I doomed to compile cvs forevermore?
should be fixed in trunk. (code for send message doesn't send escapedBody anymore. code for receive message uses Kopete::Message::escape similar to patch in this bug report)
*** Bug 108163 has been marked as a duplicate of this bug. ***