| Summary: | Konqueror formats pages too wide for the screen | ||
|---|---|---|---|
| Product: | [Applications] konqueror | Reporter: | cb-kde |
| Component: | khtml | Assignee: | Dirk Mueller <mueller> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aarjona, alan, bko, bugzilla, codreadrian, david, davidpjames, dusan, geoff, grail, gregorgraph, jan, kde, kde, kdebugs, klk206, kloecker, l, Mathias.Homann, metrol, mss, N.Poli, ndeb, nturner-kde, patrick, plasmoid, r, rdieter, soloturn99, the.rhorn, thomas.herberg, thomas_bevan, weillerronfini |
| Priority: | NOR | ||
| Version: | 3.2.1 | ||
| Target Milestone: | --- | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Demonstrates the bug | ||
|
Description
cb-kde
2003-07-27 19:15:47 UTC
I meant to say that (as far as I remeber) this is a regression which has occured on KDE_3_1_BRANCH in the last month or so. *** Bug 61841 has been marked as a duplicate of this bug. *** *** Bug 61872 has been marked as a duplicate of this bug. *** render_root.cpp 1.116.2.3 broke it. *** Bug 61854 has been marked as a duplicate of this bug. *** I can confirm that reverting render_root.cpp to 1.116.2.2 works here. Yes reverting that patch does work, but what does it break that the patch intended to fix? > what does it break that the patch intended to fix? http://bugs.kde.org/show_bug.cgi?id=54673 *** Bug 61931 has been marked as a duplicate of this bug. *** *** Bug 61937 has been marked as a duplicate of this bug. *** this bug is evident when looking at http://www-es.fernuni-hagen.de/doc/cyrus-imapd2/overview.html#sieve This bug is evident when looking at THIS page. It'd be nothing more than a minor annoyance except for the fact that it actually messes up text layout in many instances. I recently submitted what turned out to be a dupe of this bug which I believe describes the problem better than what is mentioned here. FWIW: http://bugs.kde.org/show_bug.cgi?id=61937 The bug is not only evident in Konquerer, it's an annoyance in KDE Help Center too. I find it more than a minor annoyance when the page being rendered has small or no vertical margins, as is the case with the included KDE docs. A single line of text might not fit the displayed area. *** Bug 62002 has been marked as a duplicate of this bug. *** Ugly, http://lwn.net/ too. Some letters are not shown with tables of 100% width. Might I suggest testing before releases? An obviously visible flaw that shows up in the web browser, file manager, and mail client (and wherever else) should have been caught if KDE 3.1.3 were actually tested. Subject: KDE_3_1_BRANCH: kdelibs/khtml/rendering CVS commit by mueller: grr, automatic backporting patch made it automatically wrong :( CCMAIL: 61730-done@bugs.kde.org M +2 -2 render_root.cpp 1.116.2.4 --- kdelibs/khtml/rendering/render_root.cpp #1.116.2.3:1.116.2.4 @@ -119,5 +119,5 @@ void RenderRoot::layout() if (!m_printingMode) { QSize s = m_view->viewportSize(m_view->contentsWidth(), - 0); + m_view->contentsHeight()); m_width = s.width(); m_height = s.height(); @@ -133,5 +133,5 @@ void RenderRoot::layout() m_view->resizeContents(docWidth(), docHeight()); QSize s = m_view->viewportSize(m_view->contentsWidth(), - m_view->contentsHeight()); + 0); setWidth( m_viewportWidth = s.width() ); setHeight( m_viewportHeight = s.height() ); I just slapped that patch into my FreeBSD port and rebuilt kdelibs. Looks like that solved the problem with the HTML rendering. The test cases on this bug also look good to go. It looks like these are back and up running as a problem though: http://bugs.kde.org/show_bug.cgi?id=54673 http://bugs.kde.org/show_bug.cgi?id=53705 For the moment I'd personally rather have the rest of teh 99.99% of the web rendering properly. Even still, either this bug or one of those others should remain open until both are working properly at the same time. *** Bug 62104 has been marked as a duplicate of this bug. *** *** Bug 62158 has been marked as a duplicate of this bug. *** *** Bug 62164 has been marked as a duplicate of this bug. *** With Dirk's patch applied I ran into another oddball kinda page here that is showing up with a confused horizontal scrollbar. http://www.faqs.org/faqs/x-faq/speedups/ No readability problems, just that Konqueror thinks there's a whole other half of this page off to the right. Reality checked this against Mozilla. It ain't the page. Maybe something to do with PRE tags? Additionally, man pages being displayed in Konqueror still always have a horizontal scrollbar regardless of need. Example: man:/ls Although the patch makes the situation unquestionably better, I am of the opinion that this bug should be re-opened. There are still layout issues at play that have not been resolved involving that darn scrollbar. unfortunately this bug touches everything I use - konqueror, kmail, kopete etc.... will it be there a 3.1.4 or similar or should i compile kdelibs by myself to get rid of it? cheers Subject: Re: Konqueror formats pages too wide for the screen
On Tuesday 05 August 2003 05:11 pm, you wrote:
>
> ------- Additional Comments From Plamen.Neykov@t-online.de 2003-08-05
> 23:11 ------- unfortunately this bug touches everything I use - konqueror,
> kmail, kopete etc....
> will it be there a 3.1.4 or similar or should i compile kdelibs by myself
> to get rid of it?
>
I believe there is a 3.1.3a coming shortly to correct the problem. In the
meantime, I have 'downgraded' myself to 3.1.2.
Subject: Re: Konqueror formats pages too wide for the screen On Tue, 5 Aug 2003, Todd Stephens wrote: > I believe there is a 3.1.3a coming shortly to correct the problem. In the > meantime, I have 'downgraded' myself to 3.1.2. But kde-3.1.3 is supposed to fix a security hole. See http://www.kde.org/info/security/advisory-20030729-1.txt . Subject: Re: Konqueror formats pages too wide for the screen
On Tuesday 05 August 2003 05:37 pm, you wrote:
> But kde-3.1.3 is supposed to fix a security hole. See
> http://www.kde.org/info/security/advisory-20030729-1.txt .
Yes, but it is not an altogether likely situation for me.
Subject: Re: Konqueror formats pages too wide for the screen El Martes, 5 de Agosto de 2003 23:37, ndeb@ece.cmu.edu escribi Subject: Re: Konqueror formats pages too wide for the screen
On Tuesday 05 August 2003 05:57 pm, you wrote:
> It's a bug in konqueror. Try downgrading only kdelibs, but may be tricky
> because of broken dependencies.
I downgraded only kdelibs and kdebase. I noticed also (and this may have been
an issue strictly with the Slackware binary packages for KDE) but 3.1.3 did
not include the kdeprint_cups libraries. I discovered this at a very
unfortunate time while trying to print a report for someone. I had to reboot
into Windows just to print.
*** Bug 62234 has been marked as a duplicate of this bug. *** *** Bug 62273 has been marked as a duplicate of this bug. *** *** Bug 62323 has been marked as a duplicate of this bug. *** *** Bug 62412 has been marked as a duplicate of this bug. *** > I believe there is a 3.1.3a coming shortly to correct the problem.
how soon is 'shortly'?
*** Bug 62469 has been marked as a duplicate of this bug. *** *** Bug 62498 has been marked as a duplicate of this bug. *** *** Bug 62570 has been marked as a duplicate of this bug. *** *** Bug 62609 has been marked as a duplicate of this bug. *** *** Bug 62637 has been marked as a duplicate of this bug. *** Glad this was fixed, it was really annoying, but the update was still worth it for the rest of the stuff. I wish that this dupell (dupe hell) would stop too, I mean the bug is fixed. *** Bug 62759 has been marked as a duplicate of this bug. *** *** Bug 62838 has been marked as a duplicate of this bug. *** *** Bug 63267 has been marked as a duplicate of this bug. *** *** Bug 63303 has been marked as a duplicate of this bug. *** *** Bug 63667 has been marked as a duplicate of this bug. *** *** Bug 63975 has been marked as a duplicate of this bug. *** *** Bug 64401 has been marked as a duplicate of this bug. *** Upgrading from 3.2.1 to 3.2.2 made this bug appear again for me, e.g. on http://bugs.kde.org/ I use 1280x960 as resolution. more details: - Open a new tab - type bugs.kde.org + ENTER -> page is "formatted too wide" (I have a horizontal scrollbar) - click in the urlbar, press ENTER -> bugs.kde.org gets reloaded, and gets formatted normally (no more horizontal scrollbar) Confirmed. (Using the official Debian Unstable packages.) does not happen with the kde 3.2.2 packages that just came in via apt4rpm for suse 9.0... I'll reopen this one. Can't reproduce this one anymore either. While those pages are loaded, they are first shown with the horizontal scrollbar but as soon as loading is finished, they look good. This is Gentoo with a fairly recent build of the KDE_3_2_BRANCH. As mentionned in comment 49 you have to open a page in a new tab (background or foreground, it doesn't matter). If loaded in the current tab the scrollbar does indeed disappear when finished loading. I can't pin this down for sure but it seems to occur on pages with tables. My own <div>s-only pages don't show this bug. Neither do http://www.mozilla.org's pages, where only divs are used whereas bugzilla pages both here and there show it since they use tables. Other than reloading, one can also dismiss the scrollbar by opening/closing the Navigation Panel or any other action that causes the viewport to be resized. Finally, I also noticed that this is occurring in KMail as well at times, particularly when selecting a new folder, but it doesn't do it consistently - just enough to be annoying. Right, now I can reproduce it again, too. I can reproduce this still in 3.2.2. It gets even weirder: 1. Open http://www.lorentzpumps.com/ in a new tab, you'll get that dreaded scrollbar. 2. Now move your mouse pointer over the blue bar, a menu will pop up and suddenly the whole page shifts left and everything's fine. *** Bug 81139 has been marked as a duplicate of this bug. *** Created attachment 5918 [details] Demonstrates the bug I'll repeat what I said in Bug 81139: > I have noticed that the horizontal scrollbar will often appear even when not needed. This usually > happens with the vertical scrollbar also appears. I'm betting that the vertical scrollbar is > screwing up the horizontal size calculation. I will include a file where this happens. Note, > however, that the horizontal scrollbar disappears after a refresh. And: > It's ridiculously long to make sure the bug shows itself. > > Make sure to open the file in a separate tab or window or the bug won't show. I continue to experience this bug in HEAD. Notice the problem consistently in kmail and with any number of websites. As noted, a refresh or resize of the frame fixes the problem and the page width scales properly. Eerily reminds me of the Netscape4 resize bug that required a piece of JS to refresh the entire page. In any case, my vote is cast as I've been bitten by this a few times today with 3.3_alpha1. Here's the basics my speculation of what's happening with this bug: Essentially, the layout of the page is calculated first for a view without a vertical scrollbar, and then after that, the page's width is calculated, but then the vertical scrollbar is decreasing the viewing width of the page. With 3.3_alpha1 I no longer see this bug anywhere. Possibly needs some more testing, but all the sites that didnt resize properly now resize, including http://lwn.net/ ... So please try 3.3_aplha1 and see if it helps. For those that experience this with 3.3_alpha1, please provide links. Contrary to #63, I still experience this with lwn.net Here's a few other examples where the bug is still present in 3.3_alpha1 http://www.steelers.com/ http://gooeylinux.org/index.php Also the example posted in #59 As mentioned above, open each link in it's own window/tab for the bug to be present.... Well, useability isnt affected, but the horrizontal scroll bar appears. It does however also appear in firefox for http://gooeylinux.org/index.php -- so that example isnt really KDE's fault. This also seems to affect Kopete in the message window. When enough messages have been sent that a vertical scroll bar is required, a horizontal one is also created. Resizing the window gets rid of the horizontal scroll bar. Same here, in KMail and Konqueror of 3.2.3 and also CVS HEAD as of yesterday (jun 30). Still there in 3.3_beta2 as of July, 20. Shows up in KMail and on many sites, e.g. www.kde.nl. Be sure to open them in a new window or tab. Sometimes hovering over some elements causes a redraw and then the horizontal scrollbar disappears. Addition to #68, when opening http://www.kde.nl/ for the first time the horizontal scrollbar appears, but hovering over the left sidebar causes a redraw, after which the horizontal scrollbar disappears. The li:hover used in the KDE.NL left sidebar stylesheet only changes the colors of background and border! Apparently, this is enough to cause a redraw. (I voted for this annoying buglet, it is esp. annoying when reading texts and not seeing the last character of some lines, and because it shows up everywhere, in Kopete, KMail, etc. :-) For me it happens at most (all?) sites. Redraw can be forced by e.g. resizing the window, CVS HEAD today. *** Bug 85722 has been marked as a duplicate of this bug. *** I have this bug-behavior too, as HEAD cvs-23072004 (earlier cvs versions also affected). As testcase I just load "about:", and konqueror show horizontal scrollbar. Pressing F5 (refresh) hides scrollbar. CVS commit by ggarand:
scope: main view scrollbars.
* khtmlview.cpp (resizeEvent): take care, in case we are shrinking,
not to pass past the content limits yet. Next layout will determine
if we positively need scrollbars or not.
* rendering/render_canvas.cpp (layout): remove scrollbar flickering turnarounds.
Instead, account for a computed scrollbar hysteresis level when sizing the content.
CCMAIL: 84798-done@bugs.kde.org, 61730-done@bugs.kde.org
M +9 -0 ChangeLog 1.274
M +10 -0 khtmlview.cpp 1.660
M +32 -29 rendering/render_canvas.cpp 1.150
thanx!!! Is it fixed? YES! Thanks a lot! Great!! what about www.x.org? On Sunday 29 August 2004 09:58 am, Marius wrote:
> what about www.x.org?
Poorly-written CSS. Look at this: style="position: absolute; width: 100%;
height: 100%; z-index: 1; left: 5px; top: -20px;"
100% wide + 5px = 5px wider than the window, no matter what. Oops.
Not Konqueror's fault.
This is IMHO the only way to do it in CSS. Am Sonntag 29 August 2004 16:13 schrieb Nathaniel W.Turner: > > 100% wide + 5px = 5px wider than the window, no matter what. Oops. > > Not Konqueror's fault. Yes, firefox shows the same -> webmaster@x.org is it the fault of the web "designer" on http://www.theregister.co.uk/odds/bofh/ as well? at least on my box its still present on that page... Another page where this occurs: http://www.python.org/moin/ConfigParserShootout#head-c020ab1561c8bfaf6d65edc22a4b328ac6ef5648 Mozilla Firefox renders correctly. This bug is marked as fixed, I have KDE version: 3.4.0 Level "b", and maybe it's been fixed in newer versions, but this page: http://davidszondy.com/future/Flight/GEV.htm is too wide in Konqueror and works just fine in FireFox. |