| Summary: | Right sidebar properties view content with grouped files | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | KaiB <kaizubg> |
| Component: | Albums-ItemsGroup | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles, metzpinguin |
| Priority: | NOR | ||
| Version First Reported In: | 8.9.0 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/digikam/-/commit/245614fb1920996726a0cd59e49e5b64829f1937 | Version Fixed/Implemented In: | 8.9.0 |
| Sentry Crash Report: | |||
| Attachments: | attachment-2628994-0.html | ||
|
Description
KaiB
2025-11-24 12:19:56 UTC
This behavior depends on the settings in the digiKam setup under Miscellaneous -> Grouping. Select "No" for metadata. Note that this also changes the writing behavior for metadata within the group. Maik Created attachment 187147 [details] attachment-2628994-0.html Hi, Great to hear that this feature is implemented. Seems to work after the change in the settings. However, it is very unfortunate that the group metadata storing in to db is lost at the same time. This comes visible in the use case where the user works with file groups (raw&jpg) metadata and wants to view the changes of it. In this case both functions are needed at the same time for optimal usability and ergonony. Personally I would prefer if the Properties view would work like the Metadata view. At least in this use case. I know there are other as well. Please update the online manual according to this as well. ma, 2025-11-24 kello 12:50 +0000, Maik Qualmann kirjoitti: > https://bugs.kde.org/show_bug.cgi?id=512555 > > Maik Qualmann <metzpinguin@gmail.com> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > CC| |metzpinguin@gmail.com > > --- Comment #1 from Maik Qualmann <metzpinguin@gmail.com> --- > This behavior depends on the settings in the digiKam setup under Miscellaneous > -> Grouping. Select "No" for metadata. Note that this also changes the writing > behavior for metadata within the group. > > Maik > Git commit 90407e23a1bd3e3ecc3b2755bcf9a38dc785d58e by Gilles Caulier. Committed on 05/12/2025 at 07:59. Pushed by cgilles into branch 'master'. Image properties : selection mode show number of groups Related: bug 377857 M +9 -1 core/libs/properties/itempropertiessidebardb.cpp M +49 -25 core/libs/properties/itemselectionpropertiestab.cpp M +2 -0 core/libs/properties/itemselectionpropertiestab.h https://invent.kde.org/graphics/digikam/-/commit/90407e23a1bd3e3ecc3b2755bcf9a38dc785d58e Git commit f52c1e919a0ec98c375755c16fdf176af32bb671 by Gilles Caulier. Committed on 05/12/2025 at 13:54. Pushed by cgilles into branch 'master'. First implementation to list grouped items (selected and total) into the right sidebar tab as treeviews Related: bug 377857 M +1 -1 core/libs/properties/CMakeLists.txt M +0 -4 core/libs/properties/itempropertiessidebar.cpp M +0 -2 core/libs/properties/itempropertiessidebar.h M +44 -27 core/libs/properties/itempropertiessidebardb.cpp M +177 -53 core/libs/properties/itemselectionpropertiestab.cpp M +15 -6 core/libs/properties/itemselectionpropertiestab.h https://invent.kde.org/graphics/digikam/-/commit/f52c1e919a0ec98c375755c16fdf176af32bb671 Maik, There is a problem with the ThumbnailLoadThread. The first request for thumbnails to populate in the groups treeview work fine, all other done later fails. To reproduce : select an album with grouped items. Perform a selection in icon view a look the result in the right sidebar. There are few debug statements in the console to help. Best Gilles Maik, Look my screenshot : https://imgur.com/a/ngUmdam Here this work partially, as top level items got the thumbs at the first time. The children never got the thumbs. If i change the selection, ThumbnailLoadThread do not fire a signal. Best Gilles Git commit 5b2942d78fea4a3373b1b9428764d74562aa8efb by Gilles Caulier. Committed on 06/12/2025 at 02:22. Pushed by cgilles into branch 'master'. Image properties selection: fix thumbnails loader working only once. There is certainly a bug in ThumbnailLoadThread::findGroup() which works only once as ThumbnailLoadThread::find() works as expected... M +0 -1 core/libs/properties/itempropertiessidebardb.cpp M +83 -27 core/libs/properties/itemselectionpropertiestab.cpp M +5 -2 core/libs/properties/itemselectionpropertiestab.h https://invent.kde.org/graphics/digikam/-/commit/5b2942d78fea4a3373b1b9428764d74562aa8efb Git commit dec94be72197a616be8318fda6935d3e80ea346c by Gilles Caulier. Committed on 06/12/2025 at 02:48. Pushed by cgilles into branch 'master'. Image properties: show number of grouped items if one iconview item is selected. M +18 -4 core/libs/properties/itempropertiessidebardb.cpp https://invent.kde.org/graphics/digikam/-/commit/dec94be72197a616be8318fda6935d3e80ea346c I somehow didn't send my comment from last night. The behavior of ThumbnailLoadThread::findGroup() seems to be intentional; the signal is only fired once, after it has been loaded. On all subsequent attempts, during the conversion from ThumbnailIdentifier to LoadingDescription, it checks whether the thumbnail is already in the cache. The load request is then discarded. Maik Ok, thanks for the details about the findGroup() behavior... We need an update of the API doc. As we have now a treeview of groups for the current album, perhaps we can add some action with it as to expand/collapse, ungroup, or open in editor. What do you think about ? Gilles Git commit 07c49b101e3429a6a5847b3a6d3b3b38b7a3d7fa by Gilles Caulier. Committed on 06/12/2025 at 08:56. Pushed by cgilles into branch 'master'. fix API doc M +5 -1 core/libs/threadimageio/thumb/thumbnailloadthread.h https://invent.kde.org/graphics/digikam/-/commit/07c49b101e3429a6a5847b3a6d3b3b38b7a3d7fa Git commit e51bf153a54372ae2cc38aaf43b8f43d744e185e by Gilles Caulier. Committed on 06/12/2025 at 16:58. Pushed by cgilles into branch 'master'. Image Properties tab: if one item is selected from the Icon-View and if it's a group of item, show the treeview of the corresponding group in the digiKam properties section Related: bug 377857 M +1 -0 core/libs/properties/CMakeLists.txt A +178 -0 core/libs/properties/groupeditemsview.cpp [License: GPL(v2.0+)] C +6 -15 core/libs/properties/groupeditemsview.h [from: core/libs/properties/itemselectionpropertiestab.h - 057% similarity] M +12 -0 core/libs/properties/itempropertiessidebardb.cpp M +20 -20 core/libs/properties/itempropertiestab.cpp M +1 -0 core/libs/properties/itempropertiestab.h M +1 -0 core/libs/properties/itempropertiestab_p.h M +5 -0 core/libs/properties/itempropertiestab_setters.cpp M +7 -157 core/libs/properties/itemselectionpropertiestab.cpp M +0 -10 core/libs/properties/itemselectionpropertiestab.h https://invent.kde.org/graphics/digikam/-/commit/e51bf153a54372ae2cc38aaf43b8f43d744e185e Git commit 6d4352d6ff51236d2f4851aa72a3d64808fbb9ce by Gilles Caulier. Committed on 07/12/2025 at 15:11. Pushed by cgilles into branch 'master'. Prepare items grouped list view to support tooltips. M +2 -0 core/libs/properties/CMakeLists.txt A +105 -0 core/libs/properties/itemsgroupedtooltip.cpp [License: GPL(v2.0+)] A +50 -0 core/libs/properties/itemsgroupedtooltip.h [License: GPL(v2.0+)] M +19 -36 core/libs/properties/itemsgroupedview.cpp M +0 -4 core/libs/properties/itemsgroupedview.h A +134 -0 core/libs/properties/itemsgroupedviewitem.cpp [License: GPL(v2.0+)] C +20 -12 core/libs/properties/itemsgroupedviewitem.h [from: core/libs/properties/itemsgroupedview.h - 053% similarity] https://invent.kde.org/graphics/digikam/-/commit/6d4352d6ff51236d2f4851aa72a3d64808fbb9ce Git commit 226d80f9c151e69916a2d5b66b7bf1c3d4d05a4f by Gilles Caulier. Committed on 07/12/2025 at 16:44. Pushed by cgilles into branch 'master'. Image properties sidebar tab: add support of tooltip to the items grouped tree view M +120 -5 core/libs/properties/itemsgroupedview.cpp M +13 -0 core/libs/properties/itemsgroupedview.h https://invent.kde.org/graphics/digikam/-/commit/226d80f9c151e69916a2d5b66b7bf1c3d4d05a4f Git commit 0db49d8877e2ffec88e57aceb5e026e803479950 by Gilles Caulier. Committed on 07/12/2025 at 21:10. Pushed by cgilles into branch 'master'. Handle collection item change even for the database about to remove entries from the list of grouped items. M +75 -2 core/libs/properties/itemsgroupedview.cpp M +6 -1 core/libs/properties/itemsgroupedview.h https://invent.kde.org/graphics/digikam/-/commit/0db49d8877e2ffec88e57aceb5e026e803479950 Git commit c8b615130b9597c67763589af8c3a3b79b4bb0ae by Gilles Caulier. Committed on 07/12/2025 at 21:16. Pushed by cgilles into branch 'master'. Do not sort grouped items eg. to list items in arrival order. This corresponding exactly to the icon-view selection order. M +1 -1 core/libs/properties/itemsgroupedview.cpp https://invent.kde.org/graphics/digikam/-/commit/c8b615130b9597c67763589af8c3a3b79b4bb0ae Git commit 9b6a038e2d74b025e5f13bd718a846ce5c387ed0 by Gilles Caulier. Committed on 08/12/2025 at 09:49. Pushed by cgilles into branch 'master'. Image Properties Sidebar : init Grouped Items treeview entries expanded if group are expanded from the icon-view M +1 -0 core/app/views/stack/itemiconview.cpp M +7 -0 core/libs/properties/itempropertiessidebardb.cpp M +3 -0 core/libs/properties/itempropertiessidebardb.h M +15 -9 core/libs/properties/itemselectionpropertiestab.cpp M +4 -0 core/libs/properties/itemselectionpropertiestab.h M +20 -2 core/libs/properties/itemsgroupedview.cpp M +2 -0 core/libs/properties/itemsgroupedview.h M +1 -0 core/utilities/imageeditor/main/imagewindow_setup.cpp M +5 -0 core/utilities/lighttable/lighttablethumbbar.cpp M +1 -0 core/utilities/lighttable/lighttablethumbbar.h M +4 -1 core/utilities/lighttable/lighttablewindow_setup.cpp https://invent.kde.org/graphics/digikam/-/commit/9b6a038e2d74b025e5f13bd718a846ce5c387ed0 Git commit d2ddff700e9b97fe6e2c604d03a8ac7d6a4dd955 by Gilles Caulier. Committed on 08/12/2025 at 10:18. Pushed by cgilles into branch 'master'. Image Properties Sidebar : if group is open from the icon view overlay button, expand the group treeview entry accordingly M +2 -0 core/libs/database/models/itemfiltermodel.cpp M +5 -0 core/libs/database/models/itemfiltermodel.h M +21 -0 core/libs/properties/itemsgroupedview.cpp https://invent.kde.org/graphics/digikam/-/commit/d2ddff700e9b97fe6e2c604d03a8ac7d6a4dd955 Git commit 3d75c6768a430b2a1c6b8464876e0f64b8b978a2 by Gilles Caulier. Committed on 08/12/2025 at 12:00. Pushed by cgilles into branch 'master'. Image Properties Sidebar : if one item from the grouped treeview is expanded/collapsed, expand the group from the icon-view accordingly M +24 -0 core/libs/properties/itemsgroupedview.cpp https://invent.kde.org/graphics/digikam/-/commit/3d75c6768a430b2a1c6b8464876e0f64b8b978a2 Git commit 32efe8c3de924e58dd077edbaffa80e38f5238c8 by Gilles Caulier. Committed on 09/12/2025 at 01:44. Pushed by cgilles into branch 'master'. Image properties sidebar tab: reload contents if image relation as changed eg. image is add or removed from a group M +5 -4 core/libs/properties/itempropertiessidebardb.cpp https://invent.kde.org/graphics/digikam/-/commit/32efe8c3de924e58dd077edbaffa80e38f5238c8 Hi Maik, I seen a strange behavior with the table-view which differ from the icon-view. It's about the open/close groups feature. With my last fix, the image properties tab is able to show the group hierarchies from the current album. One feature is to open/close a group by to expand or not a root branch from a groups tree-view. In the opposite, open/close the group from the icon-view overlay will expand of not the relevant group treeview from the image properties tab. This work fine with icon-view, not table-view. The new GroupedItemView class hosted in the image properties tab uses the ItemFilterModel instance to handle the open/close group events coming from the GUI (in the both directions). So this must not depend of the view implementation, as icon or table. It sounds like a bug in the table-view implementation. Another remark : the open groups states are not propagated when you switch from icon-view to table-view and vice versa. It sound like the model is not shared properly between both GUI. Can you double check on your computer please ? Best regards Gilles Hi Gilles, Yes, I can confirm that the table view doesn't work like the icon view. The table view has always been "special" when it comes to grouping. There's also a context menu entry to ignore grouping altogether. I'll take a look this evening to see if there's a workaround. Maik Thanks Maik to take a look. Other plan about to improve the Items Grouping usability: - Add buttons on the Grouping tree-view from the right sidebar for actions (as remove items from group). Buttons will be visible on mouse move over the tree-view entries. - I'm not satisfy very well by the Grouping tree-view tool-tip. At least the default implementation works, we will adjust it later depending of user feedback. - I would implement an icon-view item highlighting for the group contents when user move the mouse over the grouping tree-view. We will need also the same feature for the table-view i think. Using the ItemFilterModel as gateway will be the most universal to turn on/off highlighting on the view. This kind of feature will help to identify items in group. We have another file in Bugzilla about this topic. - When no item are selected in the icon-view or the table-view, the image properties tab must show the view of the full contents of album (typically the bottom view of the selection properties view currently implemented). We have also on entry in Bugzilla about this topic. Best Gilles Git commit 377215ed713f46e99bd21233d288f25a13b483f8 by Gilles Caulier. Committed on 09/12/2025 at 14:16. Pushed by cgilles into branch 'master'. Image Properties Sidebar tab. If no items are selected from the current album, show all statistics about files, including Grouped items. Related: bug 399220, bug 499108, bug 392936 FIXED-IN: 8.9.0 M +1 -0 core/app/views/stack/itemiconview.cpp M +20 -3 core/libs/properties/itempropertiessidebardb.cpp M +6 -0 core/libs/properties/itempropertiessidebardb.h M +23 -35 core/libs/properties/itemselectionpropertiestab.cpp https://invent.kde.org/graphics/digikam/-/commit/377215ed713f46e99bd21233d288f25a13b483f8 Hi KaiB, I works to improve the Grouped Items usability. The first stage is to show tree-view of grouped items from the right sidebar, even if no item is selected in current album. This look like this: https://imgur.com/xdokewJ https://imgur.com/rpyaXDs https://imgur.com/PpWNToR One feature implemented is to be able to open a group from the icon view by expanding a group on the image properties tree-view. The reverse is also valid. This is the first help to quickly view all group in the current album and to access it. My next stage will be to implement a icon view item highlighter when user move the mouse over the tree-view items. Gilles Caulier Git commit f79f583611c4e4ee5b79b6f8e3972d292a7e2a36 by Maik Qualmann. Committed on 09/12/2025 at 20:40. Pushed by mqualmann into branch 'master'. basic grouping sync for the table view M +49 -4 core/app/views/tableview/tableview.cpp M +21 -0 core/app/views/tableview/tableview_model.cpp https://invent.kde.org/graphics/digikam/-/commit/f79f583611c4e4ee5b79b6f8e3972d292a7e2a36 Git commit 245614fb1920996726a0cd59e49e5b64829f1937 by Gilles Caulier. Committed on 10/12/2025 at 14:03. Pushed by cgilles into branch 'master'. Enhancement: Grouped Items Usability Improvements This update introduces significant usability improvements for grouped items in digiKam: - Visual Highlighting for Open Groups: Previously, only closed groups were visually distinguished by a decorative border around the thumbnail of the stack's representative image. Now, each item within an open group is also highlighted with a colored border, ensuring better visual consistency and making it easier to identify group members at a glance. - Tree-View in Image Properties: The Image Properties right sidebar tab now supports a tree-view display for grouped items. Users can expand or collapse group stacks on demand, providing a more intuitive and flexible workflow. For a visual demonstration of these features in action, check out the screencast of digiKam 8.9.0: https://i.imgur.com/9QZ8kZw.mp4 Related: bug 381414, bug 392936, bug 401205, bug 499108 FIXED-IN: 8.9.0 M +4 -3 NEWS M +28 -0 core/app/items/delegate/itemdelegate.cpp M +8 -0 core/libs/widgets/itemview/itemviewdelegate.cpp M +1 -0 core/libs/widgets/itemview/itemviewdelegate.h https://invent.kde.org/graphics/digikam/-/commit/245614fb1920996726a0cd59e49e5b64829f1937 |