| Summary: | When renaming file or folder on the desktop, the text field can end up smaller than the existing text, possibly letting it become visible | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | kimimaru |
| Component: | Desktop icons & Folder View widget | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | dmali, hein, lunelovehearn, nate, notmart, opensourcedonations, smitha |
| Priority: | NOR | Keywords: | regression |
| Version: | 6.0.1 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/3a0cc5449fc36ad9530dd300e8c7d5d2463c4b9b | Version Fixed In: | 6.1.4 |
| Sentry Crash Report: | |||
| Attachments: |
As shown, renaming a folder named "Test" still shows "Test" text, making it hard to see the full name
Shows how the renaming bug looks with Breeze |
||
|
Description
kimimaru
2024-03-08 02:09:48 UTC
It looks like you're using a custom theme. Can you still reproduce the issue with the default Breeze Plasma style? Created attachment 166750 [details]
Shows how the renaming bug looks with Breeze
After switching to Breeze Dark I now see a box covering the old name, which makes it much easier to rename. However, if the old name is two lines long and the new line is one line long, the old name is still visible. IMO I don't see a need to show the old name and don't recall seeing this behavior in Plasma 5.
Can reproduce the issue. Not a Plasma 6 regression; I'm pretty sure it's always been this way. *** Bug 487975 has been marked as a duplicate of this bug. *** *** Bug 484795 has been marked as a duplicate of this bug. *** *** Bug 487009 has been marked as a duplicate of this bug. *** (In reply to Nate Graham from comment #3) > Can reproduce the issue. Not a Plasma 6 regression; I'm pretty sure it's > always been this way. Nope, it wasn't like that in Plasma 5. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2413 Git commit c1ec86898f49d627d59e9afe5fa14efc49c3f949 by Nate Graham. Committed on 01/08/2024 at 00:11. Pushed by ngraham into branch 'master'. Folder View: hide existing label while renaming If we don't, it may peek out from behind the text field with the new name if the user chooses a shorter name, and that looks weird. This worked in the past but broke with the port to ShadowedLabel, which disabled the shadow while renaming when it should have hidden itself completely. FIXED-IN: 6.1.4 M +4 -1 containments/desktop/package/contents/ui/FolderItemDelegate.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/c1ec86898f49d627d59e9afe5fa14efc49c3f949 Git commit 3a0cc5449fc36ad9530dd300e8c7d5d2463c4b9b by Nate Graham. Committed on 01/08/2024 at 00:12. Pushed by ngraham into branch 'Plasma/6.1'. Folder View: hide existing label while renaming If we don't, it may peek out from behind the text field with the new name if the user chooses a shorter name, and that looks weird. This worked in the past but broke with the port to ShadowedLabel, which disabled the shadow while renaming when it should have hidden itself completely. FIXED-IN: 6.1.4 (cherry picked from commit c1ec86898f49d627d59e9afe5fa14efc49c3f949) 96fc78bf Folder View: hide existing label while renaming Co-authored-by: Nate Graham <nate@kde.org> M +4 -1 containments/desktop/package/contents/ui/FolderItemDelegate.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/3a0cc5449fc36ad9530dd300e8c7d5d2463c4b9b *** Bug 491339 has been marked as a duplicate of this bug. *** on plasma 6.2.1, this bug no longer happens. thanks everyone. |