| Summary: | Application Launcher icon ridiculously large in thick panel | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Tristan Miller <psychonaut> |
| Component: | Application Launcher (Kickoff) | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andy, ben-public, bugreporter42, danielpetrov, eugene.savitsky, javier.tia+bugzilla.kde, mail, mikel5764, nate, noahadvs, postix |
| Priority: | HI | ||
| Version: | 5.27.2 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=482612 https://bugs.kde.org/show_bug.cgi?id=486420 |
||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/d7e8d047e29aa16e1848076b1136e4997d33298d | Version Fixed In: | 6.0.5 |
| Sentry Crash Report: | |||
| Attachments: |
Screenshot showing ridiculously large Application Launcher icon
Screenshot of a widget Comparance - 6.0.4 vs 6.0.5 |
||
Is this bug perhaps a consequence of either of the following recent commits? * applets/kickoff: fix: height larger than previous version in vertical panel: https://github.com/KDE/plasma-desktop/commit/1988f0756ec9b61d6eff6eae14c1023502d7f701 * [kicker, kickoff] Port away from panel icon size hint: https://github.com/KDE/plasma-desktop/commit/277758af8c3f701c92f0b77aa8ecfc8d07ab9ac9 *** This bug has been marked as a duplicate of bug 466566 *** Screw it, let's just revert this change for Kickoff since it's the only widget people actually care about being too big, and we're not even consistent about everything being too big in the same way anyway, so there's no philosophical justification to continuing it. *** Bug 467716 has been marked as a duplicate of this bug. *** *** Bug 477813 has been marked as a duplicate of this bug. *** *** Bug 482612 has been marked as a duplicate of this bug. *** *** Bug 478947 has been marked as a duplicate of this bug. *** *** Bug 466566 has been marked as a duplicate of this bug. *** Actually I have the same problem with KDE 5.27.x (as with 6.x). Start button and Weather widgets are same huge. (In reply to ezh from comment #9) > Actually I have the same problem with KDE 5.27.x (as with 6.x). Start button > and Weather widgets are same huge. yeah I think I it depends which kicker alternative you use, or which specific widget For example Application Launcher is huge, but Application Dashboard and Application Menu are fixed by tweaking the size hints in org.kde.plasma.kicker/contents/ui/CompactRepresentation.qml (https://bugs.kde.org/show_bug.cgi?id=466566#c19) (In reply to Nate Graham from comment #3) > Screw it, let's just revert this change for Kickoff Also Kicker? to cover the 3 alternatives. The size hints in org.kde.plasma.kicker/contents/ui/CompactRepresentation.qml affect Application Dashboard and Application Menu's icon size, but not Application Launcher (kickoff) related https://bugs.kde.org/show_bug.cgi?id=483274 extra huge tray icons with vertical panel: https://bugsfiles.kde.org/attachment.cgi?id=166977 (In reply to andy from comment #12) > related https://bugs.kde.org/show_bug.cgi?id=483274 > extra huge tray icons with vertical panel: > https://bugsfiles.kde.org/attachment.cgi?id=166977 That isn't a bug (as of Plasma 5.27.10). Configure System Tray Settings > Panel Size Icon > Small Tray icons are unrelated here, and what you're seeing is currently intentional when in Touch Mode. That can be reconsidered too, but it would need a separate bug report. Can confirm this is still an issue in Plasma 6.0.4 with Frameworks version 6.1.0. I'm still using this post-install to fix it (currently plasma 6.0.3 and frameworks 6.1.0, arch linux) sed -i 's/root.Layout.minimumWidth = -1;/root.Layout.minimumWidth = -1; root.Layout.maximumWidth = 30;/g' /usr/share/plasma/plasmoids/org.kde.plasma.kicker/contents/ui/CompactRepresentation.qml sed -i 's/root.Layout.minimumHeight = -1;/root.Layout.minimumHeight = -1; root.Layout.maximumHeight = 30;/g' /usr/share/plasma/plasmoids/org.kde.plasma.kicker/contents/ui/CompactRepresentation.qml Created attachment 168914 [details]
Screenshot of a widget
Not only the "Start" button is huge, all other applets are as well. See screenshot.
So basically here's the situation. In the past we had a global "Panel icon size" setting that controlled the maximum size that icons can grow to across all Plasma panels. This presented some issues: 1. It was not presented as a maximum size, so people would adjust it, see that nothing happened, and get confused. 2. Not all widgets respected it, so even if you did have a thick panel, its effects often seemed random. 3. It was global in scope, when in principle it makes sense to be a panel-specific setting because not all panels are thick enough for the setting to be applicable. 1 and 2 were theoretically fixable using the existing infrastructure, but 3 was not. For these reasons, we deleted the setting late in Plasma 6, and deleted the backend code that it controlled in Plasma 6. Instead, all widgets scale with the panel thickness. This presents new issues: 1. Not all widgets do this! So sizing still feels random. 2. People with very thick panels who don't want their panel icons to be so huge no longer have a way to make that happen. Short term, this bug report proposes capping the maximum size of just Kickoff, since it's the thing people are complaining most about. Medium term, I think we should probably re-add a maximum icon size setting, but make it panel-specific, and then also put in the work to port *every* widget to use it, so that it doesn't feel random. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2231 Git commit 61fb4a6296cb1f5ff5de975bd6f128b1f0d4bc71 by Akseli Lahtinen. Committed on 01/05/2024 at 14:19. Pushed by akselmo into branch 'master'. kickoff: Use Kirigami.Units.iconSizes.huge as maximum icon size This avoids having ridiculously large icon size as a short term solution. M +2 -0 applets/kickoff/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/61fb4a6296cb1f5ff5de975bd6f128b1f0d4bc71 Git commit d7e8d047e29aa16e1848076b1136e4997d33298d by Akseli Lahtinen. Committed on 01/05/2024 at 14:19. Pushed by akselmo into branch 'Plasma/6.0'. kickoff: Use Kirigami.Units.iconSizes.huge as maximum icon size This avoids having ridiculously large icon size as a short term solution. (cherry picked from commit 61fb4a6296cb1f5ff5de975bd6f128b1f0d4bc71) 5ac00133 kickoff: Use Kirigami.Units.iconSizes.huge as maximum icon size M +2 -0 applets/kickoff/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/d7e8d047e29aa16e1848076b1136e4997d33298d My original bug report for Kicker got marked as a duplicate of this one. Is there any chance for a Kicker fix as well? Yes, I'll un-dupe it and fix that as well. Kicker is done in https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2234. *** Bug 486509 has been marked as a duplicate of this bug. *** Using KDE Neon Unstable on a testing notebook I still see huge start icon... Then Neon's packages must be running a little bit behind. Created attachment 169852 [details]
Comparance - 6.0.4 vs 6.0.5
Got KDE 6.0.5 on Fedora 40. The Launcher icon is now a bit smaller, but still huge.
So is your weather icon. I'm afraid that's the best we can do for now until we implement a per-panel maximum icon size feature. |
Created attachment 157081 [details] Screenshot showing ridiculously large Application Launcher icon I upgraded today from Plasma 5.26.5 to 5.27.2. The Application Launcher icon in my vertical panel now takes up the full width of the panel, whereas before the upgrade it was only a few dozen pixels wide. The new size is far too large -- see attached screenshot. STEPS TO REPRODUCE 1. Add a vertical panel with a width of, say, 256 pixels. 2. Add the Application Launcher to the panel. OBSERVED RESULT 1. The Application Launcher icon is ridiculously large, spanning the full width of the panel, and taking up too much vertical space. EXPECTED RESULT 1. The Application Launcher icon should be the same size as the application icons it contains. SOFTWARE/OS VERSIONS Linux/KDE Plasma: 5.27.2 KDE Plasma Version: 5.27.2 KDE Frameworks Version: 5.103.0 Qt Version: 5.15.8