| Summary: | [REG:5.0.2] Canvas input stops working after using shortcut with non-Latin keyboard | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Alvin Wong <alvin> |
| Component: | Shortcuts and Canvas Input Settings | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | CC: | amy, dimula73, donlee.ohhh, dsw0770, kofeeva2048, lady.syrin, nwad |
| Priority: | NOR | Keywords: | regression, release_blocker |
| Version: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/e822a4c673459fb5b39625709ceed6c0da8d16b0 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Bug Depends on: | |||
| Bug Blocks: | 453271, 452626, 452771, 452885, 452910, 453757, 453972, 454110, 454141, 454254, 454450 | ||
|
Description
Alvin Wong
2022-05-23 08:21:09 UTC
Reverting https://invent.kde.org/graphics/krita/-/commit/58392a1f9ae446da3f48c632f2bfe68d10a60ee4 fixes this, but of course that brings back bug 438784. I can still reproduce the issue with this commit reverted: https://invent.kde.org/graphics/krita/-/commit/58392a1f9ae446da3f48c632f2bfe68d10a60ee4 I can also reproduce the issue on Linux. Can reproduce in git commit a792621 on macOS Big Sur 11.6.5 (MBP Early 2015). It should be noted that in macOS, the pan action gets compressed until the space bar is released, after which all the movements get applied at once. Git commit d518783ca601fdc7f4d934cee01067137cc8f08e by Dmitry Kazakov. Committed on 26/05/2022 at 08:56. Pushed by dkazakov into branch 'master'. Fix unbalanced KeyPress/Release on non-latin keyboard on Linux Key release should come for exactly the same qt-key that was pressed before to keep them balanced. Even when the modifiers state changes in the meantime. A +96 -0 3rdparty/ext_qt/0001-Fix-unbalanced-KeyPress-Release-on-non-latin-keyboar.patch M +1 -1 3rdparty/ext_qt/CMakeLists.txt https://invent.kde.org/graphics/krita/commit/d518783ca601fdc7f4d934cee01067137cc8f08e Git commit d682f0f5b17f64494a718652cb4ea733f725d83c by Dmitry Kazakov. Committed on 26/05/2022 at 09:04. Pushed by dkazakov into branch 'master'. [win] Fix unbalanced KeyPress/Release events when using non-latin layout on Windows When the key is released with a different set of modifiers, we should notify application about the release of the old key, not the new one. E.g. for '2' vs '@' keys. A +103 -0 3rdparty/ext_qt/0001-win-Fix-unbalanced-KeyPress-Release-events-when-usin.patch M +1 -0 3rdparty/ext_qt/CMakeLists.txt https://invent.kde.org/graphics/krita/commit/d682f0f5b17f64494a718652cb4ea733f725d83c I've reported an upstream bug here: https://bugreports.qt.io/browse/QTBUG-103868 PS: The bug is still **not** fixed on macOS! It needs a separate patch. *** Bug 453972 has been marked as a duplicate of this bug. *** *** Bug 452910 has been marked as a duplicate of this bug. *** *** Bug 452771 has been marked as a duplicate of this bug. *** *** Bug 452626 has been marked as a duplicate of this bug. *** *** Bug 454450 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1470 Git commit 8184f93df3d0d67ed5ad534871c333802ad33b97 by Dmitry Kazakov. Committed on 12/06/2022 at 06:38. Pushed by dkazakov into branch 'master'. Add a workaround for unbalanced key events on macOS We have a proper fix for Linux and Windows in a form of a patch for Qt, but we still need a workaround for macOS. Qt bug: https://bugreports.qt.io/browse/QTBUG-103868 M +52 -0 libs/ui/input/kis_input_manager.cpp M +13 -0 libs/ui/input/kis_input_manager_p.cpp M +3 -0 libs/ui/input/kis_input_manager_p.h M +2 -1 libs/ui/input/kis_tablet_debugger.cpp https://invent.kde.org/graphics/krita/commit/8184f93df3d0d67ed5ad534871c333802ad33b97 Git commit cfbfc96940e2e30dd2d307f24764cc52aae1d235 by Dmitry Kazakov. Committed on 12/06/2022 at 06:38. Pushed by dkazakov into branch 'master'. Enable unbalanced key-events workaround for Linux distributions M +8 -0 libs/ui/input/kis_input_manager_p.cpp https://invent.kde.org/graphics/krita/commit/cfbfc96940e2e30dd2d307f24764cc52aae1d235 Git commit 7be72b55bdd711d1df5825a3e134ba97722fc997 by Dmitry Kazakov. Committed on 13/06/2022 at 06:39. Pushed by dkazakov into branch 'krita/5.1'. Enable unbalanced key-events workaround for Linux distributions M +8 -0 libs/ui/input/kis_input_manager_p.cpp https://invent.kde.org/graphics/krita/commit/7be72b55bdd711d1df5825a3e134ba97722fc997 Git commit e822a4c673459fb5b39625709ceed6c0da8d16b0 by Dmitry Kazakov. Committed on 13/06/2022 at 06:39. Pushed by dkazakov into branch 'krita/5.1'. Add a workaround for unbalanced key events on macOS We have a proper fix for Linux and Windows in a form of a patch for Qt, but we still need a workaround for macOS. Qt bug: https://bugreports.qt.io/browse/QTBUG-103868 M +52 -0 libs/ui/input/kis_input_manager.cpp M +13 -0 libs/ui/input/kis_input_manager_p.cpp M +3 -0 libs/ui/input/kis_input_manager_p.h M +2 -1 libs/ui/input/kis_tablet_debugger.cpp https://invent.kde.org/graphics/krita/commit/e822a4c673459fb5b39625709ceed6c0da8d16b0 |