Bug 452925

Summary:	[Desktop Grid] Dropping a window onto a desktop North/West from it's current position breaks window's drop animation
Product:	[Plasma] kwin	Reporter:	phd <phd>
Component:	effects-desktop-grid	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	5.24.4
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/kwin/commit/7a4cabf3287e82e7d1d6ba84b8b059ab470f9f42	Version Fixed In:	5.25
Sentry Crash Report:
Attachments:	desktop-grid-dropped-windows-drawn-behind-desktops-moving-E-ok.jpg desktop-grid-dropped-windows-drawn-behind-desktops-moving-NW-bug.jpg desktop-grid-dropped-windows-drawn-behind-desktops-moving-W-bug.jpg desktop-grid-dropped-windows-drawn-behind-desktops-2.webm

Description phd 2022-04-23 19:17:07 UTC

SUMMARY
Desktop Grid effect:
Dropping a window onto a desktop North and/or West from the dragged window's current position breaks the window's drop animation.
The window is drawn below the desktops East and/or South from the target desktop (that the window was dropped onto).
See attached images and video (flickering warning).

STEPS TO REPRODUCE
1. Open Desktop Grid effect.
2. Drag a window.
3. Drop it onto the *bottom-right* corner of a desktop.

OBSERVED RESULT
The window is drawn below the desktops East and/or South from the target desktop (that the window was dropped onto).
See attached images and video (flickering warning).

EXPECTED RESULT
Window should always be drawn above all the desktops in the Grid.

SOFTWARE/OS VERSIONS
Linux: Kubuntu 21.10
KWin Version: 5.24.4
KDE Plasma Version: 5.24.4
KDE Frameworks Version: 5.92.0
Qt Version: 5.15.2

Comment 1 phd 2022-04-23 19:17:48 UTC

Created attachment 148327 [details]
desktop-grid-dropped-windows-drawn-behind-desktops-moving-E-ok.jpg

Comment 2 phd 2022-04-23 19:18:08 UTC

Created attachment 148328 [details]
desktop-grid-dropped-windows-drawn-behind-desktops-moving-NW-bug.jpg

Comment 3 phd 2022-04-23 19:18:27 UTC

Created attachment 148329 [details]
desktop-grid-dropped-windows-drawn-behind-desktops-moving-W-bug.jpg

Comment 4 phd 2022-04-23 19:21:29 UTC

Created attachment 148330 [details]
desktop-grid-dropped-windows-drawn-behind-desktops-2.webm

Comment 5 Marco Martin 2022-05-06 10:45:17 UTC

Git commit 7a4cabf3287e82e7d1d6ba84b8b059ab470f9f42 by Marco Martin.
Committed on 06/05/2022 at 10:44.
Pushed by mart into branch 'master'.

QML version of the Desktop Grid effect

Replace completely the old desktop grid effect with a QML version.
Aims to feature parity and be a change as transparent as possible for the user.
Related: bug 433071, bug 452625, bug 443971, bug 437121, bug 437928, bug 452439, bug 288530, bug 450254, bug 450106, bug 447832, bug 449960, bug 416576, bug 441862, bug 444859, bug 445999, bug 422117, bug 404627, bug 435483, bug 420744, bug 435482, bug 427055, bug 333445, bug 429120, bug 427391, bug 409295, bug 294322, bug 356955
FIXED-IN: 5.25

M  +5    -0    src/effects.cpp
M  +10   -5    src/effects/desktopgrid/CMakeLists.txt
D  +0    -1571 src/effects/desktopgrid/desktopgrid.cpp
D  +0    -186  src/effects/desktopgrid/desktopgrid.h
D  +0    -32   src/effects/desktopgrid/desktopgrid.kcfg
M  +6    -14   src/effects/desktopgrid/desktopgrid_config.cpp
M  +2    -2    src/effects/desktopgrid/desktopgrid_config.h
M  +68   -144  src/effects/desktopgrid/desktopgrid_config.ui
A  +32   -0    src/effects/desktopgrid/desktopgridconfig.kcfg
M  +5    -1    src/effects/desktopgrid/desktopgridconfig.kcfgc
A  +342  -0    src/effects/desktopgrid/desktopgrideffect.cpp     [License: GPL(v2.0+)]
A  +108  -0    src/effects/desktopgrid/desktopgrideffect.h     [License: GPL(v2.0+)]
M  +5    -4    src/effects/desktopgrid/main.cpp
D  +0    -26   src/effects/desktopgrid/main.qml
M  +1    -0    src/effects/desktopgrid/metadata.json
A  +255  -0    src/effects/desktopgrid/qml/DesktopView.qml     [License: GPL(v2.0+)]
A  +193  -0    src/effects/desktopgrid/qml/main.qml     [License: GPL(v2.0+)]
M  +22   -5    src/effects/private/qml/WindowHeap.qml
M  +21   -3    src/libkwineffects/kwineffects.h
M  +4    -1    src/libkwineffects/kwinquickeffect.cpp

https://invent.kde.org/plasma/kwin/commit/7a4cabf3287e82e7d1d6ba84b8b059ab470f9f42