Bug 451217

Summary: "Open in terminal" menu item, like in Dolphin
Product: [Plasma] plasmashell Reporter: tomashnyk
Component: FolderAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: wishlist CC: hein, kevin.kofler, nate, postix
Priority: NOR    
Version: 5.24.2   
Target Milestone: 1.0   
Platform: Kubuntu   
OS: Linux   
Latest Commit: Version Fixed In: 5.26
Attachments: Folder view vs doplhin context menu
Desktop (free space) menu
Desktop context menu for a directory

Description tomashnyk 2022-03-06 23:53:41 UTC
Created attachment 147336 [details]
Folder view vs doplhin context menu

Folder view should ideally behave as Dolphin when using the right context menu.
It misses the "Open in terminal" menu item.
Comment 1 tomashnyk 2022-03-06 23:56:37 UTC
This is a a bug that is part of a group listing inconsistencies between Folder view context menus and Dolphin context menus. The otehr bugs are:
https://bugs.kde.org/show_bug.cgi?id=451216
https://bugs.kde.org/show_bug.cgi?id=451215
https://bugs.kde.org/show_bug.cgi?id=451214
https://bugs.kde.org/show_bug.cgi?id=448799
(I was asked to open separate bugs for these in the last bug)
Comment 2 Nate Graham 2022-09-10 21:42:39 UTC
commit a91ff4e4b61f22ecf49debccf16ce7d190248c91
Author: Neal Gompa <ngompa@fedoraproject.org>
Date:   Sat Sep 10 10:54:06 2022 -0400

    containmentactions/contextmenu: Add "Open Terminal" action
    
    This adds the ability to open the terminal from the main Plasma Shell
    context menu. It was originally written as a Red Hat/Fedora patch
    for KDE Workspace 4 to open Konsole from the desktop context menu
    when Fedora switched to KDE 4, and ported forward to KDE Plasma 5
    when Fedora Linux switched to Plasma 5 in Fedora 22.
    
    It has been maintained as a downstream patch since then.
    
    This version of the patch genericizes the patch by not implying that
    Konsole is the user's terminal (it actually opens the user's chosen
    terminal anyway), can be restricted via the desktop kiosk mode
    settings, and is disabled by default.
    
    The major maintainers of this patch are being honored as co-authors
    for this patch. They have all helped keep this functionality working
    across two KDE major versions for a decade.
    
    Co-authored-by: Daniel Vrátil <dvratil@redhat.com>
    Co-authored-by: Jan Grulich <jgrulich@redhat.com>
    Co-authored-by: Marc Deop <marcdeop@fedoraproject.org>
    Co-authored-by: Rex Dieter <rdieter@fedoraproject.org>
    
    BUG: 451217
Comment 3 tomashnyk 2022-09-10 21:51:46 UTC
Thanks! can't wait for 5.26!
Comment 4 Nate Graham 2022-09-10 21:53:06 UTC
Awesome!

Note that this new menu item is off by default and must be manually turned on. Fedora will probably turn it on by default in their packaging though, given that it's their patch. :)
Comment 5 tomashnyk 2022-09-10 22:14:04 UTC
Well, I actually use open in Konsole menu: https://invent.kde.org/-/snippets/1897 (and it works on the desktop too)

However, now I see this might be fixing something else than I reported. When you look at the attachment, I was comparing the context menu in Folder view when clicking on a directory.

This fix is for  clicking on the desktop, no?
Comment 6 Nate Graham 2022-09-12 18:33:56 UTC
this is for the desktop context menu, yes. Dolphin's context menu already had this feature.
Comment 7 tomashnyk 2022-09-12 19:42:52 UTC
Created attachment 152006 [details]
Desktop (free space) menu

There are two Desktop menus. One is a context menu when I click on the desktop, which is on this screenshot. It can be configured as the screenshot shows. I thought this fix is for this menu, which si not what this but was meant to be about.
Comment 8 tomashnyk 2022-09-12 19:44:40 UTC
Created attachment 152007 [details]
Desktop context menu for a directory

Adn then there is a context menu on the Desktop shown when one right-clicks a directory (this screenshot). I have no idea where I can edit that (or does ti shra configuration with Dolphin). This bug and all the linked bugs were filed about this menu.

So which one is the fix about?
Comment 9 Nate Graham 2022-09-12 19:50:11 UTC
Oh I guess that's not done, then. Darn.

Can you file a new bug report for it, since we already used this one for something else?
Comment 10 tomashnyk 2022-09-12 20:00:57 UTC
(In reply to Nate Graham from comment #9)
> Oh I guess that's not done, then. Darn.
> 
> Can you file a new bug report for it, since we already used this one for
> something else?

Here: https://bugs.kde.org/show_bug.cgi?id=459033
Comment 11 Nate Graham 2022-09-12 20:03:54 UTC
Thank you!
Comment 12 Kevin Kofler 2022-09-18 16:21:41 UTC
For the record, the original author of the patch is Than Ngo:
https://src.fedoraproject.org/rpms/kdebase-workspace/c/b5cfa5f91cd86113d415b3693154e728a8a99a94?branch=ae9448efad448b5721203c07651efabd659f8757