Bug 445999

Summary:	Deletion of virtual desktop created in overview effect 5.24 results in wrong displayed layout in the grid effect
Product:	[Plasma] kwin	Reporter:	postix <postix>
Component:	effects-desktop-grid	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate, postix
Priority:	NOR	Keywords:	regression
Version:	5.23.3
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/kwin/commit/7a4cabf3287e82e7d1d6ba84b8b059ab470f9f42	Version Fixed In:	5.25
Sentry Crash Report:

Description postix 2021-11-23 20:58:49 UTC

STEPS TO REPRODUCE
1. Have a 2x2 grid
2. Place a virtual desktop pager in the taskbar

3. Source build kwin master (5.24) via kdesrc-build  
4. Start the build: kwin_x11 --replace
5. Invoke the new overview effect
6. Add another desktop via the virtual desktop bar in the new overview effect (so in total you have now 5)
--- 1 2 5
--- 3 4

7. Close the overview effect
8. Right click on the virtual desktop 5 in the pager and choose "delete virtual desktop"
9. Invoke the grid effect

OBSERVED RESULT
1) The pager shows again a 2x2 layout as well as the virtual desktop settings.
2) The grid however shows more of an "L" shape:
--- 1 2 3
--- 4


SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20211121
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.2
Kernel Version: 5.15.2-1-default (64-bit)
Graphics Platform: X11

Comment 1 Marco Martin 2022-05-06 10:48:05 UTC

Git commit 7a4cabf3287e82e7d1d6ba84b8b059ab470f9f42 by Marco Martin.
Committed on 06/05/2022 at 10:44.
Pushed by mart into branch 'master'.

QML version of the Desktop Grid effect

Replace completely the old desktop grid effect with a QML version.
Aims to feature parity and be a change as transparent as possible for the user.
Related: bug 433071, bug 452625, bug 443971, bug 437121, bug 452925, bug 437928, bug 452439, bug 288530, bug 450254, bug 450106, bug 447832, bug 449960, bug 416576, bug 441862, bug 444859, bug 422117, bug 404627, bug 435483, bug 420744, bug 435482, bug 427055, bug 333445, bug 429120, bug 427391, bug 409295, bug 294322, bug 356955
FIXED-IN: 5.25

M  +5    -0    src/effects.cpp
M  +10   -5    src/effects/desktopgrid/CMakeLists.txt
D  +0    -1571 src/effects/desktopgrid/desktopgrid.cpp
D  +0    -186  src/effects/desktopgrid/desktopgrid.h
D  +0    -32   src/effects/desktopgrid/desktopgrid.kcfg
M  +6    -14   src/effects/desktopgrid/desktopgrid_config.cpp
M  +2    -2    src/effects/desktopgrid/desktopgrid_config.h
M  +68   -144  src/effects/desktopgrid/desktopgrid_config.ui
A  +32   -0    src/effects/desktopgrid/desktopgridconfig.kcfg
M  +5    -1    src/effects/desktopgrid/desktopgridconfig.kcfgc
A  +342  -0    src/effects/desktopgrid/desktopgrideffect.cpp     [License: GPL(v2.0+)]
A  +108  -0    src/effects/desktopgrid/desktopgrideffect.h     [License: GPL(v2.0+)]
M  +5    -4    src/effects/desktopgrid/main.cpp
D  +0    -26   src/effects/desktopgrid/main.qml
M  +1    -0    src/effects/desktopgrid/metadata.json
A  +255  -0    src/effects/desktopgrid/qml/DesktopView.qml     [License: GPL(v2.0+)]
A  +193  -0    src/effects/desktopgrid/qml/main.qml     [License: GPL(v2.0+)]
M  +22   -5    src/effects/private/qml/WindowHeap.qml
M  +21   -3    src/libkwineffects/kwineffects.h
M  +4    -1    src/libkwineffects/kwinquickeffect.cpp

https://invent.kde.org/plasma/kwin/commit/7a4cabf3287e82e7d1d6ba84b8b059ab470f9f42