| Summary: | Add some padding around menu highlight | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Photon <ncqm3qdz> |
| Component: | QStyle | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | nate, noahadvs, oded, phyllon, plasma-bugs, uhhadd |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/breeze/commit/3993ab7900986b2c594ccad34ab93d30ff346f01 | Version Fixed In: | 5.25 |
| Attachments: |
Weird looking
Zoomed image Screenshot showing old behavior |
||
Created attachment 143820 [details]
Zoomed image
Also, increasing the padding of menus would fix that bug which the first item is clicked right after the menu is opened (can't find it right now). A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze/-/merge_requests/186 (In reply to Photon from comment #2) > Also, increasing the padding of menus would fix that bug which the first > item is clicked right after the menu is opened (can't find it right now). Bug 374311. And yes, it would fix that too! How exciting. Git commit 3993ab7900986b2c594ccad34ab93d30ff346f01 by Jan Blackquill, on behalf of Janet Blackquill. Committed on 17/02/2022 at 23:42. Pushed by ngraham into branch 'master'. kstyle: add menu margin This is more consistent with Plasma and our qqc2-desktop-style. Related: bug 374311 FIXED-IN: 5.25 M +1 -0 kstyle/breezemetrics.h M +4 -0 kstyle/breezestyle.cpp https://invent.kde.org/plasma/breeze/commit/3993ab7900986b2c594ccad34ab93d30ff346f01 Created attachment 146976 [details]
Screenshot showing old behavior
Up until this change, the menu item highlight looked like it extends past the edge of the menu by a pixel on either side (the effect is seen better on dark backgrounds, as shown on the right side of the attached screenshot and is not visible on the left side's bright background).
I though that effect was interesting, different and quirky - all in a good way, and I'm sad to see it go.
*** Bug 446198 has been marked as a duplicate of this bug. *** |
Created attachment 143819 [details] Weird looking Breeze now has rounded corners in the selected menu item. However, the rounded corners look too weird when the item has an outline right after it or when the item is the first/last. Maybe the rounded corners could be dropped too.