Bug 445758

Summary:	Not possible to set activation time begin after 00:00
Product:	[Applications] systemsettings	Reporter:	Max <maximtsyba>
Component:	kcm_nightcolor	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kwin-bugs-null, natalie_clarius, nate
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/kwin/commit/07c79d088f7dbedace595f1b25296adc4a70f358	Version Fixed In:	5.25.5
Sentry Crash Report:
Attachments:	screenshot of error

Description Max 2021-11-19 16:51:15 UTC

SUMMARY
Currently night color expects "begin" time to appear one day before "end" time, not allowing for them to be on the same day. This restriction makes no sense to user and takes away from the flexibility which "Custom time" option is intended to provide.

STEPS TO REPRODUCE
1. Open system settings -> Display and Monitor -> Night color
2. Set "Activation time" to "Custom time"
3. Try setting "Turn on at" to 00:01, and "Turn off at" to 7:00

OBSERVED RESULT
Settings utility does not allow to do that, showing Error: Morning is before evening

EXPECTED RESULT
User should be able to set any time slot he/she wants. I would say there should be no date check at all.
But if it should be there for some reason, then it must figure out on it's own that 00:01-07:00 is a totally fine time period.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE neon 5.23
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.3

ADDITIONAL INFORMATION

Comment 1 Max 2021-11-19 16:54:28 UTC

Created attachment 143737 [details]
screenshot of error

Comment 2 Nate Graham 2021-11-23 22:48:43 UTC

Yeah, this is a silly limitation that we should remove.

*** This bug has been marked as a duplicate of bug 390021 ***

Comment 3 Natalie Clarius 2022-08-28 04:06:14 UTC

Same as https://bugs.kde.org/show_bug.cgi?id=447987: Not a duplicate of bug 39002.

Merge request started: https://invent.kde.org/plasma/kwin/-/merge_requests/2868

Comment 4 Natalie Clarius 2022-08-28 04:10:09 UTC

(In reply to Natalie Clarius from comment #3)
> Same as https://bugs.kde.org/show_bug.cgi?id=447987: Not a duplicate of bug
> 39002.

Typo; I meant to say: Not a duplicate of bug 390021 https://bugs.kde.org/show_bug.cgi?id=390021. This bug report is about being unable to set certain night time ranges; the other is a request to additionally set a day color value.

Comment 5 Vlad Zahorodnii 2022-08-29 10:15:27 UTC

Git commit ae05d5e654752e3cced8b8f3818bd278c12a2196 by Vlad Zahorodnii, on behalf of Natalie Clarius.
Committed on 29/08/2022 at 09:17.
Pushed by vladz into branch 'master'.

plugins/nightcolor: change time handling to allow for arbitrary morning and evening times

M  +17   -21   src/plugins/nightcolor/nightcolormanager.cpp
M  +3    -0    src/plugins/nightcolor/nightcolormanager.h

https://invent.kde.org/plasma/kwin/commit/ae05d5e654752e3cced8b8f3818bd278c12a2196

Comment 6 Vlad Zahorodnii 2022-08-29 10:19:13 UTC

Git commit 07c79d088f7dbedace595f1b25296adc4a70f358 by Vlad Zahorodnii, on behalf of Natalie Clarius.
Committed on 29/08/2022 at 10:19.
Pushed by vladz into branch 'Plasma/5.25'.

plugins/nightcolor: change time handling to allow for arbitrary morning and evening times


(cherry picked from commit ae05d5e654752e3cced8b8f3818bd278c12a2196)

M  +17   -21   src/plugins/nightcolor/nightcolormanager.cpp
M  +3    -0    src/plugins/nightcolor/nightcolormanager.h

https://invent.kde.org/plasma/kwin/commit/07c79d088f7dbedace595f1b25296adc4a70f358