| Summary: | GTK toolbar buttons have outline | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Fabian Vogt <fabian> |
| Component: | gtk theme | Assignee: | Janet Blackquill <uhhadd> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | efeciftci, elman, nate, null, plasma-bugs, s_chriscollins, zawertun |
| Priority: | VHI | Keywords: | regression |
| Version: | 5.23.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/breeze-gtk/commit/6834ee83d09b7c56fbe3d137b660db25484573f3 | Version Fixed In: | 5.23.4 |
| Sentry Crash Report: | |||
| Attachments: |
Eclipse IDE with borders around toolbar icons after upgrading breeze-gtk-theme to 5.23
breeze-gtk-5.23.0-fix-toolbar-buttons-style.patch |
||
Can reproduce. gtk-widget-factory is okay and so is gedit, so this may end up being an app bug that we triggered with that change. Still, we should investigate and fix if possible. Created attachment 142481 [details]
Eclipse IDE with borders around toolbar icons after upgrading breeze-gtk-theme to 5.23
I can confirm Eclipse IDE (2021-09) is affected as well.
Synaptic Package Manager is also affected. *** Bug 444050 has been marked as a duplicate of this bug. *** *** Bug 445678 has been marked as a duplicate of this bug. *** Same bug spotted in "Virt manager" and "FileZilla" (see duplicate: https://bugs.kde.org/show_bug.cgi?id=445678). OBSERVED RESULT FileZilla: https://i.imgur.com/xuOHOxn.png Virt Manager: https://i.imgur.com/kFIVRd5.png EXPECTED RESULT How they should like: FileZilla: https://i.imgur.com/I9qSiY1.png Virt Manager: https://i.imgur.com/LSDrhYq.png Created attachment 143688 [details]
breeze-gtk-5.23.0-fix-toolbar-buttons-style.patch
A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze-gtk/-/merge_requests/31 Git commit 23ba2a8dc728cd7105e5994ed1d4dc143f7d69a1 by Yaroslav Sidlovsky. Committed on 18/11/2021 at 11:21. Pushed by ngraham into branch 'master'. Fixed toolbar buttons style, removing unneeded outline M +5 -0 src/gtk3/widgets/_button.scss https://invent.kde.org/plasma/breeze-gtk/commit/23ba2a8dc728cd7105e5994ed1d4dc143f7d69a1 Git commit 6834ee83d09b7c56fbe3d137b660db25484573f3 by Nate Graham, on behalf of Yaroslav Sidlovsky. Committed on 18/11/2021 at 16:48. Pushed by ngraham into branch 'Plasma/5.23'. Fixed toolbar buttons style, removing unneeded outline (cherry picked from commit 23ba2a8dc728cd7105e5994ed1d4dc143f7d69a1) M +5 -0 src/gtk3/widgets/_button.scss https://invent.kde.org/plasma/breeze-gtk/commit/6834ee83d09b7c56fbe3d137b660db25484573f3 Sorry for how long that took, everyone! |
GTK toolbar buttons like in Inkscape have an outline like standalone push buttons now, which looks weird. This wasn't the case with 5.22.90, so this is most likely caused by 3b2ce1abd2f45cf844c43cac6e7009a59bff0dd9 ("gtk3, gtk4: update button style") Found by openQA: https://openqa.opensuse.org/tests/1963509#step/inkscape/19