Bug 443192

Summary:	Add scrollbar to annotation toolbar
Product:	[Applications] Spectacle	Reporter:	Jack Hill <jackhill3103>
Component:	General	Assignee:	Boudhayan Gupta <me>
Status:	RESOLVED UPSTREAM
Severity:	minor	CC:	antonio.prcela, bugseforuns, kde, nate, postix
Priority:	NOR
Version:	21.08.1
Target Milestone:	---
Platform:	Other
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=444149
Latest Commit:	https://github.com/ksnip/kImageAnnotator/commit/96986668fd70104b350e5d640e6557239d7e7944	Version Fixed In:
Sentry Crash Report:

Description Jack Hill 2021-10-01 10:41:14 UTC

SUMMARY
If the screenshot height is small, the left annotation toolbar is trimmed but there is no scrollbar.
This means I cannot access all toolbar items without resizing the entire window.
I think it would be nice to add a scrollbar so that we can access all toolbar items.

STEPS TO REPRODUCE
1. Take screenshot
2. Press "Annotate"

OBSERVED RESULT
Left toolbar is trimmed and not all actions can be selected

EXPECTED RESULT
Left toolbar is trimmed, but there is a scrollbar

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE Tumbleweed 20210928
KDE Plasma Version: 5.22.5
KDE Frameworks Version: 5.86.0
Qt Version: 5.15.2

Comment 1 Nate Graham 2021-10-05 00:19:14 UTC


*** This bug has been marked as a duplicate of bug 429833 ***

Comment 2 Jack Hill 2021-10-08 11:59:25 UTC

I disagree that this is a duplicate of 426107 and 429833. Those two are for resizing the annotation window for when the screenshot itself is too large.

This bug is for images of any size, particularly small sizes. If those two bugs were fixed by automatically resizing the window to become the exact size of the screenshot, this bug would still exist for small screenshots.

Comment 3 Nate Graham 2021-10-08 15:27:23 UTC

OK fair enough.

Comment 4 Antonio Prcela 2021-11-08 20:51:06 UTC

Seems more like an kImageAnnotator thing, so I upstreamed the patch:

https://github.com/ksnip/kImageAnnotator/pull/258

Comment 5 Antonio Prcela 2021-11-08 21:20:04 UTC

*** Bug 444149 has been marked as a duplicate of this bug. ***

Comment 6 postix 2021-11-08 21:24:17 UTC

How did you think about the proposal to add two columns in order to prevent the need of scrolling?

Comment 7 Antonio Prcela 2021-11-08 21:36:17 UTC

(In reply to postix from comment #6)
> How did you think about the proposal to add two columns in order to prevent
> the need of scrolling?

Since it has to be done upstream, not in Spectacle, I'd guess it's easier to get a 'yay' for a simple scrollbar that appears when needed than to have kImageAnnotator changed to two columns.

Also, depending how we want to solve this:
https://bugs.kde.org/show_bug.cgi?id=429833
Considering that the Window of Spectacle is quite small when in default Annotate mode, a second column would just decrease the available area for the image. Except if we'd go with solution a) in the above mentioned bug.

Comment 8 Antonio Prcela 2021-11-14 18:02:39 UTC

https://github.com/ksnip/kImageAnnotator/pull/258

Merged upstream in kImageAnnotator.
Now play the waiting game? :)

Comment 9 Nate Graham 2021-11-16 01:26:25 UTC

Very cool, thanks a lot for that!