| Summary: | Broken corners on pop-ups, dialogs, applets, and tooltips | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] libplasma | Reporter: | Nate Graham <nate> |
| Component: | components | Assignee: | veggero <niccolo.venerandi> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | agurenko, ahiemstra, alex765, alexban011, aqddmrsoqikopsmpwf, bugseforuns, cristobal.veas, david.cortes.rivera, dev.bacteriostat, developer.gl513, firlaevhans.fiete, francogpellegrini, harsimran, ifs6nmho, jan.rathmann, kde, lemuelsimon32, link, liubomirwm, martial, matej.starc, matejm98mthw, me, med.medin.2014, mrnycticorax, niccolo.venerandi, niccolo, nishith.khanna, notmart, orowwith2os, plasma-bugs, poperigby, popov895, postix, qydwhotmail, radimir.cacic09, rikmills, rudnik336, smit17xp, s_chriscollins, vsgarofalojerez, xanaddams, yule2000, zawertun |
| Priority: | VHI | Keywords: | regression |
| Version: | 5.83.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=455270 https://bugs.kde.org/show_bug.cgi?id=417511 |
||
| Latest Commit: | https://invent.kde.org/frameworks/plasma-framework/-/commit/f76ba887f413054142dfaf724f13382e2a3f3735 | Version Fixed In: | 5.99 |
| Sentry Crash Report: | |||
| Attachments: |
Broken corners
Broken corners only brulbehind effect visible Third Party Theme Screenshot: Plasma applet's hint corners Broken corner on panel Broken corner on panel Floating panel black corner Panels still have broken corner with frameworks 5.99 |
||
*** Bug 438615 has been marked as a duplicate of this bug. *** Let's try to avoid shipping this to users, since it seems to be master-only at this point. Created attachment 139488 [details]
Broken corners
Found this after updating to Frameworks 5.83.0, only dark theme is affected. All Plasma widgets with rounded corners have this problem, it's clearly visible on a dark background.
Disabling "Background contrast" effect solves this issue, but also disables adaptive transparency. *** Bug 438978 has been marked as a duplicate of this bug. *** Created attachment 139663 [details]
only brulbehind effect visible
in this screenshot, i disabled in Dialog all the rendering, the only thing that gets rendered is the blurbehind/contrast kwin effects.
you can see that on on there only the top left corner is rounded, while the others not, which cause the problem.
i suspect that the mask gets scaled 2x by kwin, having the final result scaled 4x instead.
same thing happens for the shadows themselves, so they always look slightly more pixelated than needed
*** Bug 439282 has been marked as a duplicate of this bug. *** *** Bug 439387 has been marked as a duplicate of this bug. *** *** Bug 439879 has been marked as a duplicate of this bug. *** *** Bug 439750 has been marked as a duplicate of this bug. *** *** Bug 439234 has been marked as a duplicate of this bug. *** *** Bug 439408 has been marked as a duplicate of this bug. *** *** Bug 439974 has been marked as a duplicate of this bug. *** *** This bug has been marked as a duplicate of bug 439408 *** Disabling the "Background contrast" effect per comment #4 doesn't really solve the issue, but does make it less noticeable. *** Bug 444069 has been marked as a duplicate of this bug. *** Not sure if it's the same issue, but from bug 444069, for me they only show glitched corners when the active app is something with media playing capabilities, such as VLC or web browsers, and that's regardless of whether the corners touch those apps or not. Also for me this happens in X11 without scaling. Created attachment 142754 [details] Third Party Theme This issue seems to be specific to the Breeze plasma theme, third party themes like https://store.kde.org/p/1368860 do no have issues with the corners. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/362 *** Bug 445255 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/377 Git commit 9ba4ed4da72a3d1bbec8920d93a547cf633cfacd by Marco Martin. Committed on 10/11/2021 at 15:26. Pushed by mart into branch 'master'. smaller mask to hide glitches This makes the mask slightly maller than the frame. Since the svg will have antialiasing and the mask not, there will be artifacts at the corners, if they go under the svg they're less evident M +7 -2 src/plasmaquick/dialog.cpp https://invent.kde.org/frameworks/plasma-framework/commit/9ba4ed4da72a3d1bbec8920d93a547cf633cfacd Thanks Marco I tried it on my KDE Neon Git distro on Breeze Dark theme and it works flawless thanks for the fix. Created attachment 143674 [details]
Screenshot: Plasma applet's hint corners
I guess, this is the same bug?
Operating System: Fedora Linux 35
KDE Plasma Version: 5.23.2
KDE Frameworks Version: 5.87.0
*** Bug 445852 has been marked as a duplicate of this bug. *** The fix for this was included in Frameworks 5.89. If it still occurs with that or a more recent version then please reopen this. (In reply to Arjen Hiemstra from comment #26) > The fix for this was included in Frameworks 5.89. If it still occurs with > that or a more recent version then please reopen this. I still see broken corners on my panels (Breeze dark, Wayland). Screenshots attached. Created attachment 145677 [details]
Broken corner on panel
Created attachment 145678 [details]
Broken corner on panel
Frameworks 5.90.0, Plasma 5.23.5
Indeed, Marco's fix was a workaround that only works with some combinations of plasma themes and color schemes, not a true final fix. *** Bug 417511 has been marked as a duplicate of this bug. *** *** Bug 454126 has been marked as a duplicate of this bug. *** *** Bug 454273 has been marked as a duplicate of this bug. *** *** Bug 454467 has been marked as a duplicate of this bug. *** *** Bug 454501 has been marked as a duplicate of this bug. *** *** Bug 454794 has been marked as a duplicate of this bug. *** *** Bug 455262 has been marked as a duplicate of this bug. *** I've tried building and installing https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/522, but it didn't make a difference. Is that supposed to fix the issue? That MR is currently not fixing the bug as intended; there's a suggestion from Nate in the MR that actually works for that specific bug, however I have not updated the MR as d_ed already said that it would not be the correct way to approach the issue. That said, this bug here is not caused just by the scaling issue that's being fixed in that MR; as an example, if you have this bug in the top left corner of your dialog/window/anything, it means it's unrelated to that MR. (In reply to Niccolò Venerandi from comment #40) > That MR is currently not fixing the bug as intended; there's a suggestion > from Nate in the MR that actually works for that specific bug, however I > have not updated the MR as d_ed already said that it would not be the > correct way to approach the issue. > > That said, this bug here is not caused just by the scaling issue that's > being fixed in that MR; as an example, if you have this bug in the top left > corner of your dialog/window/anything, it means it's unrelated to that MR. OK, thanks for the answer. Created attachment 149951 [details]
Floating panel black corner
This only happens when the panel is "floating"
I'm using Desert Global Color
*** Bug 455749 has been marked as a duplicate of this bug. *** *** Bug 457575 has been marked as a duplicate of this bug. *** Fixed by Niccolò Venerandi with https://invent.kde.org/frameworks/plasma-framework/-/commit/f76ba887f413054142dfaf724f13382e2a3f3735 in Frameworks 5.99! I still have broken corners on panel but not on other highlighted in this bug report. Operating System: Arch Linux KDE Plasma Version: 5.26.0 KDE Frameworks Version: 5.99.0 Qt Version: 5.15.6 Kernel Version: 5.19.13-arch1-1 (64-bit) Graphics Platform: Wayland Created attachment 152765 [details]
Panels still have broken corner with frameworks 5.99
Oops, just saw bug 417511. Panel issue is separate from this one. Closing this. I can confirm that the Plasma update to 5.26.1 fixes the bug for me on my dark panels :) It's still happening for me randomly but it's very inconsistent to reproduce. Every night I would turn off my monitor and leave the computer running, and the next day I would see broken corners on all Plasma tooltips, popouts, and OSDs after turning on the monitor as if the fixes never existed. It would go away after I run `rm -rf ~/.cache/plasma*` in the terminal and then restart plasmashell and/or KWin, but then again the broken corners come back after a few days. Operating System: Manjaro Linux KDE Plasma Version: 5.27.5 KDE Frameworks Version: 5.106.0 Qt Version: 5.15.9 Graphics Platform: X11 Graphics Processor: AMD Radeon RX 570 Series Graphics Driver: AMDGPU (Mesa 23.0.3) Timothy, there's a very good chance the issue you're experiencing is caused by a different specific root cause, even if the outward symptoms look and feel the same. Can you please submit a new bug report? Thank you! |
Created attachment 139319 [details] Broken corners See attached screenshot taken in the Plasma Wayland session at 200% scale (after clearing the cache, natch). The corners are broken except for the top-left one.