| Summary: | KNewStuff dialogs have no close button in the titlebar | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-knewstuff | Reporter: | Alexander Lohnau <alexander.lohnau> |
| Component: | general | Assignee: | Alexander Lohnau <alexander.lohnau> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | admin, allo, asturm, bugseforuns, kde-bugs, kdelibs-bugs, lv215bd5, nate, ncqm3qdz, nieskazanov, w.bill.coady |
| Priority: | VHI | Keywords: | regression |
| Version: | 5.88.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=464193 | ||
| Latest Commit: | https://invent.kde.org/frameworks/knewstuff/commit/ea19fa6e824650f3257e8047d6f90e01899b2e03 | Version Fixed In: | 5.93 |
| Attachments: |
xprop output
GammaRay |
||
|
Description
Alexander Lohnau
2021-05-25 10:53:07 UTC
*** Bug 437686 has been marked as a duplicate of this bug. *** Dan, can you look into this? It only seems to affect GHNS dialogs. Can you please post the xprop output for GHNS? If motif hints don't permit close action, it's a client bug. Created attachment 139066 [details]
xprop output
*** Bug 440576 has been marked as a duplicate of this bug. *** > _MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x3, 0x1e, 0x6e, 0x0, 0x0
Does this mean anything to you, Vlad? :)
*** Bug 445985 has been marked as a duplicate of this bug. *** *** Bug 446788 has been marked as a duplicate of this bug. *** *** Bug 447114 has been marked as a duplicate of this bug. *** I am not entirely sure this is the same bug as I reported. On my system there IS a close button, it just not function as expected. A single click does nothing and a double click acts as a minimize/maximize button. But the close button IS there. Seems like this is an X11-specific problem; the button appears for me on Wayland, but not on X11. Created attachment 144693 [details]
GammaRay
GammaRay says that window's flags is missing WindowCloseButtonHint.
What if KNewStuff dialogs were transformed into modal dialogs such as the one used to change SDDM background, for example? https://bugs.kde.org/show_bug.cgi?id=449272 A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/211 Git commit 5d00aefc464bfedd5df00225c21e13063edcf17c by Alexander Lohnau. Committed on 28/01/2022 at 06:07. Pushed by alex into branch 'Plasma/5.24'. Fix compilation on Plasma/5.24 branch M +1 -0 faces/CMakeLists.txt https://invent.kde.org/plasma/libksysguard/commit/5d00aefc464bfedd5df00225c21e13063edcf17c A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/171 Git commit ea19fa6e824650f3257e8047d6f90e01899b2e03 by Nate Graham, on behalf of Alexander Lohnau. Committed on 08/03/2022 at 15:03. Pushed by ngraham into branch 'master'. Fix close button for NewStuff.Dialog not existing on X11 We need this to be a proper window in order for it to have window decorations like the close button. FIXED-IN: 5.93 M +10 -5 src/qtquick/qml/Dialog.qml https://invent.kde.org/frameworks/knewstuff/commit/ea19fa6e824650f3257e8047d6f90e01899b2e03 Looks like the fix for this issue was a workaround for Bug 464193 that only worked for this window. Bug 464193 tracks the root cause. |