| Summary: | 45e0a722fb85bb5d1ab8bef92080e934254b13aa (plasma-workspace) breaks showing lock screen UI by typing | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Nate Graham <nate> |
| Component: | Theme - Breeze | Assignee: | visual-design |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ai0867, fabian, katyaberezyaka, kde, oded, plasma-bugs, tusooa |
| Priority: | VHI | Keywords: | regression |
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/13057013d55ae19e76d29b9edc96510e52da2a7a | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2021-01-08 01:55:38 UTC
> property bool blockUI: mainStack.depth > 1 || mainBlock.mainPasswordBox.text.length > 0 || inputPanel.keyboardActive
Heh, it's here. We were actually using whether the text box has text to clear the "screensaver"
Given were doing that, we can't drop the focus.
I'll rework to do something like Fabian's patch.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/561 Git commit 2cbd7e4c70d0592d16cdaf58ed43effe4a716aa4 by David Edmundson. Committed on 10/01/2021 at 22:54. Pushed by davidedmundson into branch 'master'. [lookandfeel] Fix wake existing screensaver mode with key presses In commit 45e0a722fb85bb5d1ab8bef92080e934254b13aa we changed the focus on the textfield with the intention of fixing the cusor blinking. This had the unfortunate side effect of breaking waking out of the screensaver mode with just the keyboard. That screensaver mode was bound to: ``` property bool blockUI: mainBlock.mainPasswordBox.text.length > 0 ``` for that to change, we need to have focus. Instead this patches cursor blinking more explicity. Doing it only in the lock screen (as opposed to the toolkit) makes sense as this only happens due to somewhat unusual usage inside the lockscreen. M +0 -3 lookandfeel/contents/lockscreen/LockScreenUi.qml M +6 -0 lookandfeel/contents/lockscreen/MainBlock.qml https://invent.kde.org/plasma/plasma-workspace/commit/2cbd7e4c70d0592d16cdaf58ed43effe4a716aa4 Git commit 13057013d55ae19e76d29b9edc96510e52da2a7a by Nate Graham, on behalf of David Edmundson. Committed on 11/01/2021 at 01:17. Pushed by ngraham into branch 'Plasma/5.18'. [lookandfeel] Fix wake existing screensaver mode with key presses In commit 45e0a722fb85bb5d1ab8bef92080e934254b13aa we changed the focus on the textfield with the intention of fixing the cusor blinking. This had the unfortunate side effect of breaking waking out of the screensaver mode with just the keyboard. That screensaver mode was bound to: ``` property bool blockUI: mainBlock.mainPasswordBox.text.length > 0 ``` for that to change, we need to have focus. Instead this patches cursor blinking more explicity. Doing it only in the lock screen (as opposed to the toolkit) makes sense as this only happens due to somewhat unusual usage inside the lockscreen. (cherry picked from commit 2cbd7e4c70d0592d16cdaf58ed43effe4a716aa4) M +0 -3 lookandfeel/contents/lockscreen/LockScreenUi.qml M +6 -0 lookandfeel/contents/lockscreen/MainBlock.qml https://invent.kde.org/plasma/plasma-workspace/commit/13057013d55ae19e76d29b9edc96510e52da2a7a *** Bug 431427 has been marked as a duplicate of this bug. *** *** Bug 431966 has been marked as a duplicate of this bug. *** *** Bug 432028 has been marked as a duplicate of this bug. *** |