| Summary: | "Remove all" button does nothing when Disks & Devices applet is showing non-removable devices | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Patrick Silva <bugseforuns> |
| Component: | Disks & Devices | Assignee: | Nate Graham <nate> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version: | 5.19.90 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/410362c1bf963a83c75ee48c105abf780e485b0f | Version Fixed In: | 5.20 |
| Sentry Crash Report: | |||
| Attachments: | screenshot | ||
The button is only supposed to appear when there are more than one removable devices attached. This is what I see; I don't see the button when the applet is displaying only non-removable devices. Is that what you see? Can I have a screenshot? *** Bug 427176 has been marked as a duplicate of this bug. *** Created attachment 132137 [details]
screenshot
Thanks. Found the bug. Dunno if this is a regression from the previous one or nor, but either way, I'll fix it. Git commit a9cef6070fdba0c0cab51f9f364cd31e1886e2c7 by Nate Graham. Committed on 05/10/2020 at 21:34. Pushed by ngraham into branch 'master'. [applets/devicenotifier] Be more selective about showing "Remove all" button This button only makes sense to show when using the "Removable devices" setting in the combobox. FIXED-IN: 5.20 M +4 -1 applets/devicenotifier/package/contents/ui/FullRepresentation.qml https://invent.kde.org/plasma/plasma-workspace/commit/a9cef6070fdba0c0cab51f9f364cd31e1886e2c7 Git commit 410362c1bf963a83c75ee48c105abf780e485b0f by Nate Graham. Committed on 05/10/2020 at 21:36. Pushed by ngraham into branch 'Plasma/5.20'. [applets/devicenotifier] Be more selective about showing "Remove all" button This button only makes sense to show when using the "Removable devices" setting in the combobox. FIXED-IN: 5.20 (cherry picked from commit a9cef6070fdba0c0cab51f9f364cd31e1886e2c7) M +4 -1 applets/devicenotifier/package/contents/ui/FullRepresentation.qml https://invent.kde.org/plasma/plasma-workspace/commit/410362c1bf963a83c75ee48c105abf780e485b0f |
STEPS TO REPRODUCE 1. have two or more partitions of internal devices on your system 2. open Disks & Devices systray applet 3. open "Show" combobox on top and choose "Non-removable devices" ("Remove all" button is available despite all listed devices are non-removable) 4. click on "Remove all" button OBSERVED RESULT nothing happens EXPECTED RESULT I do not know the purpose of this "Remove all" button. Unmount all non-removable devices? If so, it's not working and its label is inaccurate. If we do not want to unmount non-removable devices, then should not exist a "Remove all" button when Disks & Devices applet is only showing non-removable devices. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.19.90 KDE Frameworks Version: 5.74.0 Qt Version: 5.15.1 ADDITIONAL INFORMATION