| Summary: | KCM tries to set images as icons that are too large | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | David Redondo <kde> |
| Component: | kcm_users | Assignee: | Janet Blackquill <uhhadd> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aspotashev, kde, nate, plasma-bugs, this.is.reid |
| Priority: | NOR | Keywords: | regression |
| Version: | 5.19.90 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/commit/b0af2127b4177392e915bd621fd41a082365a0b1 | Version Fixed In: | 5.21 |
|
Description
David Redondo
2020-09-24 19:34:35 UTC
*** This bug has been marked as a duplicate of bug 22177 *** *** This bug has been marked as a duplicate of bug 422177 *** This is different. That bug is about change signals on things that are correctly applied. Though us resizing via temp file would cause accounts service to always copy into icons instead of just updating the path which would solve that bug. (In reply to David Edmundson from comment #3) > This is different. > > That bug is about change signals on things that are correctly applied. > > Though us resizing via temp file would cause accounts service to always > copy into icons instead of just updating the path which would solve that bug. Fair enough, was probably a bit tired yesterday and didn't read correctly. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/163 Git commit 05768142c17600c8d4583f171d08157ecc337390 by David Redondo. Committed on 05/10/2020 at 13:19. Pushed by davidre into branch 'master'. Add some rudimentary error handling to users kcm Don't fail silently when an error occurs otherwise the kcm just looks broken. Show at least an inline message so the user knows that something went wrong. The comment was wrong. We can distinguish why an error occured. Furthermore, even if it is a permission denied error we do not know if the user canceled the action or if it failed for some other reason so also treat that as an error. Related: bug 425036 FIXED-IN:5.20 CCMAIL:uhhadd@gmail.com M +17 -1 kcms/users/package/contents/ui/UserDetailsPage.qml M +13 -0 kcms/users/src/CMakeLists.txt M +36 -4 kcms/users/src/user.cpp M +12 -1 kcms/users/src/user.h M +2 -2 kcms/users/src/usermodel.cpp https://invent.kde.org/plasma/plasma-desktop/commit/05768142c17600c8d4583f171d08157ecc337390 Git commit 8500046453ae90862f72049e1a24ec804ce85cff by David Redondo. Committed on 05/10/2020 at 13:20. Pushed by davidre into branch 'cherry-pick-05768142'. Add some rudimentary error handling to users kcm Don't fail silently when an error occurs otherwise the kcm just looks broken. Show at least an inline message so the user knows that something went wrong. The comment was wrong. We can distinguish why an error occured. Furthermore, even if it is a permission denied error we do not know if the user canceled the action or if it failed for some other reason so also treat that as an error. Related: bug 425036 FIXED-IN:5.20 CCMAIL:uhhadd@gmail.com (cherry picked from commit 05768142c17600c8d4583f171d08157ecc337390) M +17 -1 kcms/users/package/contents/ui/UserDetailsPage.qml M +13 -0 kcms/users/src/CMakeLists.txt M +36 -4 kcms/users/src/user.cpp M +12 -1 kcms/users/src/user.h M +2 -2 kcms/users/src/usermodel.cpp https://invent.kde.org/plasma/plasma-desktop/commit/8500046453ae90862f72049e1a24ec804ce85cff A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/175 *** Bug 427764 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/262 Git commit b0af2127b4177392e915bd621fd41a082365a0b1 by Nate Graham, on behalf of Carson Black. Committed on 15/12/2020 at 15:26. Pushed by ngraham into branch 'master'. [kcms/users]: Resize provided image to always be smaller than 1MB This prevents accounts service from complaining about too large files M +38 -1 kcms/users/src/user.cpp M +2 -1 kcms/users/src/user.h https://invent.kde.org/plasma/plasma-desktop/commit/b0af2127b4177392e915bd621fd41a082365a0b1 |