Bug 426606

Summary:	Cannot edit text shape after saving in a vector library
Product:	[Applications] krita	Reporter:	Tiar <tamtamy.tymona>
Component:	Layers/Vector	Assignee:	Krita Bugs <krita-bugs-null>
Status:	CONFIRMED ---
Severity:	normal	CC:	ahab.greybeard, sovrack
Priority:	NOR
Version First Reported In:	5.2.9
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Example Vector Library with a text shape

Description Tiar 2020-09-16 12:59:23 UTC

Created attachment 131698 [details]
Example Vector Library with a text shape

SUMMARY
All vector shapes are auto-grouped, and text shape inside a group is not editable. Hence if you make a vector library with a text shape, it won't be editable when you drag it out of the library to the canvas.

STEPS TO REPRODUCE
1. Create a vector library with a text shape.
2. Drag the text shape onto the canvas.

OBSERVED RESULT
The text shape cannot be edited.
If you right-click and select "Ungroup", you can edit text.

EXPECTED RESULT
The text shape should be editable from the start.

SYSTEM INFORMATION
Krita version 4.3.0
Linux Mint


ADDITIONAL INFORMATION
Quote from David from bug 423925:
> The 'auto-ungroup' to edit the text quicker sounds also productive; 
> *but* might also be an issue for other SVGs objects if this one is 
> apllied to everything. In fact, I think many items in the library work 
> better grouped while being inserted (eg: vector object made of many shapes). 
> I don't know how to solve that, maybe a "auto ungroup on isertion" checkbox
> in the 'Vector Library' panel? I'm not happy about it: it adds another
> option and doesn't sounds very smart. Maybe there is a way for the
> 'Vector Library' action of inserting to detect "single object" and
> auto-ungroup in only this case? Grouping a single text/shape/object
> sounds wrong in all the cases...

In my opinion it would be safe to not group text shapes. Other single shapes might or might not be grouped, but it's especially important for text shapes since then they cannot be edited.
Also note: it might be worth checking if a group is grouped too (so the result is double-grouped).

Comment 1 Ahab Greybeard 2020-09-17 09:28:12 UTC

I can understand David's concern about ungrouping pre-existing groups in the vector library but I don't think this would happen if there was an auto-ungroup applied to content after it was dragged out of the library docker and onto the canvas.

An addition level of grouping is applied to the object after it's been dropped onto the canvas and seems to be an efficient way of applying a positional offset, depending on where it's been placed on the canvas.
An auto-ungroup would result in a small computational load to move the offset values into the lower level of grouping (or into the object itself in the case of an initially ungrouped single object).

For a vector library symbol block, internally there may be an additional level of grouping imposed by whatever application has been used to create the vector library but it is possible to have a single ungrouped vector object in a symbol block. Hence auto-ungrouping of any dragged out vector object would work for text (that was not grouped in the symbol block) and would not affect the grouping of other types of library content.

Checking for any existing lower levels of grouping and deciding if it's safe or appropriate to remove them is a separate thing and would be complicated.

Comment 2 Tiar 2020-11-07 20:48:31 UTC

Bug 396945 mentions issues with editing a shape that got grouped and needs to be ungrouped before editing.

Comment 3 vanyossi 2022-09-29 23:13:33 UTC

*** Bug 396945 has been marked as a duplicate of this bug. ***

Comment 4 Vitamorus 2025-05-02 08:17:16 UTC

Re-confirmed for 5.2.9.
I don't think this is a bug, however, but since others have taken a look at this report and confirmed it I will leave it as such.

There is probably no best way to solve this with how Krita treats groups right now, as it's impossible to determine the intentions of elements and their order in a symbol. A text element isn't necessarily the foreground of a symbol or meant to be edited. 

I would suggest taking inspiration from draw.io (FOSS) and how group objects are handled there. In draw.io a user can navigate into groups and subgroups just by clicking on the elements inside them. A user can also double click an element within a group and subgroups to edit it directly.