| Summary: | Split applet into two: "Power Management" and "Brightness" | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | medin <med.medin.2014> |
| Component: | Battery Monitor | Assignee: | Kai Uwe Broulik <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bugseforuns, kde, natalie_clarius, nate, ncqm3qdz, now.im.627, plasma-bugs, postix |
| Priority: | NOR | Keywords: | usability |
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=415073 | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/0f0975d8c1ded2a65844c5c998a5ae4612fb260b | Version Fixed In: | 6.0 |
| Bug Depends on: | |||
| Bug Blocks: | 448271 | ||
|
Description
medin
2020-07-16 11:38:25 UTC
Whilst I agree with your comment about it being un-intuitive the proposal has severe drawbacks.
>The icon should be changed to "sun" symbol
Then we're not showing the battery information in an easily visible place.
This is important information to surface visually.
(In reply to David Edmundson from comment #1) > Whilst I agree with your comment about it being un-intuitive the proposal > has severe drawbacks. > > >The icon should be changed to "sun" symbol > > Then we're not showing the battery information in an easily visible place. > This is important information to surface visually. For me, It's not logical to always link brightness control with power settings. I can have max brightness with battery mode enabled, and I can have min brightness with AC mode. The only link is the impact of "Save mode" on brightness level which is valid only when battery is used but for desktops or laptops using always AC mode it's not valid at all. (In reply to David Edmundson from comment #1) > Whilst I agree with your comment about it being un-intuitive the proposal > has severe drawbacks. > > >The icon should be changed to "sun" symbol > > Then we're not showing the battery information in an easily visible place. > This is important information to surface visually. The brightness icon should be separated from battery settings, so the brightness icon is always visible with or without battery used, but the battery icon should be enable only when a battery is detected and shows only battery level status. The power settings/save mode can always be accessed via global settings. There's some logic to the idea of separating brightness settings from battery settings. All systems will have brightness control, while not all have any batteries or battery-powered devices connected. We need a place for laptop users to be able to easily see their battery status, and there are plans afoot to add power profiles to that applet too. So we can't just delete the battery applet and make all of its settings only accessible in System settings. Thus, we would need two applets: one for screen/keyboard brightness, and another one for battery and power management stuff. Doing this would result in people with laptops and battery-powered connected devices gaining an additional System Tray icon. I guess that's not a serious problem, but some people really don't like having tons and tons of items in their System Tray. Also, when you want to save power, reducing the brightness is one of the best ways to do it, so it makes a bit of sense to have brightness be in the power management applet. Undecided. Perhaps the icon itself could somehow be changed to visually incorporate brightness as well? I would like to propose a solution. It is ok not separating the icons. However, as soon as the AC power is connected, the battery icon gets hidden in status and notification menu. So, if I need to change the brightness, I can't do it with a single tap. Solution: Battery icon is always visible in taskbar. Now that Bug 415073 is fixed, this is now only relevant for machines with batteries. The only real fix I can think of is to split the applet's content into two new ones: Power Management - Battery information - Sleep & Screen locking blocking checkbox - Power profiles Brightness - Screen brightness - Keyboard brightness Not sure how desirable that would be though. Would need more discussion. Lowering priority. That would be the perfect solution. Splitting these two would make these two options more modular. Hey, what about adding nightlight controls (warmer, cooler) in the brightness applet? Just like this concept: https://www.reddit.com/r/kde/comments/rzvw1u/redesign_concepts_and_ideas_for_plasma_yay_or_nay/ This might work. That's a good idea IMO, but unrelated to this bug report; can you file a new one requesting that? Repoted here: https://bugs.kde.org/show_bug.cgi?id=448271 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3504 Git commit 0f0975d8c1ded2a65844c5c998a5ae4612fb260b by Natalie Clarius. Committed on 18/11/2023 at 18:49. Pushed by nclarius into branch 'master'. applets: split battery and brightness Closes: #93 FIXED-IN: 6.0 M +1 -0 applets/CMakeLists.txt M +1 -74 applets/batterymonitor/package/contents/ui/PopupDialog.qml M +3 -0 applets/batterymonitor/package/contents/ui/PowerProfileItem.qml M +0 -20 applets/batterymonitor/package/contents/ui/logic.js M +11 -84 applets/batterymonitor/package/contents/ui/main.qml M +2 -106 applets/batterymonitor/package/metadata.json A +3 -0 applets/brightness/CMakeLists.txt A +2 -0 applets/brightness/Messages.sh R +0 -0 applets/brightness/package/contents/ui/BrightnessItem.qml [from: applets/batterymonitor/package/contents/ui/BrightnessItem.qml - 100% similarity] A +42 -0 applets/brightness/package/contents/ui/CompactRepresentation.qml [License: LGPL(v2.0+)] A +128 -0 applets/brightness/package/contents/ui/PopupDialog.qml [License: LGPL(v2.0+)] A +27 -0 applets/brightness/package/contents/ui/logic.js A +186 -0 applets/brightness/package/contents/ui/main.qml [License: LGPL(v2.0+)] A +127 -0 applets/brightness/package/metadata.json https://invent.kde.org/plasma/plasma-workspace/-/commit/0f0975d8c1ded2a65844c5c998a5ae4612fb260b |