Bug 448271 - Integrate night mode controls into separate Brightness applet
Summary: Integrate night mode controls into separate Brightness applet
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Battery Monitor (show other bugs)
Version: 5.23.5
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on: 424283
Blocks:
  Show dependency tree / graph
 
Reported: 2022-01-11 17:04 UTC by Nowshed H. Imran
Modified: 2023-11-18 18:12 UTC (History)
4 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/-/commit/883eccad71ca69661acf0334a9ea52d77cc55edb
Version Fixed In: 6.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nowshed H. Imran 2022-01-11 17:04:57 UTC 
SUMMARY
In the upcoming release brightness has been split from the power icon. Nightmode can be included in the brightness kcm.

As discussed here:

https://bugs.kde.org/show_bug.cgi?id=424283
Comment 1 Nate Graham 2022-01-11 17:10:09 UTC 
> In the upcoming release brightness has been split from the power icon
It hasn't; the existing applet simply changes its icon to show a brightness icon when there are no batteries. It's not actually a separate applet. This is still a requested thing that hasn't been done yet; see Bug 424283.

Marking that as a blocker for this.
Comment 2 Natalie Clarius 2023-11-18 18:12:28 UTC 
Git commit 883eccad71ca69661acf0334a9ea52d77cc55edb by Natalie Clarius.
Committed on 18/11/2023 at 18:49.
Pushed by nclarius into branch 'master'.

applets/brightness: integrate night color
FIXED-IN: 6.0

M  +0    -5    applets/brightness/package/contents/ui/CompactRepresentation.qml
A  +228  -0    applets/brightness/package/contents/ui/NightColorItem.qml     [License: GPL(v2.0+)]
M  +10   -0    applets/brightness/package/contents/ui/PopupDialog.qml
M  +75   -3    applets/brightness/package/contents/ui/main.qml
A  +12   -0    applets/brightness/plugin/CMakeLists.txt
A  +124  -0    applets/brightness/plugin/nightcolorinhibitor.cpp     [License: GPL(v2.0+)]
A  +74   -0    applets/brightness/plugin/nightcolorinhibitor.h     [License: GPL(v2.0+)]
A  +309  -0    applets/brightness/plugin/nightcolormonitor.cpp     [License: GPL(v2.0+)]
A  +164  -0    applets/brightness/plugin/nightcolormonitor.h     [License: GPL(v2.0+)]
A  +63   -0    applets/brightness/plugin/nightcolormonitor_p.h     [License: GPL(v2.0+)]
A  +26   -0    applets/brightness/plugin/plugin.cpp     [License: GPL(v2.0+)]

https://invent.kde.org/plasma/plasma-workspace/-/commit/883eccad71ca69661acf0334a9ea52d77cc55edb