| Summary: | JPEG Save Quality slider setting is not saved | ||
|---|---|---|---|
| Product: | [Applications] gwenview | Reporter: | roman <colibri> |
| Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ajorgederosario, martonmiklosqdev, nate, pveax, the.neophytes.logs |
| Priority: | VHI | ||
| Version: | 20.04.2 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/gwenview/1e309832d203bcb9f3dad4d2d8ff4e0e4e182ea9 | Version Fixed In: | 20.12.1 |
| Sentry Crash Report: | |||
| Attachments: |
video of the bug
the destroyed image Slider not saving the setting |
||
|
Description
roman
2020-06-23 22:03:07 UTC
*** Bug 423413 has been marked as a duplicate of this bug. *** I have tried and failed to reproduce this on both a Plasma 5.18.5 Manjaro machine and a Plasma 5.19.80 Unstable KDE Neon VM. Have you tried using a different image? If you can reproduce this issue, can you attach a video of an image being deleted after you crop it with Gmenview? You can use any screen recording software such as OBS. Flagging the bug as NEEDSINFO temporarily. Created attachment 129639 [details]
video of the bug
Hi there,
this happens with every jpeg file but not with e.g. pngs.
(sorry I forgot to mention that after cropping and saving, I am pressing F5 to reload the image.) That's weird. Still can't reproduce on both systems even if I reload. I'll try to make an OpenSUSE tumbleweed VM. Created attachment 129643 [details]
the destroyed image
Thank you for your effort.
The image of konqi was created with spectacle. But this happens with other jpegs as well.
Here is the resulat after I cropped it. May be this helps some how?
Do you know what is used for cropping/saving? Maybe imagemagic or so?
I could check that on the command line.
As far as I know, the code for cropping images is implemented in Gwenview itself, somewhere in here: https://invent.kde.org/graphics/gwenview/-/tree/master/lib/crop . Unfortunately, while I am somewhat familiar with C++, I've never used QT before so this code is complete gibberish to me. If you can understand it I encourage you to try and pinpoint the exact location of your problem. I'll report back in a while whether this bug is reproducible on a fresh install of OpenSUSE Tumbleweed. Hopefully someone more technically competent can help you to fix the issue. Still can't reproduce on fresh install of OpenSuse Tumbleweed on a VM. Can you go to Settings > Configure Gwenview > JPEG save quality and tell me what it's set to? Okay now I feel really dumb and sorry for the noise :( It was set to 0%. But I am 100% sure that it wasn't me who set it to 0%. (I am using this feature quite often and as an photographer I would never set it to 0%.) But there seems to be probably a bug with the slider. Created attachment 129695 [details]
Slider not saving the setting
In the slider setting isn't saved.
It get's saved if I set it to a value, click ok and close qwenview + restart (then it is preserved otherwise not)
Thanks for the update; I changed the issue title accordingly. *** Bug 422607 has been marked as a duplicate of this bug. *** This is somehow my fault since I wrote this feature. I'll see if I can figure out what's going wrong here. *** Bug 428063 has been marked as a duplicate of this bug. *** If duplicate bug ticket was resolved, then why this ticket not? Or exact minor version of 20.04.x awaits for a fix? This isn't fixed yet. I have submitted a proposed patch on Phabricator: https://phabricator.kde.org/D29886 Thanks! However we are using GitLab now. Any chance you could close this and re-submit your patch as a merge request at https://invent.kde.org/graphics/gwenview/-/merge_requests/? Fixed with that merge request. :) |