| Summary: | Can't bind Meta + !, @, #, etc. anymore for keybindings (i.e. those which involve the shift key) | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kdeclarative | Reporter: | Taylor <titleistfan910> |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | REOPENED --- | ||
| Severity: | normal | CC: | info.ised, japareaggae, jpmbatrina01, kde, kdelibs-bugs, m1f5orxk, myles.jon.gordon, nate, nevoreko, pierremacherel, plasma-bugs, the.neophytes.logs, wjake1324 |
| Priority: | VHI | Keywords: | regression |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=423080 https://bugs.kde.org/show_bug.cgi?id=390109 https://bugs.kde.org/show_bug.cgi?id=423084 |
||
| Latest Commit: | https://invent.kde.org/frameworks/kdeclarative/-/commit/acd8dd06412b8af1650bfdbf46eee82b7eaef5ca | Version Fixed In: | 5.74 |
| Attachments: |
Screenshot of incorrect binding
Screenshot of Meta+! shortcut on plasma 5.18.5 |
||
Created attachment 129587 [details] Screenshot of Meta+! shortcut on plasma 5.18.5 I can confirm this bug is not present on plasma 5.18.5. See attached screenshot for expected behavior. This bug is probably related to Bug 423080 which affects plasma 5.19 *** Bug 423887 has been marked as a duplicate of this bug. *** *** Bug 424035 has been marked as a duplicate of this bug. *** Hello, I might have found the cause of this issue. KDeclarative's KeySequenceItem started as a clone of KXmlGui's KKeySequence. git blame shows that 1a919c88 is when this happens, and for some reason, the KKeyServer::isShiftAsModifierAllowed check is omitted. (links to the lines) https://invent.kde.org/frameworks/kxmlgui/-/blob/master/src/kkeysequencewidget.cpp#L769 https://invent.kde.org/frameworks/kdeclarative/-/blob/master/src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp#L457 Readding the check fixes this bug, but my limited testing does not guarantee it not introducing new ones or resulting to regressions, especially since it was conciously omitted before. While this fixes the case with Meta as modifier, it does not work with any other modifier (or just shift + num) from what I tested. After that issue is resolved, then only the keys hardcoded into the check are allowed to be with Shift. https://invent.kde.org/frameworks/kwindowsystem/-/blob/master/src/kkeyserver.cpp#L96 Fixed with https://invent.kde.org/frameworks/kdeclarative/-/commit/acd8dd06412b8af1650bfdbf46eee82b7eaef5ca *** Bug 425727 has been marked as a duplicate of this bug. *** *** Bug 426073 has been marked as a duplicate of this bug. *** *** Bug 324488 has been marked as a duplicate of this bug. *** *** Bug 310881 has been marked as a duplicate of this bug. *** Still not working on my site: KDE Plasma: 5.27.4 KDE Framewrok: 5.105.0 Qt: 5.15.9 Kernel: 6.3.1-arch1-1 (64-bit) I'm trying to set "Meta+Shift+>" for "Window to Next Screen", but It's doesn't work. I also tried editing the ".config/kglobalshortcutsrc" file from "Meta+>" to "Meta+Shift+>" (and rebooting) without luck. Thanks |
Created attachment 129560 [details] Screenshot of incorrect binding SUMMARY Binding Meta+Shift+1 no longer binds to Meta+!. It now binds to Meta+Shift+!. This is an impossible key combination to press. STEPS TO REPRODUCE 1. Try to bind Meta+Shift+1/Meta+! to any keybinding. (In my case, "window to desktop 1" binding) 2. 3. OBSERVED RESULT Binds to Meta+Shift+! instead of Meta+! EXPECTED RESULT Binds to Meta+! SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: 5.19.1 KDE Frameworks Version: 5.71.0 Qt Version: 5.15.0 ADDITIONAL INFORMATION I've had no issues using these binds for previous versions of plasma. Seems to be introduced recently.