Summary: | Allow changing PNG settings in "Video" tab | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Tiar <tamtamy.tymona> |
Component: | Animation | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dimula73, halla |
Priority: | NOR | ||
Version: | 4.2.8 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/kde/krita/commit/7f8b4f066808dfce487ec4d2fa87e453bd34e079 | Version Fixed In: |
Description
Tiar
2020-02-12 21:06:19 UTC
Note: if we ever have the situation where for an 8 or 16 bit integer image any of the HDR specific code paths are used, then that's a big bug that needs to be fixed. 16-bit integer mode supports HDR perfectly fine. It is in PNG file format :) Okay, I see several (possible) problems: 1) We share "last used" PNG settings with the ones the user used for saving normal images. The code is in DlgAnimationRenderer::sequenceMimeTypeOptionsClicked(). I don't know how good or bad it is from UIX point of view. Theoretically, it should be okay, but I'm not sure. 2) The main problem is that to enable HDR we should tick two checkboxes in different dialogs: in PNG export settings and in video settings. Ideally, there should be only one checkbox for it, but it clashes with point 1) :) Git commit 06b236db5be6c27adda9f48855d4de0cc325e60a by Dmitry Kazakov, on behalf of Eoin O'Neill. Committed on 07/04/2020 at 15:21. Pushed by dkazakov into branch 'master'. Video tab and Image Sequence tab HDR synchronization fix. Previously, these two windows could have their own HDR states. That has been corrected by giving the animation export window it's own hdr state (overriding the ForceHDR variable, since it's no longer necessary) which can be used to determine whether or not the image sequence / video should be configured to support HDR. M +19 -5 plugins/extensions/animationrenderer/DlgAnimationRenderer.cpp M +2 -1 plugins/extensions/animationrenderer/DlgAnimationRenderer.h M +10 -2 plugins/extensions/animationrenderer/video_export_options_dialog.cpp M +2 -1 plugins/extensions/animationrenderer/video_export_options_dialog.h https://invent.kde.org/kde/krita/commit/06b236db5be6c27adda9f48855d4de0cc325e60a Git commit 7f8b4f066808dfce487ec4d2fa87e453bd34e079 by Dmitry Kazakov, on behalf of Eoin O'Neill. Committed on 08/04/2020 at 18:33. Pushed by dkazakov into branch 'krita/4.3'. Video tab and Image Sequence tab HDR synchronization fix. Previously, these two windows could have their own HDR states. That has been corrected by giving the animation export window it's own hdr state (overriding the ForceHDR variable, since it's no longer necessary) which can be used to determine whether or not the image sequence / video should be configured to support HDR. M +19 -5 plugins/extensions/animationrenderer/DlgAnimationRenderer.cpp M +2 -1 plugins/extensions/animationrenderer/DlgAnimationRenderer.h M +10 -2 plugins/extensions/animationrenderer/video_export_options_dialog.cpp M +2 -1 plugins/extensions/animationrenderer/video_export_options_dialog.h https://invent.kde.org/kde/krita/commit/7f8b4f066808dfce487ec4d2fa87e453bd34e079 |