| Summary: | Completely disfunctional dialog in 19.12 | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] KAccounts | Reporter: | Antonio Rojas <arojas> |
| Component: | KCM | Assignee: | Nicolas Fella <nicolas.fella> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | CC: | admin, andysardina22, bhush94, blucvg, dashonwwIII, dev, la_iscla, nate, nicolas.fella, wbauer1, wulf.richartz |
| Priority: | VHI | Keywords: | usability |
| Version: | 19.12 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kaccounts-integration/67fc8d83b71f2b1304615ea087023ef66a9c9d5d | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
old KCM module displaying all accounts
19.12 KCM module |
||
|
Description
Antonio Rojas
2019-12-16 22:01:45 UTC
Created attachment 124534 [details]
old KCM module displaying all accounts
Created attachment 124535 [details]
19.12 KCM module
*** Bug 415586 has been marked as a duplicate of this bug. *** Can this please be reverted to the 18.12 dialog until it is fixed? As it is now the dialog is totally unusable. Sorry for the duplication! Another problematic thing is that Google doesn't allow logging now, it complains that KDE is a nonverified app. Does anybody know the reason? (In reply to Andi Sardina from comment #5) > Sorry for the duplication! > > Another problematic thing is that Google doesn't allow logging now, it > complains that KDE is a nonverified app. Does anybody know the reason? That is a different issue: https://bugs.kde.org/show_bug.cgi?id=414219 (In reply to Antonio Rojas from comment #4) > Can this please be reverted to the 18.12 dialog until it is fixed? As it is > now the dialog is totally unusable. I meant 19.08 of course *** Bug 416519 has been marked as a duplicate of this bug. *** *** Bug 417313 has been marked as a duplicate of this bug. *** We really need to get these bugs fixed. Just posted a review for a patch to fix the main issue in this report: https://phabricator.kde.org/D27454 (there is more which wants doing, but this makes the kcm actually function) Git commit 2420b04e3d01cd02c26e238221a7603614830d15 by Dan Leinir Turthra Jensen. Committed on 17/02/2020 at 13:42. Pushed by leinir into branch 'master'. Unbreak the Accounts KCM Summary: Prior to this, the Accounts KCM would show only the first account, because the listview was a zero by zero size (which results in the first item still being shown because labels will overpaint unless told otherwise). The reson it looked like there was a view there before was that the view was set to the ScrollViewKCM's default scroll view. In other words: All the accounts were in fact there, but they were not displayed because the listview was not there. Reviewers: #plasma, nicolasfella, bshah Reviewed By: #plasma, bshah Subscribers: arojas Tags: #plasma Differential Revision: https://phabricator.kde.org/D27454 M +2 -2 src/kcm/package/contents/ui/Accounts.qml M +1 -3 src/kcm/package/contents/ui/AvailableAccounts.qml M +1 -2 src/kcm/package/contents/ui/AvailableServices.qml https://commits.kde.org/kaccounts-integration/2420b04e3d01cd02c26e238221a7603614830d15 Shouldn't the fix also be submitted to the 19.12 branch? Git commit 67fc8d83b71f2b1304615ea087023ef66a9c9d5d by Wolfgang Bauer, on behalf of Dan Leinir Turthra Jensen. Committed on 02/03/2020 at 20:58. Pushed by wbauer into branch 'release/19.12'. Unbreak the Accounts KCM Summary: Prior to this, the Accounts KCM would show only the first account, because the listview was a zero by zero size (which results in the first item still being shown because labels will overpaint unless told otherwise). The reson it looked like there was a view there before was that the view was set to the ScrollViewKCM's default scroll view. In other words: All the accounts were in fact there, but they were not displayed because the listview was not there. Reviewers: #plasma, nicolasfella, bshah Reviewed By: #plasma, bshah Subscribers: arojas Tags: #plasma Differential Revision: https://phabricator.kde.org/D27454 (cherry picked from commit 2420b04e3d01cd02c26e238221a7603614830d15) M +2 -2 src/kcm/package/contents/ui/Accounts.qml M +1 -3 src/kcm/package/contents/ui/AvailableAccounts.qml M +1 -2 src/kcm/package/contents/ui/AvailableServices.qml https://commits.kde.org/kaccounts-integration/67fc8d83b71f2b1304615ea087023ef66a9c9d5d *** Bug 420569 has been marked as a duplicate of this bug. *** |