| Summary: | Wishlist: Item count for tag tree is not very intuitive. Maybe show number of total items and subtags separately? | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | MarcP <iwannaberich> |
| Component: | Albums-TreeView | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | REPORTED --- | ||
| Severity: | wishlist | CC: | caulier.gilles, erlacher.thomas, galerant, iwannaberich, jan.sende, malte.boensch, metzpinguin, sophiebuk, stevef48 |
| Priority: | HI | ||
| Version First Reported In: | 7.4.0 | ||
| Target Milestone: | --- | ||
| Platform: | Appimage | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
MarcP
2019-11-23 13:14:55 UTC
Hmm, the system has not posted the commit here so far, I'm doing it manually. I decided for this variant first. Further text behind the tag name I find confusing. Since tags with subtags occur in several images and thus the total number is not correct on a collapsed tag, we do not add them together anymore. https://invent.kde.org/kde/digikam/commit/a607c4f35819e10b982844109a9b92f2d18cd8a6 Maik Hey. I tried the latest appimage (digikam-7.0.0-git-20191204T041752-x86-64.appimage) and I noticed that now the tag count only shows the number of pictures tagged with that specific tag, but ignoring subtags. Would it be possible to have a middle day, so it works exactly as the item count for Albums? That is, when expanded, only show the number of items with that tag, but when collapsed, also add the number of pictures of its subtags, but not both (The way it worked before, if a picture has a tag and a subtag, it would be counted twice). With an example it is clearer. Imagine I have a total of 57 pictures of Toronto, 10 of which also have been tagged with Ontario. This is how it used to be: Expanded: Collapsed: Ontario (10) Ontario (67) - Toronto (57) This is the current behavior (after your commit two weeks ago): Expanded: Collapsed: Ontario (10) Ontario (10) - Toronto (57) And this is how I believe would be more intuitive: Expanded: Collapsed: Ontario (10) Ontario (57) - Toronto (57) So basically the sum of both the parent and the child tags, but subtracting all elements that appear twice. And that's the problem, we have a QMap stating that tag XX1 -> occurs 5 times and tag XX2 -> 8 times. But we have no breakdown of images, so whether tag XX1 also occurs in images tagged with XX2. This would mean additional database queries. We can not afford this at this point, because it has to be done quickly. Otherwise the repaint/create of the tag model will be slow. I do not have a simple solution yet. Maik Oh, I see. So there is no quick way of showing the number of containing pictures (the number that appears at the bottom left in Digikam) without having to query each tag, right? In that case, maybe the initial behavior was more intuitive. Do you think it's better to indicate more pictures than expected, or less pictures than expected? Git commit 8493c91be80b5941d850a86e0a5dd408ebdc5348 by Maik Qualmann. Committed on 07/12/2019 at 18:42. Pushed by mqualmann into branch 'master'. Revert "do not counting subtags when collapsed" M +1 -1 core/libs/models/abstractalbummodel.cpp https://invent.kde.org/kde/digikam/commit/8493c91be80b5941d850a86e0a5dd408ebdc5348 With next digiKam 7.4.0 release, AppImage bundle is compiled using a more recent Linux Mageia 7.1 host. Last stable Qt 5.15.2 and KF5 5.84 are used. ImageMagick codec 7 and libav 58 (ffmpeg) are used to supports extra image and video formats. https://i.imgur.com/XV1tZkL.png Please check if problem still reproducible with this version available as pre-release here: https://files.kde.org/digikam/ Gilles Caulier Well, the behavior is the same. When a tag or folder is collapsed, the count number does not reflect the real number of items within it. Maik, We will left as that the implementation to prevent a slowdown rendering of tags, or there is a solution to this wish ? Gilles This behaviour is really confusing, any new about an update to get the right count ? *** Bug 477225 has been marked as a duplicate of this bug. *** *** Bug 485147 has been marked as a duplicate of this bug. *** *** Bug 486974 has been marked as a duplicate of this bug. *** *** Bug 503527 has been marked as a duplicate of this bug. *** *** Bug 507264 has been marked as a duplicate of this bug. *** In my bug I was focusing on the album tree view / not the tag view / where currently upon expanding the parent folder shows 0 https://bugs.kde.org/show_bug.cgi?id=507264 Not sure I understand the callout regarding tags…. If I have 20 images tagged with „birthday“ the number should show 20 in my mind. No matter whether the 20 images also have other tags. If from the 20 images 10 also have the tag „grandma“, it should still be 20 in my mind. But then 10 (or whatever additional photos have the tag „grandma“) when I look at that tagcount |
