Bug 413704

Summary:	Filters do not work on hidden grouped images
Product:	[Applications] digikam	Reporter:	Reinout Nonhebel <kde>
Component:	Albums-Filters	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, metzpinguin, tgiddings000
Priority:	NOR
Version:	6.3.0
Target Milestone:	---
Platform:	Manjaro
OS:	Linux
Latest Commit:	https://invent.kde.org/kde/digikam/commit/13207d2091f579cfb93ede0ad65ac1557617c2db	Version Fixed In:	7.0.0
Sentry Crash Report:

Description Reinout Nonhebel 2019-11-01 11:25:34 UTC

SUMMARY
I use Darktable to edit my images, and export the edited image in the same folder as the original (No versioning). I keep them grouped with the JPEG on top to only show the edited images. If I then use the filters panel to show RAW files, none are found as they are hidden in groups. I would like for hidden grouped files to be found by the filter as well. 

A workaround is to first expand all groups before applying the filter, but in my opinion this should not be necessary.

STEPS TO REPRODUCE
1. Make an album with two images (Jpg and RAW, I use .NEF RAW files)
2. Group the two images by filename.
3. Collapse the group. The Jpeg image is now the top of the group (as desired)
4. Use the filters panel 'MIME type filter' to show only RAW images.

OBSERVED RESULT
No images are found (Thumbnail view is empty)

EXPECTED RESULT
Only the Raw image is shown, even though it is in a collapsed group

SOFTWARE/OS VERSIONS
Manjaro Linux kernel 4.19.80-1
Gnome 3.34.1 
KDE Frameworks Version: 5.63.0
Qt Version: 5.13.1

ADDITIONAL INFORMATION
I think this is closely related to https://bugs.kde.org/show_bug.cgi?id=382311. That is marked as resolved, but I still have the problem in version 6.3.0

Comment 1 Maik Qualmann 2019-11-02 20:21:51 UTC


*** This bug has been marked as a duplicate of bug 382311 ***

Comment 2 Maik Qualmann 2019-11-02 20:23:27 UTC

*** Bug 382311 has been marked as a duplicate of this bug. ***

Comment 3 Maik Qualmann 2019-11-02 22:27:21 UTC

Git commit 13207d2091f579cfb93ede0ad65ac1557617c2db by Maik Qualmann.
Committed on 02/11/2019 at 22:25.
Pushed by mqualmann into branch 'master'.

ignore in a filtered view the grouped function
Related: bug 382311, bug 396337
FIXED-IN: 7.0.0

M  +4    -1    NEWS
M  +10   -6    core/libs/database/models/itemfiltermodel.cpp

https://invent.kde.org/kde/digikam/commit/13207d2091f579cfb93ede0ad65ac1557617c2db

Comment 4 Maik Qualmann 2019-11-10 20:40:51 UTC

Git commit cfcbed2adb646e21066c8615199586ab3cb49169 by Maik Qualmann.
Committed on 10/11/2019 at 20:38.
Pushed by mqualmann into branch 'master'.

add option in the view menu to show all groups as open
Related: bug 303239, bug 321339, bug 382311, bug 396337
FIXED-IN: 7.0.0

M  +3    -1    NEWS
M  +11   -4    core/app/items/views/digikamitemview.cpp
M  +1    -0    core/app/items/views/digikamitemview.h
M  +5    -0    core/app/main/digikamapp.cpp
M  +2    -0    core/app/main/digikamapp.h
M  +2    -0    core/app/main/digikamapp_p.h
M  +8    -1    core/app/main/digikamapp_setup.cpp
M  +3    -1    core/app/main/digikamui5.rc
M  +10   -0    core/app/views/stack/itemiconview.cpp
M  +1    -0    core/app/views/stack/itemiconview.h
M  +4    -3    core/app/views/tableview/tableview_model.cpp
M  +10   -13   core/libs/database/models/itemfiltermodel.cpp
M  +2    -0    core/libs/settings/applicationsettings.cpp
M  +3    -0    core/libs/settings/applicationsettings.h
M  +10   -0    core/libs/settings/applicationsettings_albums.cpp
M  +3    -0    core/libs/settings/applicationsettings_p.cpp
M  +2    -0    core/libs/settings/applicationsettings_p.h

https://invent.kde.org/kde/digikam/commit/cfcbed2adb646e21066c8615199586ab3cb49169

Comment 5 Reinout Nonhebel 2019-11-17 15:40:44 UTC

Tested it with the last 7.0.0 AppImage build, it works as expected now. Thanks a lot!

Comment 6 caulier.gilles 2019-11-17 15:47:11 UTC

Thanks for the feedback