| Summary: | Reply-to SMS box is incorrectly opened when a single-sign-on SMS with a "Copy" button is clicked | ||
|---|---|---|---|
| Product: | [Applications] kdeconnect | Reporter: | Simon Redman <simon> |
| Component: | common | Assignee: | Simon Redman <simon> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | aspotashev, criguada, kyrawertho, lucia.mrenica, nicolas.fella, rullger |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | b59ef618b2809b709e3f833fb0ec1b3005decaa9 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
The initial notification with the "Copy" action
The same notification as shown in the Plasmoid with no reply button |
||
Created attachment 121528 [details]
The same notification as shown in the Plasmoid with no reply button
The notification in the list of phone notifications in the Plasmoid does not have the reply action, so maybe this is a very simple bug in spawning the notification
It would be nice to have the copy action in the Plasmoid.... Maybe we should have a way to access all actions from arbitrary notifications in any case?
*** Bug 416326 has been marked as a duplicate of this bug. *** *** Bug 417554 has been marked as a duplicate of this bug. *** *** Bug 418169 has been marked as a duplicate of this bug. *** Please see https://invent.kde.org/kde/kdeconnect-kde/-/merge_requests/238 for a potential fix This should be fixed with commit b59ef618b2809b709e3f833fb0ec1b3005decaa9 (https://invent.kde.org/kde/kdeconnect-kde/commit/b59ef618b2809b709e3f833fb0ec1b3005decaa9) *** Bug 416761 has been marked as a duplicate of this bug. *** |
Created attachment 121527 [details] The initial notification with the "Copy" action SUMMARY With the patch adding notification actions on desktop and Android, if we get a one-time code from a more-secure service via SMS (not that SMS codes are actually that secure...), Google's Messages app gives no "Reply" button, no text box to type in to (on Android's notification), and instead gives a "Copy <code>" button. If we click this, it copies to the clipboard on Android, which automatically syncs to the desktop clipboard, so we can paste it in to whatever service wanted the code on the desktop. If we click the notification on the desktop, we would expect the same behavior. In fact, we do get the code into the clipboard, but in addition we get the reply-able notification reply box as a popup as well! Since there is no reply action on Android and since the button wasn't a reply button, this probably shouldn't happen. STEPS TO REPRODUCE 1. Get one-time code via SMS 2. Click "Copy XXX" button on desktop notification 3. Get code into clipboard, but also get unwanted reply box OBSERVED RESULT One-time code + Reply box EXPECTED RESULT Just one-time code SOFTWARE/OS VERSIONS Linux/KDE Plasma: Fedora 29 (available in About System) KDE Plasma Version: 5.14.5 KDE Frameworks Version: 5.58.0 Qt Version: 5.11.3 ADDITIONAL INFORMATION CCing Nico since he originally wrote the code supporting notification actions. If you think there's an obvious answer, let me know! Otherwise, I have assigned this to myself since I am the dev in the best position to debug (though it is quite low on the priority list)